)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d2dd4ee498189bc5f69a650985bf2079897880e2","unresolved":true,"context_lines":[{"line_number":18,"context_line":"So this change deletes the instance before the end of the test case to"},{"line_number":19,"context_line":"cancel the live migration and avoid leaking a greenlet and make the test"},{"line_number":20,"context_line":"case fast again."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I8341e328d4f5da5edc069eb69988fccb07353839"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"227a2843_43184b45","line":21,"updated":"2023-08-21 11:08:47.000000000","message":"I was thinking, can this be part of the test cleanup method for all created resources/server ?\n\nbut the reason is, test itself is taking extra time because live migration never finished","commit_id":"7b7b60684e2fb9f87ff8711e71d8f2b050c1660f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b6b2ecef3bbe69a6b5a178e6b369d8c6e234ef82","unresolved":true,"context_lines":[{"line_number":18,"context_line":"So this change deletes the instance before the end of the test case to"},{"line_number":19,"context_line":"cancel the live migration and avoid leaking a greenlet and make the test"},{"line_number":20,"context_line":"case fast again."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I8341e328d4f5da5edc069eb69988fccb07353839"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4b12e0cc_29afdd35","line":21,"in_reply_to":"227a2843_43184b45","updated":"2023-08-21 11:42:51.000000000","message":"Would be nice to have an automatic cleanup, but I\u0027m not sure we can easily do that without instrumenting all the way test cases create servers. In a functional env it should not matter if we don\u0027t delete a server, at the end of each test case the compute is destroyed and the DB is deleted.","commit_id":"7b7b60684e2fb9f87ff8711e71d8f2b050c1660f"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"eb4256b029b29619344ce49dc07d95e0d2738708","unresolved":false,"context_lines":[{"line_number":18,"context_line":"So this change deletes the instance before the end of the test case to"},{"line_number":19,"context_line":"cancel the live migration and avoid leaking a greenlet and make the test"},{"line_number":20,"context_line":"case fast again."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I8341e328d4f5da5edc069eb69988fccb07353839"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f37a590_796abaf7","line":21,"in_reply_to":"4b12e0cc_29afdd35","updated":"2023-08-21 16:01:44.000000000","message":"Ack","commit_id":"7b7b60684e2fb9f87ff8711e71d8f2b050c1660f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9de2b75768148f90dab800b7b5d001d490ab0841","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"74b00f3c_42288c95","updated":"2023-08-21 08:51:51.000000000","message":"Before \n\n```\n{0} nova.tests.functional.test_servers.ServersTestV280.test_get_migrations_after_live_migrate_server_in_different_project [160.083852s] ... ok\n```\n\n```\n2023-08-21 10:36:35,458 ERROR [nova.service] Service error occurred during cleanup_host\nTraceback (most recent call last):\n  File \"/home/gibi/upstream/git/openstack/nova/nova\n    /service.py\", line 297, in stop\n    self.manager.cleanup_host()\n  File \"/home/gibi/upstream/git/openstack/nova/nova/compute/manager.py\", line 1733, in cleanup_host\n    self._cleanup_live_migrations_in_pool()\n  File \"/home/gibi/upstream/git/openstack/nova/nova/compute/manager.py\", line 1737, in _cleanup_live_migrations_in_pool\n    self._live_migration_executor.shutdown(wait\u003dFalse)\n  File \"/home/gibi/upstream/git/openstack/nova/nova/tests/fixtures/nova.py\", line 1975, in \u003clambda\u003e\n    lambda self, wait: real_shutdown(self, wait\u003dTrue)))\n                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/gibi/upstream/git/openstack/nova/.tox/functional-py311/lib/python3.11/site-packages/futurist/_futures.py\", line 415, in shutdown\n    self._pool.waitall()\n  File \"/home/gibi/upstream/git/openstack/nova/.tox/functional-py311/lib/python3.11/site-packages/eventlet/greenpool.py\", line 126, in waitall\n    self.no_coros_running.wait()\n  File \"/home/gibi/upstream/git/openstack/nova/.tox/functional-py311/lib/python3.11/site-packages/eventlet/event.py\", line 125, in wait\n    result \u003d hub.switch()\n             ^^^^^^^^^^^^\n  File \"/home/gibi/upstream/git/openstack/nova/.tox/functional-py311/lib/python3.11/site-packages/eventlet/hubs/hub.py\", line 313, in switch\n    return self.greenlet.switch()\n           ^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/gibi/upstream/git/openstack/nova/.tox/functional-py311/lib/python3.11/site-packages/eventlet/hubs/hub.py\", line 365, in run\n    self.wait(sleep_time)\n  File \"/home/gibi/upstream/git/openstack/nova/.tox/functional-py311/lib/python3.11/site-packages/eventlet/hubs/poll.py\", line 77, in wait\n    time.sleep(seconds)\n  File \"/home/gibi/upstream/git/openstack/nova/.tox/functional-py311/lib/python3.11/site-packages/fixtures/_fixtures/timeout.py\", line 52, in signal_handler\n    raise TimeoutException()\nfixtures._fixtures.timeout.TimeoutException\n```\n\nAfter the fix:\n```\n{0} nova.tests.functional.test_servers.ServersTestV280.test_get_migrations_after_live_migrate_server_in_different_project [1.650405s] ... ok\n\n```","commit_id":"7b7b60684e2fb9f87ff8711e71d8f2b050c1660f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ab7a6392f9650c18b2f1d8aaed9048b18bf5c979","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48c65e1d_f5b80e0d","updated":"2023-08-21 13:39:56.000000000","message":"Makes sense to me, thanks gibi!","commit_id":"7b7b60684e2fb9f87ff8711e71d8f2b050c1660f"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d2dd4ee498189bc5f69a650985bf2079897880e2","unresolved":true,"context_lines":[{"line_number":1787,"context_line":"        # Get the migration records by not exist project_id"},{"line_number":1788,"context_line":"        migrations \u003d new_admin_api.get_migrations(project_id\u003dproject_id_2)"},{"line_number":1789,"context_line":"        self.assertEqual([], migrations)"},{"line_number":1790,"context_line":""},{"line_number":1791,"context_line":"        self._delete_server(server)"},{"line_number":1792,"context_line":""},{"line_number":1793,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"04ad7da8_400a64a4","line":1790,"updated":"2023-08-21 11:08:47.000000000","message":"this assert is checking if there are any migration going on for project_2 but migration started for project_1 !\n\nso we don\u0027t know if live-migration for project_1 ever finished.","commit_id":"7b7b60684e2fb9f87ff8711e71d8f2b050c1660f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b6b2ecef3bbe69a6b5a178e6b369d8c6e234ef82","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"        # Get the migration records by not exist project_id"},{"line_number":1788,"context_line":"        migrations \u003d new_admin_api.get_migrations(project_id\u003dproject_id_2)"},{"line_number":1789,"context_line":"        self.assertEqual([], migrations)"},{"line_number":1790,"context_line":""},{"line_number":1791,"context_line":"        self._delete_server(server)"},{"line_number":1792,"context_line":""},{"line_number":1793,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ba868f5_b1c9ace6","line":1790,"in_reply_to":"04ad7da8_400a64a4","updated":"2023-08-21 11:42:51.000000000","message":"The goal of the test case is just to see if migration filtering works by project_id. So it just started a migration and checked the filtering.","commit_id":"7b7b60684e2fb9f87ff8711e71d8f2b050c1660f"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"eb4256b029b29619344ce49dc07d95e0d2738708","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"        # Get the migration records by not exist project_id"},{"line_number":1788,"context_line":"        migrations \u003d new_admin_api.get_migrations(project_id\u003dproject_id_2)"},{"line_number":1789,"context_line":"        self.assertEqual([], migrations)"},{"line_number":1790,"context_line":""},{"line_number":1791,"context_line":"        self._delete_server(server)"},{"line_number":1792,"context_line":""},{"line_number":1793,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"abd14857_255885bd","line":1790,"in_reply_to":"9ba868f5_b1c9ace6","updated":"2023-08-21 16:01:44.000000000","message":"ACK, thanks","commit_id":"7b7b60684e2fb9f87ff8711e71d8f2b050c1660f"}]}