)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"48d45698688749b3c3f9ed3be667f96f94212f7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47e574bc_2f19c4f9","updated":"2023-08-25 15:52:50.000000000","message":"This is enough to get an alias on the disk device with the volume uuid. I just wanted to do this before writing a spec to kinda get my feet wet.\n\nKashyap can I put you down for the network interface equivalent of this (and the actual lookup/filtering) in the spec?","commit_id":"673a5f5611fbe4327df0568e42aefa532b053753"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5b034936d2ea444e163dddbf1fe85e815f05e362","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"39265383_e3b3afaa","updated":"2023-11-15 15:17:24.000000000","message":"IMHO, those two bottom patches are so small that we could have squashed them but meh.","commit_id":"9a62959edd3690ededd3f27b3b7c27c5085a7576"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c978a27f75c35aa2110a774eb84175f17e1dd86d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9c9cbcb0_1ffe2add","updated":"2023-11-15 16:40:39.000000000","message":"The inbound failure in the nova-lvm job is an eventlet failure during unrescue, unrelated:\n```\nNov 15 16:04:23.881058 np0035770595 nova-compute[83346]: greenlet.error: cannot switch to a different thread\n```","commit_id":"9a62959edd3690ededd3f27b3b7c27c5085a7576"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"560b57e7d61267697158076da363f0ec80d942c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa42c764_7ee1f472","updated":"2023-11-15 15:31:49.000000000","message":"gibi\u0027s comment is adress and this looks fine to me so +2w","commit_id":"9a62959edd3690ededd3f27b3b7c27c5085a7576"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"da1ae5a4e5c0742b52e827b1a835470ab8591eb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b44d4139_89daa72c","updated":"2023-11-15 17:39:57.000000000","message":"recheck eventlet fail","commit_id":"9a62959edd3690ededd3f27b3b7c27c5085a7576"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"efb39c97a41df36461c232f10f25717f9042210a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cd4e20d8_15c63349","updated":"2023-11-15 20:03:59.000000000","message":"recheck looks like apache timeout or other problem, multiple http fails from tempest and nova to glance, etc","commit_id":"9a62959edd3690ededd3f27b3b7c27c5085a7576"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"97e6c1cf2f5063448ae0cda5d5ee320f211330c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"835b4e05_fd643af3","updated":"2023-12-09 08:49:27.000000000","message":"recheck timeout","commit_id":"9a62959edd3690ededd3f27b3b7c27c5085a7576"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6bf882c9c04487c3b71789b1fda2d7008df1dfa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0b2e2d09_eb84dd6f","updated":"2023-12-08 12:54:21.000000000","message":"recheck, we have merge a few ci stablity fixes over the last few days so lets see if that helps","commit_id":"9a62959edd3690ededd3f27b3b7c27c5085a7576"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0b9b6b22018f68bbb4134ea621d813a7de4ab875","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"84b4f539_124c345b","updated":"2023-11-16 09:50:51.000000000","message":"thanks for the fixup","commit_id":"9a62959edd3690ededd3f27b3b7c27c5085a7576"}],"nova/virt/libvirt/volume/volume.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af4fbe34cb358bff6827acde8de980ad7d03ba36","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            conf.shareable \u003d True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        volume_id \u003d driver_block_device.get_volume_id(connection_info)"},{"line_number":121,"context_line":"        conf.alias \u003d \u0027ua-%s\u0027 % volume_id"},{"line_number":122,"context_line":"        volume_secret \u003d None"},{"line_number":123,"context_line":"        if volume_id:"},{"line_number":124,"context_line":"            volume_secret \u003d self.host.find_secret(\u0027volume\u0027, volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4534330e_3e76f303","line":121,"updated":"2023-11-15 08:45:28.000000000","message":"Could this use the make_libvirt_device_alias() function introduced by the parent patch?","commit_id":"3475d3b1b65e224596b94e8f7570667eaeecac84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"560b57e7d61267697158076da363f0ec80d942c5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            conf.shareable \u003d True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        volume_id \u003d driver_block_device.get_volume_id(connection_info)"},{"line_number":121,"context_line":"        conf.alias \u003d \u0027ua-%s\u0027 % volume_id"},{"line_number":122,"context_line":"        volume_secret \u003d None"},{"line_number":123,"context_line":"        if volume_id:"},{"line_number":124,"context_line":"            volume_secret \u003d self.host.find_secret(\u0027volume\u0027, volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f8c10be0_88f143fa","line":121,"in_reply_to":"08126c4a_c76e1934","updated":"2023-11-15 15:31:49.000000000","message":"Done","commit_id":"3475d3b1b65e224596b94e8f7570667eaeecac84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"89581b840d89cd2559bf140edd91e8cc1261191f","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            conf.shareable \u003d True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        volume_id \u003d driver_block_device.get_volume_id(connection_info)"},{"line_number":121,"context_line":"        conf.alias \u003d \u0027ua-%s\u0027 % volume_id"},{"line_number":122,"context_line":"        volume_secret \u003d None"},{"line_number":123,"context_line":"        if volume_id:"},{"line_number":124,"context_line":"            volume_secret \u003d self.host.find_secret(\u0027volume\u0027, volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d941a169_cdaa0a0e","line":121,"in_reply_to":"4534330e_3e76f303","updated":"2023-11-15 13:36:35.000000000","message":"oh ya that woudl certenly make sense to use here\nit woudl just be conf.make_libvirt_device_alias(volume_id)\n\nchatting to dan on irc yesterday sometime the connection_info can be missing a volume id\n\nso we may need to actull grab that form our bdms and pass it into this function instead or populate it into the connect_info if its missing before calling this.","commit_id":"3475d3b1b65e224596b94e8f7570667eaeecac84"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"22855c8073cd1319af179e47ebd817f47d7dc40a","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            conf.shareable \u003d True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        volume_id \u003d driver_block_device.get_volume_id(connection_info)"},{"line_number":121,"context_line":"        conf.alias \u003d \u0027ua-%s\u0027 % volume_id"},{"line_number":122,"context_line":"        volume_secret \u003d None"},{"line_number":123,"context_line":"        if volume_id:"},{"line_number":124,"context_line":"            volume_secret \u003d self.host.find_secret(\u0027volume\u0027, volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"08126c4a_c76e1934","line":121,"in_reply_to":"d941a169_cdaa0a0e","updated":"2023-11-15 14:37:43.000000000","message":"Sure, I added that helper after I wrote this code so I just missed converting this. Thanks!","commit_id":"3475d3b1b65e224596b94e8f7570667eaeecac84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"560b57e7d61267697158076da363f0ec80d942c5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            conf.shareable \u003d True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        volume_id \u003d driver_block_device.get_volume_id(connection_info)"},{"line_number":121,"context_line":"        conf.alias \u003d vconfig.make_libvirt_device_alias(volume_id)"},{"line_number":122,"context_line":"        volume_secret \u003d None"},{"line_number":123,"context_line":"        if volume_id:"},{"line_number":124,"context_line":"            volume_secret \u003d self.host.find_secret(\u0027volume\u0027, volume_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b335a844_a2aa770d","line":121,"updated":"2023-11-15 15:31:49.000000000","message":"oh right this is a module level fucntion not a class funciton\nso its vconfig.make_libvirt_device_alias not conf.make_libvirt_device_alias\n\nhttps://review.opendev.org/c/openstack/nova/+/892800/3/nova/virt/libvirt/config.py#45","commit_id":"9a62959edd3690ededd3f27b3b7c27c5085a7576"}]}