)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"22ce93aa90a5d27101e257ec4df71d3093dd9b3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7652d48b_db05737d","updated":"2023-08-29 18:41:53.000000000","message":"recheck\n\nfailure in nova-next does not seems to be related","commit_id":"b602309ef8b1fba9c9c5f8363dd0a26a8af7ea04"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"321e9a0d5db75f5485ad04239390a2d40921c62c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"71fcdcdc_631ae261","updated":"2023-09-18 11:25:59.000000000","message":"@Sean,","commit_id":"19cad7a03495bfa66afce508556afb213973d8df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4fe40736cb421ee1475dffcf0dea7864d9a9b651","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e2be3db6_9ae51b5e","updated":"2023-08-31 16:36:09.000000000","message":"api change alwasys require specs this cannot be done as a bug fix","commit_id":"19cad7a03495bfa66afce508556afb213973d8df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2393fe1149c627f31dd7b22941ba6d12eefe9c08","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"64ecf0ea_5d6b8599","in_reply_to":"33da9c25_ba086c00","updated":"2024-07-29 23:21:14.000000000","message":"if we wanted to change the normalistaiton i think that shoudl ahve a new api microversion and that woudl reqruie  a spec.\n\neven if we ketp this as a bug i woudl not be in faovr of backporting this change\nas it has potital upgrade impoacts as it change the hostname in the guest.","commit_id":"19cad7a03495bfa66afce508556afb213973d8df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fbc642c888428de3275726130248923482ab5c2a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f6318a5d_3af65e4c","in_reply_to":"43f78fec_f8ab5afd","updated":"2025-02-25 04:30:35.000000000","message":"a hostname in nova is not required to be a valid domain name or confirm to rfc5891, \nwe also do not supprot unicode hosname or internationalised hostnames in general\n\nthey the user may provide a hostname that confrom to that spec but its not an api requirement or garuentee that nova proivdes.\n\ni.e. you as a user of nova cannot assume teh hostname will be compatible with rfc5891","commit_id":"19cad7a03495bfa66afce508556afb213973d8df"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6048fefb8d9263e86ee772ab5dcf686c3306b126","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"43f78fec_f8ab5afd","in_reply_to":"64ecf0ea_5d6b8599","updated":"2025-02-24 16:31:55.000000000","message":"@smooney@redhat.com does it mean that nova allows to set invalid instance hostname that not fits https://www.rfc-editor.org/rfc/rfc5891#section-4.2.3.1 specification? Should we add this restriction on nova API side and reject such requests?","commit_id":"19cad7a03495bfa66afce508556afb213973d8df"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"321e9a0d5db75f5485ad04239390a2d40921c62c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff8c5945_bcb6f224","in_reply_to":"e2be3db6_9ae51b5e","updated":"2023-09-18 11:25:59.000000000","message":"why is that an API change? this is replacing the letters in the hostname, not failing the request.\n\ne.g. I do not see any specs were required for example here https://review.opendev.org/c/openstack/nova/+/764482\n\nThis is actually fixing a regression - now DHCP will fail for the instance with the name `fo--o` when neutron is running e.g. dnsmasq on Ubuntu 22.04\n\nand unfortunately, these are quite possible names when Heat generates server names from stack names","commit_id":"19cad7a03495bfa66afce508556afb213973d8df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6686b5a1ebbb894cd0d972b85c76d6ea50e4b821","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b484054d_9376c2e5","in_reply_to":"f6318a5d_3af65e4c","updated":"2025-02-25 05:07:48.000000000","message":"i should point out that section 4.2.3.1 applies to unicode string and\nnova requires the hostname is ascii.\n\n\n```\n4.2.3.1.  Hyphen Restrictions\n\n   The Unicode string MUST NOT contain \"--\" (two consecutive hyphens) in\n   the third and fourth character positions and MUST NOT start or end\n   with a \"-\" (hyphen).\n```\n\nwe blocked all unicode names in our default transformation in \n\nhttps://github.com/openstack/nova/commit/bc6f30de953303604625e84ad2345cfb595170d2\n\nyou can specify rfc5891 compatibale hostnames when using a non compatible display name if you desire as of micoveroin 2.90 and fqdns are supproted with 2.94\n\nnova will not validate those for you beyond basic length limits and some other basic validation.\n\nwhere the basic generation of an ascii hostname from the display name is not sufficte that is the way for users of the api to overried the default behavior.\n\nthe only way for use to make this change in nova is to have a new api microvrion to opt into the new bahvior. there is mroe to supproting internationalised hostnames then just this restrction however.","commit_id":"19cad7a03495bfa66afce508556afb213973d8df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66cfb83abc5e49ec1fcbd87268cf262efa4ea05c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"33da9c25_ba086c00","in_reply_to":"ff8c5945_bcb6f224","updated":"2024-07-29 23:18:09.000000000","message":"its an api change because we would be modifying the behavior of the api by extending the normalisation.\n\nhttps://review.opendev.org/c/openstack/nova/+/764482 was done because nova\ndid not support FQDN in the host name feild.\nwhen we resolved https://bugs.launchpad.net/nova/+bug/1581977 with that change several people complained that even though we never suported that usecause they had depened on the fact nova did not block it.\n\nso we then had to intoduce https://specs.openstack.org/openstack/nova-specs/specs/2023.1/implemented/fqdn-in-hostname.html to com up with a resolution that added limited supprot for fqdns while also keeping nova out of networking.\n\nwe really dont want to be in the busness fo normalising the host name anymore and as a result of the last tiem we made a simple change we are also much less inclined to make future chagnes as bug fixes in this area of the code.","commit_id":"19cad7a03495bfa66afce508556afb213973d8df"}],"nova/utils.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e285a93227c1d8f0874a0b903e707b5e8d33c6ea","unresolved":true,"context_lines":[{"line_number":383,"context_line":"    hostname \u003d re.sub(r\u0027[^\\w.-]+\u0027, \u0027\u0027, hostname)"},{"line_number":384,"context_line":"    hostname \u003d hostname.lower()"},{"line_number":385,"context_line":"    hostname \u003d hostname.strip(\u0027.-\u0027)"},{"line_number":386,"context_line":"    # NOTE(pas-ha): double hyphen as 3rd and 4th character"},{"line_number":387,"context_line":"    # is invalid under rfc5891, replace with single hyphen"},{"line_number":388,"context_line":"    if hostname[2:4] \u003d\u003d \"--\":"},{"line_number":389,"context_line":"        hostname \u003d hostname[0:3] + hostname[4:]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ae17e10c_107e1886","line":386,"range":{"start_line":386,"start_character":6,"end_line":386,"end_character":10},"updated":"2023-08-29 15:31:07.000000000","message":"maybe regex is better \nhostname \u003d re.sub(r’^(..)(-{2,})‘, r’\\1-’, hostname)\nto cover cases for fo-----baz.com. as well?","commit_id":"95ccc0f0b6b910415641148c0bd58d231a152116"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"7c230e686eeadddae70b391377a04405b4d4a3c0","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    hostname \u003d re.sub(r\u0027[^\\w.-]+\u0027, \u0027\u0027, hostname)"},{"line_number":384,"context_line":"    hostname \u003d hostname.lower()"},{"line_number":385,"context_line":"    hostname \u003d hostname.strip(\u0027.-\u0027)"},{"line_number":386,"context_line":"    # NOTE(pas-ha): double hyphen as 3rd and 4th character"},{"line_number":387,"context_line":"    # is invalid under rfc5891, replace with single hyphen"},{"line_number":388,"context_line":"    if hostname[2:4] \u003d\u003d \"--\":"},{"line_number":389,"context_line":"        hostname \u003d hostname[0:3] + hostname[4:]"}],"source_content_type":"text/x-python","patch_set":2,"id":"17c6a6cd_e46f4bb3","line":386,"range":{"start_line":386,"start_character":6,"end_line":386,"end_character":10},"in_reply_to":"ae17e10c_107e1886","updated":"2023-08-29 15:36:37.000000000","message":"Done","commit_id":"95ccc0f0b6b910415641148c0bd58d231a152116"}]}