)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"08d8ecb53232a83945f76749ba93d98a23aa8619","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb063c8b_c4d91304","updated":"2023-11-20 06:03:22.000000000","message":"recheck docs","commit_id":"ef7255c85c41c8474f622df1e6612639e326c7d0"}],"nova/tests/functional/api_sample_tests/test_volumes.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8f7344ff0423c81278d5ba1f5e4f803fa2a846b8","unresolved":true,"context_lines":[{"line_number":228,"context_line":"                \u0027volumeId\u0027: self.NEW_VOLUME_ID"},{"line_number":229,"context_line":"            }"},{"line_number":230,"context_line":"        }"},{"line_number":231,"context_line":"        self.api.post_server_volume(self.server_id, body)"},{"line_number":232,"context_line":"        response \u003d self._do_get(\u0027servers/%s/os-volume_attachments\u0027"},{"line_number":233,"context_line":"                                % self.server_id)"},{"line_number":234,"context_line":"        subs[\u0027volume_id2\u0027] \u003d self.NEW_VOLUME_ID"}],"source_content_type":"text/x-python","patch_set":2,"id":"316ff9c7_9bc74b5e","line":231,"updated":"2023-09-04 07:35:45.000000000","message":"so this the only pending case now. beause at L203, _post_server is returning server_id and not whole server_object,I tried to replace it with _create_server which return whole server object, but tests failed for different reason.\n\n\nsimple solution would be _attach_volumes takes server_id as its only creating body and then calling the API, so not really required a whole server.\n\nreason why I do not want to change _attach_volumes to take only serve-id instead of whole server object is\nin case in future we may need some other property of server required to attach_volumes, we have to again update all the test cases.\n   \n\nwill come back to it later to fix the errors, nut it would be nice to have reviews here.","commit_id":"89e5296c48480f2fb7d94ff2b69cdff56432fe9d"}]}