)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"be5b1fc4e413322a5ae49caa92b8b8a5270842b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0273274_0ffe8390","updated":"2024-01-15 04:54:25.000000000","message":"Hi Sean and Sylvain,\n\nCould you please take a look at it when you have a moment?\nThe spec [1] has already been approved.\n\n[1] https://review.opendev.org/c/openstack/nova-specs/+/895135","commit_id":"c3d4b81e3037dba77d085c9557f15f99952b92ef"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9e466f12c886151c52ffaa895f9b9a633f7206c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e70da7ad_b930ac58","updated":"2024-01-23 10:08:46.000000000","message":"Looks good to me but I don\u0027t see the other needed changes. Have you already implemented the other modifications that you were saying in the spec ?\n\nIf not, I can\u0027t really +2 that change as it\u0027s not really used yet.","commit_id":"c3d4b81e3037dba77d085c9557f15f99952b92ef"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"3512ad65f50cb959da9136adc53575d433afa7be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04b96b56_9e266b84","updated":"2023-12-14 08:51:19.000000000","message":"The spec [1] has been merged and I will continue with this implementation.\nCould you please take a look?\n\n[1] https://review.opendev.org/c/openstack/nova-specs/+/895135","commit_id":"c3d4b81e3037dba77d085c9557f15f99952b92ef"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"546d9e8b5d1566342c19e7d565a3fcb9207cbc21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d0d525a_e3e14c14","updated":"2023-12-14 01:45:09.000000000","message":"recheck unrelated failure","commit_id":"c3d4b81e3037dba77d085c9557f15f99952b92ef"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"9ea92b5ba3457c1e51cf79a980f72d2d1966d3a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c67907ce_300308e6","updated":"2023-12-14 06:24:18.000000000","message":"recheck unrelated failure","commit_id":"c3d4b81e3037dba77d085c9557f15f99952b92ef"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"5efc9e754c0a224525db8d30f1fe2bba8f244932","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37162c50_522e1e3b","in_reply_to":"41aa9101_66a0dd25","updated":"2024-02-02 05:34:48.000000000","message":"\u003e Looks good to me but I don\u0027t see the other needed changes. Have you already\n\u003e implemented the other modifications that you were saying in the spec ?\n\u003e If not, I can\u0027t really +2 that change as it\u0027s not really used yet.\n\nHi Sylvain,\n\nI have sent a new patch [1] that meets this blueprint\u0027s requirements.\nAnd I have confirmed that it works with devstack.\n\nCould you please review the new patch?\n\n[1] https://review.opendev.org/c/openstack/nova/+/907516","commit_id":"c3d4b81e3037dba77d085c9557f15f99952b92ef"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"041c5358472d7ecc4007c70bc92d7f5d295d2eb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41aa9101_66a0dd25","in_reply_to":"e70da7ad_b930ac58","updated":"2024-01-24 10:05:55.000000000","message":"Thanks for the review.\nI\u0027ll implement all the items listed in the spec and then post patches again.","commit_id":"c3d4b81e3037dba77d085c9557f15f99952b92ef"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9e466f12c886151c52ffaa895f9b9a633f7206c7","unresolved":false,"context_lines":[{"line_number":626,"context_line":"            \u003ccpu match\u003d\"exact\"\u003e"},{"line_number":627,"context_line":"              \u003cmaxphysaddr mode\u003d\"passthrough\"/\u003e"},{"line_number":628,"context_line":"            \u003c/cpu\u003e"},{"line_number":629,"context_line":"        \"\"\")"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"class LibvirtConfigGuestSMBIOSTest(LibvirtConfigBaseTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c704918_165cdc28","line":629,"updated":"2024-01-23 10:08:46.000000000","message":"other tests don\u0027t verify we correctly create the right object with right attributes (from the XML) so I won\u0027t ask for it.","commit_id":"c3d4b81e3037dba77d085c9557f15f99952b92ef"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"041c5358472d7ecc4007c70bc92d7f5d295d2eb7","unresolved":false,"context_lines":[{"line_number":626,"context_line":"            \u003ccpu match\u003d\"exact\"\u003e"},{"line_number":627,"context_line":"              \u003cmaxphysaddr mode\u003d\"passthrough\"/\u003e"},{"line_number":628,"context_line":"            \u003c/cpu\u003e"},{"line_number":629,"context_line":"        \"\"\")"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"class LibvirtConfigGuestSMBIOSTest(LibvirtConfigBaseTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"26958698_cbf77113","line":629,"in_reply_to":"1c704918_165cdc28","updated":"2024-01-24 10:05:55.000000000","message":"OK. Other tests seem to check that way.","commit_id":"c3d4b81e3037dba77d085c9557f15f99952b92ef"}]}