)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"385a31099a192bcacf74abd6d0c2101b5d5798a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"592ea68c_cdc78984","updated":"2024-03-01 15:10:37.000000000","message":"Goes to the gate","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6c0dd88865cd23934d8239fdfddf288f7d99af8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8ac39dc7_631def22","updated":"2024-03-01 10:40:29.000000000","message":"Sorry, but I have no context and I don\u0027t know why we should merge it by now. Pleas explain me more.","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"38f3d1ae4790a828ab372110f9fe6eeebb79f008","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6e4fc44_1a75ab32","updated":"2024-02-28 11:11:25.000000000","message":"im not sure i see the point in doing this if nothing is calling these functions.\n\nwe can do this whne they are actully needed.","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eeb2c865e8541e2b19a2e90b3953aec2fa810eb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3cdc48ea_cf59dac1","updated":"2024-03-01 21:16:49.000000000","message":"recheck","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"de3877b9d4a0be12e0df0b61e1305de8df6cf233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7607d5f7_ab2f9142","updated":"2024-03-04 12:29:42.000000000","message":"recheck - guest kernel panic - tempest-integrated-compute-enforce-scope-new-defaults job","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"45aa076f7bcdd3044a4710c544fcd5cc213761bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c02d7948_a6700856","updated":"2024-03-06 03:21:10.000000000","message":"recheck different jobs fail randomly...","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac3895dfb0c71cce27434e0462e234172d5f7b24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b30db896_9e6c8e87","updated":"2024-03-05 10:27:39.000000000","message":"recheck irrelevant failure","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"50208ae2b014a3cb3e6b3731e0f2197b90887a9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8dc69504_0c6ef5be","updated":"2024-03-06 07:35:49.000000000","message":"recheck irrelevant timeout in nova-ceph-multistore","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6f30d81c71de0e5c50ccd35803f146ec5b3afa95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c070fc64_b5ecbcc1","updated":"2024-03-02 21:14:20.000000000","message":"recheck rsync errors in post","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"17e516b77127e18847a933b380b62fc6d989499b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c60002f5_c2834f04","updated":"2024-03-01 17:35:41.000000000","message":"recheck tempest-integrated-compute-enforce-scope-new-defaults timed out","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"340ac453082cfd30b24c02e59718c49ca444909c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77551119_ab72aabe","updated":"2024-03-05 16:20:47.000000000","message":"recheck unrelated failure","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b1be158501276c611fead44dcf712416f42fe5ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cfbbc28a_02ff8368","updated":"2024-03-04 08:09:06.000000000","message":"recheck unrelated failure","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b4eb375849678ab8e0a1d30255d48262538c12a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"565e8eab_d8ce6ef5","updated":"2024-02-28 11:25:39.000000000","message":"reluctant +2","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b3f88bd97f5e380509f90ca160a4eaf7f915023f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6813086f_d11dbd3d","updated":"2024-02-28 08:33:32.000000000","message":"the future is now, see https://review.opendev.org/c/openstack/requirements/+/910221","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"385a31099a192bcacf74abd6d0c2101b5d5798a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed662532_5e1d0019","in_reply_to":"038ccd11_9741a3b4","updated":"2024-03-01 15:10:37.000000000","message":"OK, I\u0027m just a bit sad it\u0027s a bit late.","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85fd4c22eaec7ade441706cb6694d3ee8c885d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"038ccd11_9741a3b4","in_reply_to":"14e3642a_ff1d652c","updated":"2024-03-01 14:29:42.000000000","message":"i agree with this ^","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c3b072b5107447b5f5b0868a3528ee4a24dbb9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14e3642a_ff1d652c","in_reply_to":"8ac39dc7_631def22","updated":"2024-03-01 11:48:19.000000000","message":"This should have been merged 5 months ago when it was first proposed. We\u0027ve been blocked from bumping u-c since because that hasn\u0027t happened. It\u0027s an issue now because we need to release Castellan for Caracal and we can\u0027t do that until Nova adopts.\n\nCan we please just merge this and move?","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"}],"nova/keymgr/conf_key_mgr.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b4eb375849678ab8e0a1d30255d48262538c12a","unresolved":true,"context_lines":[{"line_number":46,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class ConfKeyManager(key_manager.KeyManager):"},{"line_number":50,"context_line":"    \"\"\"This key manager implementation supports all the methods specified by"},{"line_number":51,"context_line":"    the key manager interface. This implementation creates a single key in"},{"line_number":52,"context_line":"    response to all invocations of create_key. Side effects"}],"source_content_type":"text/x-python","patch_set":1,"id":"d602adb8_c92e8aed","line":49,"range":{"start_line":49,"start_character":33,"end_line":49,"end_character":43},"updated":"2024-02-28 11:25:39.000000000","message":"oh i see keyManager is an abstact class and need implmentions of these methods.\n\nthis should be called out in the commit message.\nalso castalan should have implemented them raising not implmented as you have done in the base class to avoid breaking everyone.\n\n\nTypeError: Can\u0027t instantiate abstract class ConfKeyManager with abstract methods add_consumer, remove_consumer\n\nthis was added in https://review.opendev.org/c/openstack/castellan/+/859112\nbut reverted in stable only https://review.opendev.org/c/openstack/castellan/+/895502\n\ni really dont like how this was added without a default implemation and i really dont like doing stable only revert.\n\nif we are reverting on stable we should revert on master first.\nthis is very late in the cycle to do lib bumps. \n\nthe non clinet lib freeze used to be the deadline for doing a release and requirement bump of non clint libs. it was not the deadline for mergin code into them so from my perspective this should have been done a week ago.\n\n\nim not going to block this but IMO this should have been done before the non-clinet lib freeze and supproting the new release of castalan is an excpetion to that policy.","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6c0dd88865cd23934d8239fdfddf288f7d99af8b","unresolved":true,"context_lines":[{"line_number":46,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class ConfKeyManager(key_manager.KeyManager):"},{"line_number":50,"context_line":"    \"\"\"This key manager implementation supports all the methods specified by"},{"line_number":51,"context_line":"    the key manager interface. This implementation creates a single key in"},{"line_number":52,"context_line":"    response to all invocations of create_key. Side effects"}],"source_content_type":"text/x-python","patch_set":1,"id":"69b572b4_4e621a74","line":49,"range":{"start_line":49,"start_character":33,"end_line":49,"end_character":43},"in_reply_to":"d602adb8_c92e8aed","updated":"2024-03-01 10:40:29.000000000","message":"First, thanks Sean for the explanations, but I wonder how we went into this situation post-client feature freeze.\n\nInstead of trying to fix Nova in a rush, I\u0027d rather prefer that the new castellan version would be on upper-constraints by the Dalmatian release.\nPlease explain me then why it wouldn\u0027t be accepted to use in Dalmatian if it\u0027s a priority and why.","commit_id":"14972080fd8362c0f624cc43ead3dcf346e52d39"}]}