)]}'
{".pre-commit-config.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dd268705018d0cce78a6c9efcd919466135d543","unresolved":true,"context_lines":[{"line_number":46,"context_line":"      - id: mypy"},{"line_number":47,"context_line":"        additional_dependencies:"},{"line_number":48,"context_line":"          - types-paramiko"},{"line_number":49,"context_line":"        # keep this in-sync with \u0027[mypy] files\u0027 in \u0027setup.cfg\u0027"},{"line_number":50,"context_line":"        files: |"},{"line_number":51,"context_line":"          (?x)("},{"line_number":52,"context_line":"            nova/compute/manager.py"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"76094d8a_943215cb","line":49,"updated":"2023-09-22 14:06:15.000000000","message":"slight unfortunete that we need to keep them in sync instead of jsut haveign it in one place. is there ay way to have only one file?","commit_id":"db62fc537ccd0729ee50a4e44999e74beaef6d57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a3af1bbd2394e33c66ff93e7203ec3fbb5019c6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      - id: mypy"},{"line_number":47,"context_line":"        additional_dependencies:"},{"line_number":48,"context_line":"          - types-paramiko"},{"line_number":49,"context_line":"        # keep this in-sync with \u0027[mypy] files\u0027 in \u0027setup.cfg\u0027"},{"line_number":50,"context_line":"        files: |"},{"line_number":51,"context_line":"          (?x)("},{"line_number":52,"context_line":"            nova/compute/manager.py"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a7e325de_a44c6003","line":49,"in_reply_to":"76094d8a_943215cb","updated":"2023-09-22 16:34:26.000000000","message":"Not that I\u0027m aware of. The [mypy config file docs](https://mypy.readthedocs.io/en/stable/config_file.html#confval-files) explicitly say:\n\n\u003e `files`\n\u003e\n\u003e A comma-separated list of paths which should be checked by mypy *if none are given on the command line.*\n\n(emphasis mine)\n\nSince `pre-commit` passes the files on the command-line, we need to tell both to ignore this. It\u0027s an unfortunate bit of duplication but it\u0027s only two places and ultimately not worth e.g. templating out IMO","commit_id":"db62fc537ccd0729ee50a4e44999e74beaef6d57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df5b337cdbc8eceadeb3049212b53643785b269d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      - id: mypy"},{"line_number":47,"context_line":"        additional_dependencies:"},{"line_number":48,"context_line":"          - types-paramiko"},{"line_number":49,"context_line":"        # keep this in-sync with \u0027[mypy] files\u0027 in \u0027setup.cfg\u0027"},{"line_number":50,"context_line":"        files: |"},{"line_number":51,"context_line":"          (?x)("},{"line_number":52,"context_line":"            nova/compute/manager.py"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3ee2a9ef_69ce9988","line":49,"in_reply_to":"a7e325de_a44c6003","updated":"2023-09-22 16:35:10.000000000","message":"The other obvious solution is to do the absolute minimum to get mypy passing on all our non-test files and switch to an exlude list (for the tests) but that\u0027s a little more work.","commit_id":"db62fc537ccd0729ee50a4e44999e74beaef6d57"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6fb2e69339d5f987ccf6d06072782dab3cc38fbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"998d054d_f925cf13","updated":"2023-10-02 14:12:33.000000000","message":"Same concern here than with https://review.opendev.org/c/openstack/nova/+/896226/2 I don\u0027t want to add more pre-commit hooks.","commit_id":"9ee5f73832a7db0e505b4d0e72ebe76755c5e55e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b128fdbf41e5188ddc0147a8fb2a733a2b76d8b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"77b02ec4_83c50295","in_reply_to":"7cdb6e8e_b30e30b3","updated":"2023-12-05 12:36:23.000000000","message":"just to be clear the way this is impelnted if previously ran the mypy target with\n\ntox -e mypy you still can.\n\nnow instead of tox create a venv and installing mypy directly it creates a venev and lest pre-commit manage the installation of mypy\n\nthen precommit will run it insted of our custom bash script so as stephen siad theis si functionaliy identically and the UX has not changed either.","commit_id":"9ee5f73832a7db0e505b4d0e72ebe76755c5e55e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f341b452a7873810ae8f77784dc06506d69f720c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7cdb6e8e_b30e30b3","in_reply_to":"998d054d_f925cf13","updated":"2023-10-02 15:03:12.000000000","message":"Functionally, this is doing exactly what we\u0027re doing currently. The only difference is that we\u0027re calling `mypy` via the pre-commit wrapper (so folks using this can benefit from this tool) instead of a custom bash wrapper. Nothing functionally changes for users who don\u0027t wish to use pre-commit.","commit_id":"9ee5f73832a7db0e505b4d0e72ebe76755c5e55e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"09397782238910c45aac13be5926b207d7592fd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dc758755_bbe55bf2","updated":"2023-12-19 22:49:32.000000000","message":"Looks OK to me, +1 to keeping functionality and UX the same","commit_id":"c5e0d64fa5b0700298be4a5dd759212c256f6c1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"81c389430dc1a143bc9d4a3de66fadc3c1a83169","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2d2dfb0c_b69fceed","updated":"2023-12-20 15:06:40.000000000","message":"recheck clearly an unrelated failure","commit_id":"c5e0d64fa5b0700298be4a5dd759212c256f6c1e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b8b150fa057f8e82ec73a6f0abd5f29bb6809592","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c97ce0c3_7026704a","updated":"2023-12-21 00:54:15.000000000","message":"recheck tempest-integrated-compute timed out again.","commit_id":"e3e35ba2d078e0e779895c10000bc75df09f46ee"}]}