)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4c8623962a5f42d5f7a20841fe60f9289ffbdde0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"34c90cbd_c0e17d33","updated":"2023-10-02 14:20:14.000000000","message":"Okay, I know there are people in the Nova community that would want to have Nova supporting black.\nThat said, this is as far as I know not yet something as a consensus within our team, and I can hear arguments against black. \nOn a personal view, I do have some of those arguments and I\u0027d like us to discuss them on a PTG session.\n\nAs a PTL, I think we can hardly merge this change until we have a consensus and it would be very difficult to revert this change if someone has concerns, per our revert policy :\nhttps://docs.openstack.org/nova/latest/contributor/policies.html#reverts-for-retrospective-vetos\n\nFor that specific last reason, I\u0027m not replying with a -1 but rather a -2. \nPlease add your topic in the Caracal etherpad if you want to discuss about black (if you can\u0027t I will eventually do).","commit_id":"fa8d1af69cbe59b0dd219092e81344f81bed44ea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b679197746d6850c8da0ea02c8864ad1d602db75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3d196a47_ef9b5832","updated":"2023-10-02 14:34:12.000000000","message":"Yes, I am not only personally very against black syntax by itself, I think converting the codebase like this is a mistake. I also think adding new black formatted code is a mistake, but for some reason we\u0027ve allowed it and made our code messy-er in the process, IMHO.\n\nWe can (and I\u0027m sure we will) debate the merits of decisions made in the black spec, and of using a formatting tool in general. I don\u0027t buy the \"reduced mental load\" argument because to me, reading blackend code is much harder than formatting code when I write it. It wastes a lot of vertical space, breaks things up unnecessarily, and breaks a lot of visual cues that make skimming through code efficient.\n\nThe blame pollution and backport conflicts are obvious red flags to me and I think are good enough reasons to *not* do this on their own.","commit_id":"fa8d1af69cbe59b0dd219092e81344f81bed44ea"}],"doc/ext/extra_specs.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"213275a1d7082aaa139e63cd93214190737fd151","unresolved":true,"context_lines":[{"line_number":220,"context_line":"        target,"},{"line_number":221,"context_line":"        node,"},{"line_number":222,"context_line":"        contnode,"},{"line_number":223,"context_line":"    ):"},{"line_number":224,"context_line":"        \"\"\"Resolve cross-references\"\"\""},{"line_number":225,"context_line":"        if typ \u003d\u003d \u0027extra-spec\u0027:"},{"line_number":226,"context_line":"            return sphinx_nodes.make_refnode("}],"source_content_type":"text/x-python","patch_set":1,"id":"acbcbec6_d66a8f20","line":223,"updated":"2023-09-22 14:13:53.000000000","message":"this i find kind of ugly if im being honest.\n\nwhen i did this it was much nicer\nhttps://review.opendev.org/c/openstack/nova/+/844120/1/doc/ext/extra_specs.py#212\n\nso i think i woudl want ot try and fix this first.","commit_id":"4995289889d9b0dbab833d732b84b5fe81e02649"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b679197746d6850c8da0ea02c8864ad1d602db75","unresolved":true,"context_lines":[{"line_number":220,"context_line":"        target,"},{"line_number":221,"context_line":"        node,"},{"line_number":222,"context_line":"        contnode,"},{"line_number":223,"context_line":"    ):"},{"line_number":224,"context_line":"        \"\"\"Resolve cross-references\"\"\""},{"line_number":225,"context_line":"        if typ \u003d\u003d \u0027extra-spec\u0027:"},{"line_number":226,"context_line":"            return sphinx_nodes.make_refnode("}],"source_content_type":"text/x-python","patch_set":1,"id":"b85ff501_0df7e603","line":223,"in_reply_to":"acbcbec6_d66a8f20","updated":"2023-10-02 14:34:12.000000000","message":"This sort of this is exactly why I *hate* black formatting. It wastes an ungodly amount of vertical space and just breaks my decades-old eye-parsing algorithm for things like \"start of a function.\"","commit_id":"4995289889d9b0dbab833d732b84b5fe81e02649"}],"doc/ext/feature_matrix.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"213275a1d7082aaa139e63cd93214190737fd151","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    STATUS_MISSING \u003d \"missing\""},{"line_number":71,"context_line":"    STATUS_UNKNOWN \u003d \"unknown\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    STATUS_ALL \u003d ["},{"line_number":74,"context_line":"        STATUS_COMPLETE,"},{"line_number":75,"context_line":"        STATUS_PARTIAL,"},{"line_number":76,"context_line":"        STATUS_MISSING,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e97fedb2_5f9de694","line":73,"updated":"2023-09-22 14:13:53.000000000","message":"again comparing to https://review.opendev.org/c/openstack/nova/+/844120/1/doc/ext/feature_matrix.py#74 this was not required.","commit_id":"4995289889d9b0dbab833d732b84b5fe81e02649"}]}