)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a5e1ccc7b995de98b94da1adf2e8bdff95eea8d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"The flavor extra specs validation and mks console support"},{"line_number":13,"context_line":"are not removed by this patch, nor is any object cleanup."},{"line_number":14,"context_line":"These can be done as follow up patches if desirable."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0bbd3a917486eeaa87b76120b9be60eae26361f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bc16d1fa_e5275091","line":15,"updated":"2023-11-15 08:38:10.000000000","message":"I don\u0027t see that this change makes the vmware specific APIs return 400 as described in the bp\n```\nWith this driver going, we need to return 400 error code for the below APIs as\nthose are only for vmware driver\n\n1. Get mks Console old deprecated API:\n\n    POST /servers/{server_id}/action (os-getmksConsole Action)\n\n2. mks protocol support from new API for remote console:\n\n    POST /servers/{server_id}/remote-consoles\n```\n\nWill there be another patch on top of this to make that API change?","commit_id":"82390cca4d1194c04a230494d5cbc9a6974d0ee9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8cbeb5e7ae6ede72fcd9f90b0e4a2138536f5a30","unresolved":true,"context_lines":[{"line_number":12,"context_line":"The flavor extra specs validation and mks console support"},{"line_number":13,"context_line":"are not removed by this patch, nor is any object cleanup."},{"line_number":14,"context_line":"These can be done as follow up patches if desirable."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0bbd3a917486eeaa87b76120b9be60eae26361f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"575b93c7_2a169893","line":15,"in_reply_to":"bc16d1fa_e5275091","updated":"2023-11-15 11:59:47.000000000","message":"yes. i prepreared this patch before the ptg, so before we decided to remvoe the other apis. ill do the object and api removals in a a followup.\nill write that before the end of q4 jsut not in time for this review day.","commit_id":"82390cca4d1194c04a230494d5cbc9a6974d0ee9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a5e1ccc7b995de98b94da1adf2e8bdff95eea8d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"are not removed by this patch, nor is any object cleanup."},{"line_number":14,"context_line":"These can be done as follow up patches if desirable."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0bbd3a917486eeaa87b76120b9be60eae26361f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c0a10de8_2336e270","line":16,"updated":"2023-11-15 08:38:10.000000000","message":"I would link to the bp:\n```\nblueprint: remove-vmware-support\n```","commit_id":"82390cca4d1194c04a230494d5cbc9a6974d0ee9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8cbeb5e7ae6ede72fcd9f90b0e4a2138536f5a30","unresolved":true,"context_lines":[{"line_number":13,"context_line":"are not removed by this patch, nor is any object cleanup."},{"line_number":14,"context_line":"These can be done as follow up patches if desirable."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0bbd3a917486eeaa87b76120b9be60eae26361f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"790ee825_eb424ef8","line":16,"in_reply_to":"c0a10de8_2336e270","updated":"2023-11-15 11:59:47.000000000","message":"ack i can add that .","commit_id":"82390cca4d1194c04a230494d5cbc9a6974d0ee9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3737882e332a40eec3f836cd238506c32d330393","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f14a6099_5bc2e1b3","updated":"2023-10-02 14:50:35.000000000","message":"Obviously this should be discussed in a weekly meeting or the PTG before we merge it though","commit_id":"a1ac69f8c876e85b1f85df34a09c8b38eb7da1d5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b095d1bb66d068782bd4b213a3cafa20ebbb845b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"681f0295_bf8a0cea","updated":"2023-10-02 14:50:10.000000000","message":"\\o/","commit_id":"a1ac69f8c876e85b1f85df34a09c8b38eb7da1d5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"05f705188d5fb013dd4990592ef3fbbc902e7250","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0ef89f5_91ec766e","updated":"2023-10-02 20:39:35.000000000","message":"i rebased this directly on master to decouple it form the pyupgrade work\notherwise i just fixed the typo in the todo comment","commit_id":"2063e964bbd0877491753394cfb8d737a90b17c8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0752fee293205060ca3d6b11cd0a4405d1a9ade7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a40e7b01_26107bd5","updated":"2023-10-03 11:15:07.000000000","message":"recheck \u0027Invalid volume: Volume status must be available or error or error_restoring or error_extending or error_managing and must not be migrating, attached, belong to a group, have snapshots, awaiting a transfer, or be disassociated from snapshots after volume transfer.\u0027","commit_id":"2063e964bbd0877491753394cfb8d737a90b17c8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f86e313dd9bb3a79f528e5e260e86439adf57c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7f469f3f_40be3862","updated":"2023-10-03 09:29:21.000000000","message":"recheck unrelated failure","commit_id":"2063e964bbd0877491753394cfb8d737a90b17c8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6738b5d546b0904de07da08bf54404165218dd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"09ad5321_e3159bbb","updated":"2023-12-20 01:02:30.000000000","message":"-1 until we see if the ci can be restored.","commit_id":"82390cca4d1194c04a230494d5cbc9a6974d0ee9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a5e1ccc7b995de98b94da1adf2e8bdff95eea8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0307f33_8aafe054","updated":"2023-11-15 08:38:10.000000000","message":"Looks good to me","commit_id":"82390cca4d1194c04a230494d5cbc9a6974d0ee9"}],"nova/api/validation/extra_specs/quota.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b095d1bb66d068782bd4b213a3cafa20ebbb845b","unresolved":true,"context_lines":[{"line_number":20,"context_line":"EXTRA_SPEC_VALIDATORS \u003d []"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# TODO(sean-k-mooney): with the removal of the vmware driver"},{"line_number":23,"context_line":"# these are now unused, we should condier removing them in a"},{"line_number":24,"context_line":"# future release."},{"line_number":25,"context_line":"# CPU, memory, disk IO and VIF quotas (VMWare)"},{"line_number":26,"context_line":"for key, name, unit in ("}],"source_content_type":"text/x-python","patch_set":1,"id":"0855b7f1_fffe1c86","line":23,"range":{"start_line":23,"start_character":34,"end_line":23,"end_character":41},"updated":"2023-10-02 14:50:10.000000000","message":"nit: consider","commit_id":"a1ac69f8c876e85b1f85df34a09c8b38eb7da1d5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"05f705188d5fb013dd4990592ef3fbbc902e7250","unresolved":false,"context_lines":[{"line_number":20,"context_line":"EXTRA_SPEC_VALIDATORS \u003d []"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# TODO(sean-k-mooney): with the removal of the vmware driver"},{"line_number":23,"context_line":"# these are now unused, we should condier removing them in a"},{"line_number":24,"context_line":"# future release."},{"line_number":25,"context_line":"# CPU, memory, disk IO and VIF quotas (VMWare)"},{"line_number":26,"context_line":"for key, name, unit in ("}],"source_content_type":"text/x-python","patch_set":1,"id":"f7d68183_52437fea","line":23,"range":{"start_line":23,"start_character":34,"end_line":23,"end_character":41},"in_reply_to":"0855b7f1_fffe1c86","updated":"2023-10-02 20:39:35.000000000","message":"Done","commit_id":"a1ac69f8c876e85b1f85df34a09c8b38eb7da1d5"}],"releasenotes/notes/remove-vmware-virt-driver-5c11af392ad2abbf.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a5e1ccc7b995de98b94da1adf2e8bdff95eea8d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the 2023.1 (Antelope) release of nova (27.0.0) the vmwareapi driver was"},{"line_number":5,"context_line":"    declared experimental and deprecated due to a lack of testing,"},{"line_number":6,"context_line":"    maintenance and development. The driver is has not been tested by the"},{"line_number":7,"context_line":"    OpenStack first-party or third-party CI system for several releases."},{"line_number":8,"context_line":"    As of this release the driver has been removed form nova with no"},{"line_number":9,"context_line":"    upstream replacement. While it is possible to develop a third-party virt"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"78cae5b2_d78176a1","line":6,"range":{"start_line":6,"start_character":44,"end_line":6,"end_character":50},"updated":"2023-11-15 08:38:10.000000000","message":"nit: has","commit_id":"82390cca4d1194c04a230494d5cbc9a6974d0ee9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8cbeb5e7ae6ede72fcd9f90b0e4a2138536f5a30","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the 2023.1 (Antelope) release of nova (27.0.0) the vmwareapi driver was"},{"line_number":5,"context_line":"    declared experimental and deprecated due to a lack of testing,"},{"line_number":6,"context_line":"    maintenance and development. The driver is has not been tested by the"},{"line_number":7,"context_line":"    OpenStack first-party or third-party CI system for several releases."},{"line_number":8,"context_line":"    As of this release the driver has been removed form nova with no"},{"line_number":9,"context_line":"    upstream replacement. While it is possible to develop a third-party virt"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0606cf50_1d667f85","line":6,"range":{"start_line":6,"start_character":44,"end_line":6,"end_character":50},"in_reply_to":"78cae5b2_d78176a1","updated":"2023-11-15 11:59:47.000000000","message":"ack ill fix this too thanks for taking a look","commit_id":"82390cca4d1194c04a230494d5cbc9a6974d0ee9"}]}