)]}'
{"id":"openstack%2Fnova~897370","triplet_id":"openstack%2Fnova~master~I949c1b7a67da2f950ab6db3e9e0ceb258cf9b446","project":"openstack/nova","branch":"master","topic":"detect-string-formatting-bugs","hashtags":[],"change_id":"I949c1b7a67da2f950ab6db3e9e0ceb258cf9b446","subject":"testing: Detect log message string formatting bugs","status":"NEW","created":"2023-10-04 23:16:33.000000000","updated":"2023-10-05 00:52:26.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"001918d7773514b777564c27897ac738d2ed2a06","_number":897370,"virtual_id_number":897370,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-10-04 23:49:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-10-04 23:49:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c7fcbc63116e1b40ea082d86a49bdff560acca8b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-10-04 23:16:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1abce27729c6fd50de7db60d634e3197b1623840","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-04 23:49:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/58e6f88ceadf47a190467c17db1fa72e\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/51939502e0df4689988d1cf296fb1435 : SUCCESS in 17m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c8e6f032e30d404085d0699270caae0b : SUCCESS in 11m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/06ba0dc2538841b18f33af5bf0c1dfac : SUCCESS in 12m 48s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/68be6da3dfbb4d7eb2a53186d4f35534 : SUCCESS in 14m 10s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/cd4278a38cb54fd3a0134df3097c14c0 : SUCCESS in 13m 06s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/70ee00143da9437785b2094ac098355d : SUCCESS in 8m 53s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1f71e63b677a4ca08c45f1566fe6455c : SUCCESS in 14m 30s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/734a00c52dbd47ba92be02ffb0427c2b : SUCCESS in 5m 05s (non-voting)\n- nova-tox-py310-with-sqlalchemy-2x https://zuul.opendev.org/t/openstack/build/a1a811b1ad2c4de48951097ba9623ce5 : SUCCESS in 16m 14s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/48a213e2f03842fd9e91de60de773d96 : SUCCESS in 25m 26s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/3f90c60116ca49edae57f3435f58e9d0 : SUCCESS in 17m 49s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/3e11201de40242e9a60b6411609f530e : SUCCESS in 21m 46s","accounts_in_message":[],"_revision_number":1},{"id":"001918d7773514b777564c27897ac738d2ed2a06","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-05 00:52:26.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fa79a1d2112d40fe8090809fe37b3d7a\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/72eab3dfb842406f8f00902c63f4fecd : SUCCESS in 41m 00s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/ce98ebcc1af94d05b54272e3ff82d55f : SUCCESS in 45m 46s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/1c26d24ca8734bd19ec932ede0e362cf : FAILURE in 47m 37s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/947ca5bd455f4725a4bee6e478a5a00d : SUCCESS in 30m 13s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5a7c786e32d3e6902531cb4328b324b0b5bcd18d","revisions":{"5a7c786e32d3e6902531cb4328b324b0b5bcd18d":{"kind":"REWORK","_number":1,"created":"2023-10-04 23:16:33.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/70/897370/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/70/897370/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/897370/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/897370/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/897370/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/70/897370/1"}}},"commit":{"parents":[{"commit":"9246630058d9ebdc7462b6a1e34d779143d4a95f","subject":"Merge \"Add job to test with SQLAlchemy master (2.x)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9246630058d9ebdc7462b6a1e34d779143d4a95f"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-10-04 22:03:03.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-10-04 23:14:10.000000000","tz":0},"subject":"testing: Detect log message string formatting bugs","message":"testing: Detect log message string formatting bugs\n\nOccasionally while doing code reviews, I\u0027ll notice a log message string\nwhich isn\u0027t going to be formatted correctly, for example:\n\n  LOG.info(\u0027My message is %(content)s\u0027, content\u003d\u0027things\u0027)\n\nThe above will result in a log message of \u0027My message is %(content)s\u0027\ninstead of \u0027My message is things\u0027 because the mapping key values need\nto be passed as a dict, for example: dict(content\u003d\u0027things\u0027).\n\nI thought maybe we could catch bugs like this automatically.\nThis adds a check on the captured log output of a test to look for\nmapping keys that were not substituted with values along with an error\nmessage to help explain the problem.\n\nChange-Id: I949c1b7a67da2f950ab6db3e9e0ceb258cf9b446\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5a7c786e32d3e6902531cb4328b324b0b5bcd18d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5a7c786e32d3e6902531cb4328b324b0b5bcd18d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}