)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1e3801fac9ffda656628b5918555c06fd13b0ef2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"39dc40f2_b3f8e0a0","updated":"2023-10-12 12:55:42.000000000","message":"Getting an error, trying to see on my devstack what\u0027s wrong. -1ing until I find the issue\n\nhttps://paste.opendev.org/show/bLirDAMuGmxhLLod0S9p/\n(5.15.0-1037-kvm kernel on 2022.4.1)","commit_id":"990f61cfa455f20ea820c81df4256a5f64246aaf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6e3690afa0567e1b602d2b568715ec8ac7ffe792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a7bc8f2c_5d498691","updated":"2023-10-12 12:21:22.000000000","message":"Sounds good to me but checking on my own devstack env","commit_id":"990f61cfa455f20ea820c81df4256a5f64246aaf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"12bd20616126cf408b633b40993776a953dad51e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d7f4a27d_42539d90","updated":"2023-10-11 20:02:12.000000000","message":"recheck failed other jobs clearly not related","commit_id":"990f61cfa455f20ea820c81df4256a5f64246aaf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2c29e7d68d4a300e1a5a77a224900f14cc3c9bc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ac88e56f_ea2d44b6","updated":"2023-10-11 22:53:19.000000000","message":"recheck timeout in volume test","commit_id":"990f61cfa455f20ea820c81df4256a5f64246aaf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"96bf0703a7f97ac5af11c13d122e0324d8a06b54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"310ffca0_412e67bf","updated":"2023-10-11 20:38:31.000000000","message":"testing with this local.conf\n\nhttps://paste.opendev.org/show/brN3gd5EyLtfINAsIzuQ/\n\ni was able to stack with this plugin enabled and confirm the modules are loaded\nand the mdev types are available.\nhttps://paste.opendev.org/show/bFUPHADJcqMZfPXwmnoL/\n\nthere are some minor things i would like to do as a followup\n\ni.e. adding a sample local.conf and a short readme but\nbased on my local testing this seams to work as intended.\n\nwe shoudl decide how we want to deal with non ubuntu systems but we can document that in the followup.\n\ni have left some nits inline but nothing blocking","commit_id":"990f61cfa455f20ea820c81df4256a5f64246aaf"}],"devstack/lib/mdev_samples":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2566553169e716e0ed8511f21aa58026b33109bb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    elif [[ \"$kvariant\" !\u003d \"generic\" ]]; then"},{"line_number":12,"context_line":"        echo \"NOTE: This may not work on your kernel variant of $kvariant!\""},{"line_number":13,"context_line":"        echo \"Recommend installing the generic variant kernel instead.\""},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    if grep deb-src /etc/apt/sources.list; then"},{"line_number":17,"context_line":"        sudo sed -i \u0027s/^# deb-src/deb-src/\u0027 /etc/apt/sources.list"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"3bc5510f_08f88397","line":14,"updated":"2023-10-12 16:45:01.000000000","message":"++","commit_id":"82f4da91ab7488a6847f8adf1a37de5237ca51f2"}],"devstack/plugin.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"96bf0703a7f97ac5af11c13d122e0324d8a06b54","unresolved":true,"context_lines":[{"line_number":1,"context_line":"LIBDIR\u003d$DEST/nova/devstack/lib"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"source $LIBDIR/mdev_samples"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [[ $1 \u003d\u003d \"stack\" ]]; then"},{"line_number":6,"context_line":"    case $2 in"}],"source_content_type":"text/x-sh","patch_set":12,"id":"c76137f7_21203cae","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":27},"updated":"2023-10-11 20:38:31.000000000","message":"nit: this should be declared in SETTINGS and should be namespaced\n\nNOVA_PLUGIN_DIR\u003d$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" \u0026\u0026 cd .. \u0026\u0026 pwd )\nThen here\n\nsource $NOVA_PLUGIN_DIR/mdev_samples\n\nthis is because the directory under DEST where the plugin is cloned is user setable \n\nits the first argument to enable_plugin\nthe scond and third argumes are the repo to clone and the branch/commit/tag to checkout\n\n\n\nenable_plugin nova https://review.opendev.org/openstack/nova refs/changes/08/897708/12\n\nwill work currently\n\nenable_plugin nova-devstack-plugin https://review.opendev.org/openstack/nova refs/changes/08/897708/12\n\nwill not but it can be nice to support that in some cases i.e to use diffent version fo the plugin form the version of nova your are using.\n\n\nits an edge case so feel free to ignore it for now. i can adress this in a follow up","commit_id":"990f61cfa455f20ea820c81df4256a5f64246aaf"}],"devstack/settings":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"96bf0703a7f97ac5af11c13d122e0324d8a06b54","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Whether or not to compile the mdev sample drivers from source"},{"line_number":2,"context_line":"NOVA_COMPILE_MDEV_SAMPLES\u003d$(trueorfalse True NOVA_COMPILE_MDEV_SAMPLES)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Insert these mdev sample modules"},{"line_number":5,"context_line":"NOVA_MDEV_SAMPLES\u003d${NOVA_MDEV_SAMPLES:-mtty mdpy mdpy-fb mbochs}"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"c840fb65_42177d3e","line":2,"range":{"start_line":2,"start_character":40,"end_line":2,"end_character":44},"updated":"2023-10-11 20:38:31.000000000","message":"some things to consider if you respin\n\nyou could replacing this with is_ubuntu to auto disable on unsupproted distros\nor perhaps make the plugin a noop  or die in when invoked on a non deb/ubuntu host.","commit_id":"990f61cfa455f20ea820c81df4256a5f64246aaf"}]}