)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b3cb3e2bb954d07cf4346697f0ee00c76002a361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e726d002_2acb5ad2","updated":"2023-10-13 07:37:09.000000000","message":"At least I feel we need to communicate on the change thru a release note, but I also feel we need to agree on the exact expected behaviour. \nMy personal preference would go for some compute hardstop if they added CPU0 in their flags, but this may break upgrades.\n\nThat said, if most kernels don\u0027t already provide sysfs support for CPU0, this is already broken, right?","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1c9c3eedaa0a8187220ec6b29acb91d83cd3eeef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"478fe86c_776ff33e","updated":"2023-10-16 09:30:55.000000000","message":"Honestly, with all the meat I\u0027m currently ingesting, if the consensus is saying \"meh, this is just a simple bugfix\", I don\u0027t want to argue.\n\n+2/+W, going to the gate so.","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d69e39abab41e6b0de6f4e139059aaf0b98c43e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be38a79f_fb8b5d85","updated":"2023-10-12 19:24:55.000000000","message":"Per our discussion earlier","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f5112f3513815abed46d5b8f6b330408a89ed7dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"271994a2_75e074e2","updated":"2023-10-17 21:29:57.000000000","message":"recheck gate fix merged","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"00da6c100917c4c6e92404352c13ba863a354ab2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c9430a7_95563ce2","updated":"2023-10-18 16:34:06.000000000","message":"recheck gateway timeout accessing metadata server","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6ee1f97fed019f0b16b0394f086260309cc6050e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3dc0e757_178b13f7","updated":"2023-10-19 13:51:38.000000000","message":"recheck glance-api segv\n\nOct 18 17:22:01.157758 np0035531604 devstack@g-api.service[86003]: !!! uWSGI process 86003 got Segmentation Fault !!!","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"40cf1f31bff417919b2865862022b28118ec6186","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1625ef0d_facddd72","updated":"2023-10-16 13:41:41.000000000","message":"recheck multiple infra failures and a metadata timeout","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"db6291591a72d747c6da60a657b1fea2ed05e8c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7c69428_1e12bdda","updated":"2023-10-19 16:36:21.000000000","message":"recheck unrelated glance image upload failure","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7fe00a9c3cc8b981c933cad57e39cd18c6f63bf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90400614_da07cb81","updated":"2023-10-18 13:55:29.000000000","message":"recheck volume-backed server resize failed with guest kernel crash","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6954778a486b632c40deb897f1b66965ef6bf73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0853ac0d_564a6f56","updated":"2023-10-13 10:12:25.000000000","message":"since we have a bug for this a release note does not hurt but overall im happy with the approch so +1","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0ee5212c583c3d5fafcfa71611ccf602601977f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0f3ac70_74571f8c","updated":"2023-10-13 14:25:28.000000000","message":"upgraded to +2 as im fine with not having a release note for this\nbut i also dont have any objection to adding one","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"88472c7e8bb8516f274a870811f112a6ef681e19","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f554eb1_01f72bd2","in_reply_to":"42ed3bb2_35682075","updated":"2023-10-13 13:34:06.000000000","message":"I don\u0027t think we need a release note for every bug we fix (else we wouldn\u0027t need the bugs themselves). This is a very small fix for an honestly fairly niche problem, and for which we\u0027ve already (according to bauzas) documented they shouldn\u0027t do this anyway. Feels like we\u0027re covered to me, but if that\u0027s what we need to land this fix, then let me know and I\u0027ll do it.","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9918d72aa468d87737b852355834475f9a03d073","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"714f81bb_966f1df6","in_reply_to":"81a98123_8d65e896","updated":"2023-10-13 14:09:47.000000000","message":"Okay, I think this *is* backportable, but shouldn\u0027t require any changes from the op, as it\u0027s currently broken if they have 0 in the dedicated set. I think too verbose of release notes also makes them less likely to be readable.\n\nBut anyway, will add it if that\u0027s the ask (from others).","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dd3540e1c7f87c1e1a4fa121eafa03e213db349","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"81a98123_8d65e896","in_reply_to":"9f554eb1_01f72bd2","updated":"2023-10-13 13:44:19.000000000","message":"ya i tend to only ask for release notes for bug fixes if we are going to backport it and there is somethignthat an opertor needs to do (i.e. set a config option to enable the fix) or there si a security aspect or operatoional aspect to it where we want to prompt them to be aware of the fix and consder upgrading.\n\nso im ok with not having one for this","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4d28d89bb6ba18db77f8d540f2bf6c714aeea0de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42ed3bb2_35682075","in_reply_to":"e726d002_2acb5ad2","updated":"2023-10-13 10:11:20.000000000","message":"so the need to provide a release note contradics your previous staments that we already documented to not do this :) \n\nits a kernel compilation option. you can compile the kernel to allow core 0 to be offloined but its not allowed by default and i dont know of any distro that allows it (fedora,centos, debian and ubuntu all have it set to disabled i.e. not allowed)","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"}],"nova/virt/libvirt/cpu/api.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b3cb3e2bb954d07cf4346697f0ee00c76002a361","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        if (pcpu \u003d\u003d 0 and"},{"line_number":148,"context_line":"                CONF.libvirt.cpu_power_management_strategy \u003d\u003d \u0027cpu_state\u0027):"},{"line_number":149,"context_line":"            LOG.warning(\u0027CPU0 is in cpu_dedicated_set, but it is not eligible \u0027"},{"line_number":150,"context_line":"                        \u0027for state management and will be ignored\u0027)"},{"line_number":151,"context_line":"            continue"},{"line_number":152,"context_line":"        pcpu \u003d Core(pcpu)"},{"line_number":153,"context_line":"        # we need to collect the governors strategy and the CPU states"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2a1a390_0135012f","line":150,"updated":"2023-10-13 07:37:09.000000000","message":"Shall we just ignore and continue ? Surely, this is nice for upgrade reasons, but I\u0027m afraid that operators would miss it.","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"88472c7e8bb8516f274a870811f112a6ef681e19","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        if (pcpu \u003d\u003d 0 and"},{"line_number":148,"context_line":"                CONF.libvirt.cpu_power_management_strategy \u003d\u003d \u0027cpu_state\u0027):"},{"line_number":149,"context_line":"            LOG.warning(\u0027CPU0 is in cpu_dedicated_set, but it is not eligible \u0027"},{"line_number":150,"context_line":"                        \u0027for state management and will be ignored\u0027)"},{"line_number":151,"context_line":"            continue"},{"line_number":152,"context_line":"        pcpu \u003d Core(pcpu)"},{"line_number":153,"context_line":"        # we need to collect the governors strategy and the CPU states"}],"source_content_type":"text/x-python","patch_set":1,"id":"f226960d_6bd6051b","line":150,"in_reply_to":"69800f61_184a863a","updated":"2023-10-13 13:34:06.000000000","message":"Ignore (, warn) and continue makes the most sense here I think because having cpu0 the dedicated set in itself is not a problem. It\u0027s only combining that with the management (and only if strategy\u003dcpu_state) that is the problem. I think because the management decided to re-use the dedicated list (which is fine), it surely makes sense for this to not be a hard stop. It doesn\u0027t affect any functionality (i.e. prevent instances from working or being scheduled here, etc) it just limits some of the power savings you get.\n\nIf it\u0027s not a \"this will not work with this config\" thing, I think a warn-and-continue is the way to go, personally.","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4d28d89bb6ba18db77f8d540f2bf6c714aeea0de","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        if (pcpu \u003d\u003d 0 and"},{"line_number":148,"context_line":"                CONF.libvirt.cpu_power_management_strategy \u003d\u003d \u0027cpu_state\u0027):"},{"line_number":149,"context_line":"            LOG.warning(\u0027CPU0 is in cpu_dedicated_set, but it is not eligible \u0027"},{"line_number":150,"context_line":"                        \u0027for state management and will be ignored\u0027)"},{"line_number":151,"context_line":"            continue"},{"line_number":152,"context_line":"        pcpu \u003d Core(pcpu)"},{"line_number":153,"context_line":"        # we need to collect the governors strategy and the CPU states"}],"source_content_type":"text/x-python","patch_set":1,"id":"69800f61_184a863a","line":150,"in_reply_to":"a2a1a390_0135012f","updated":"2023-10-13 10:11:20.000000000","message":"ignore and continue is what i did in the poc that you ported i belive.\n\nits what i would do","commit_id":"0b9d8cee580739e7a4e2a769e4d4e35110a6bc49"}]}