)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33786,"name":"HanGuangyu","email":"hanguangyu2@gmail.com","username":"hanguangyu"},"change_message_id":"cfd5976da0fb068f980dc1bad1899818e0d1cd58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9a7eeb4_f68c3d89","updated":"2023-10-16 11:33:59.000000000","message":"Hello, I\u0027m a newer of nova.\n\nI am enhancing my understanding of the nova code by tracing the instance creation process. During this, I hope to contribute to the community. \n\nI\u0027m not sure if my commit are accurate, and I appreciate any criticisms and corrections for aspects I might have overlooked.","commit_id":"57fd3eecfd98ee33190f77134d5c4d0369756364"},{"author":{"_account_id":33786,"name":"HanGuangyu","email":"hanguangyu2@gmail.com","username":"hanguangyu"},"change_message_id":"c1669b7c6ee567f997302f20e198944b1b18a529","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4deabbb_9fdc0dbf","updated":"2023-10-16 13:36:44.000000000","message":"recheck","commit_id":"57fd3eecfd98ee33190f77134d5c4d0369756364"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"5bfe7e4256645e652b9bd19dcb06fc2fbb5dfd8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ebf7c36a_5b32c96d","in_reply_to":"f9a7eeb4_f68c3d89","updated":"2023-11-01 10:04:52.000000000","message":"Welcome to the Nova ;)","commit_id":"57fd3eecfd98ee33190f77134d5c4d0369756364"},{"author":{"_account_id":33786,"name":"HanGuangyu","email":"hanguangyu2@gmail.com","username":"hanguangyu"},"change_message_id":"a1a31f6c8bd35ead6efec2a4a04151c74c27285d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7a827ee7_198b0419","updated":"2023-10-18 01:43:02.000000000","message":"recheck","commit_id":"99fee72ceafdcd5d40e90e8d6c52309b75960b22"},{"author":{"_account_id":33786,"name":"HanGuangyu","email":"hanguangyu2@gmail.com","username":"hanguangyu"},"change_message_id":"f8d1cfc3999e39f99d9fac47c90692c9df57794f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b5eca4aa_5e5e516a","updated":"2023-10-18 05:53:59.000000000","message":"recheck","commit_id":"99fee72ceafdcd5d40e90e8d6c52309b75960b22"},{"author":{"_account_id":33786,"name":"HanGuangyu","email":"hanguangyu2@gmail.com","username":"hanguangyu"},"change_message_id":"5bcc38ae971d0d0e8b314473a3a63c9e237bc8c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7508b427_d1657dbb","updated":"2023-10-18 05:50:38.000000000","message":"tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/f163725976c5480292e274ddaf5ab7de : TIMED_OUT in 2h 05m 27s\n\n\nrecheck","commit_id":"99fee72ceafdcd5d40e90e8d6c52309b75960b22"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"5bfe7e4256645e652b9bd19dcb06fc2fbb5dfd8c","unresolved":true,"context_lines":[{"line_number":1127,"context_line":"            msg \u003d _(\"Missing imageRef attribute\")"},{"line_number":1128,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"    def _flavor_id_from_req_data(self, server_dict):"},{"line_number":1131,"context_line":"        flavor_ref \u003d server_dict[\u0027flavorRef\u0027]"},{"line_number":1132,"context_line":"        return common.get_id_from_href(flavor_ref)"},{"line_number":1133,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4c9c6578_6d3ba670","line":1130,"range":{"start_line":1130,"start_character":39,"end_line":1130,"end_character":50},"updated":"2023-11-01 10:04:52.000000000","message":"I think we should still call it data, makes more sense w.r.t method name.","commit_id":"57fd3eecfd98ee33190f77134d5c4d0369756364"},{"author":{"_account_id":33786,"name":"HanGuangyu","email":"hanguangyu2@gmail.com","username":"hanguangyu"},"change_message_id":"451d755844f4f5a80e9c7c0ae37db1c3bd9c67ef","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"            msg \u003d _(\"Missing imageRef attribute\")"},{"line_number":1128,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"    def _flavor_id_from_req_data(self, server_dict):"},{"line_number":1131,"context_line":"        flavor_ref \u003d server_dict[\u0027flavorRef\u0027]"},{"line_number":1132,"context_line":"        return common.get_id_from_href(flavor_ref)"},{"line_number":1133,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"14272d3f_87b7f1a9","line":1130,"range":{"start_line":1130,"start_character":39,"end_line":1130,"end_character":50},"in_reply_to":"4c9c6578_6d3ba670","updated":"2023-11-01 11:25:51.000000000","message":"Nice to get your review;)\na small thought，`_image_from_req_data(self, server_dict, create_kwargs)` has used `server_dict`， and `server_dict` was uesd in \u0027create\u0027 function. \nShould we prioritize consistency by keeping \u0027server_dict\u0027?","commit_id":"57fd3eecfd98ee33190f77134d5c4d0369756364"}]}
