)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"696d5631b995eca69c2d7d6b00d2f3fd83535b9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ecc49fb6_09a55e00","updated":"2023-10-17 14:04:14.000000000","message":"we need to discuss if we shoudl do this or not because we discuss this in the past and choose not to do this","commit_id":"0550659557e937f5d9811a8e3ad216805638ddcc"}],"nova/conf/workarounds.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"696d5631b995eca69c2d7d6b00d2f3fd83535b9f","unresolved":true,"context_lines":[{"line_number":467,"context_line":"        help\u003d\"\"\""},{"line_number":468,"context_line":"Libvirt versions \u003e\u003d 7.2.0 introduced a breaking change where the"},{"line_number":469,"context_line":"value of the cputune.shares domain XML configuration is passed down"},{"line_number":470,"context_line":"to CPUWeight that can cause the value to be out of range."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Enabling this workaround causes libvirt driver to scale the value so"},{"line_number":473,"context_line":"that it never exceeds the allowed value and also upon nova-compute"}],"source_content_type":"text/x-python","patch_set":3,"id":"c0f4fa20_f0f24bd0","line":470,"updated":"2023-10-17 14:04:14.000000000","message":"this is not a libvirt change.\nthis is a change the resultes form usign a host kernel that is compiled with cgroups v2 \n\nlibvirt will accpet large valued on kernel that are compiled with cgpus v1","commit_id":"0550659557e937f5d9811a8e3ad216805638ddcc"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"ff4a442ab9a3e056dd9af0c24c55046d7382093c","unresolved":true,"context_lines":[{"line_number":467,"context_line":"        help\u003d\"\"\""},{"line_number":468,"context_line":"Libvirt versions \u003e\u003d 7.2.0 introduced a breaking change where the"},{"line_number":469,"context_line":"value of the cputune.shares domain XML configuration is passed down"},{"line_number":470,"context_line":"to CPUWeight that can cause the value to be out of range."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Enabling this workaround causes libvirt driver to scale the value so"},{"line_number":473,"context_line":"that it never exceeds the allowed value and also upon nova-compute"}],"source_content_type":"text/x-python","patch_set":3,"id":"5e3c514a_647bd0cc","line":470,"in_reply_to":"c0f4fa20_f0f24bd0","updated":"2023-10-18 07:37:05.000000000","message":"yeah all details in this is wrong, but if I were to change this to only add back the cpu_shares as a workaround is that ok?","commit_id":"0550659557e937f5d9811a8e3ad216805638ddcc"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"696d5631b995eca69c2d7d6b00d2f3fd83535b9f","unresolved":true,"context_lines":[{"line_number":894,"context_line":"        \"\"\"Loop through all libvirt domains and ensure cpu_shares value."},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"        This loops through all libvirt domains and ensures that the cpu_shares"},{"line_number":897,"context_line":"        value is correctly scaled for use as cgroupsv2 CPUWeight value."},{"line_number":898,"context_line":"        \"\"\""},{"line_number":899,"context_line":"        domains \u003d self._host.list_instance_domains()"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8fc59852_4abd16f9","line":897,"updated":"2023-10-17 14:04:14.000000000","message":"so the reason this approch was orginaly rejected is we were concerend this woudl cause cpu starvation until a guest is moved or rebooted on upgrade.\n\ni.e. if this workaround was enabled then new guests woudl have the scaled values on the host and exsting guest woudl have the non scaled values.\n\n\nthe change in the limits for cgroups_v2 also applies to other vaules beyond cpu_shares.\n\nextraspecs in general are not intented to have diffent beahvior based on the host the vm is one. this is one of the reason this is very hard to fix in nova.\n\nthere are some details in \n\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d2037998\n\nit looks like the documentaiton was update to make note that the ranges were cgorup verison dependnent in \n\nhttps://github.com/libvirt/libvirt/commit/ead6e1b00285cbd98e0f0727efb8adcb29ebc1ba\n\nthey also updated the cpu.weight limit check \nhttps://github.com/libvirt/libvirt/commit/cf3414a85b8383d71d6ae2a53daf63c331cc2230\n\nand remove the shares check \nhttps://github.com/libvirt/libvirt/commit/38af6497610075e5fe386734b87186731d4c17ac\n\nthat was part of libvirt 9.1.0","commit_id":"0550659557e937f5d9811a8e3ad216805638ddcc"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d429e96dbe68d681f101e5914c39045860ee514d","unresolved":true,"context_lines":[{"line_number":894,"context_line":"        \"\"\"Loop through all libvirt domains and ensure cpu_shares value."},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"        This loops through all libvirt domains and ensures that the cpu_shares"},{"line_number":897,"context_line":"        value is correctly scaled for use as cgroupsv2 CPUWeight value."},{"line_number":898,"context_line":"        \"\"\""},{"line_number":899,"context_line":"        domains \u003d self._host.list_instance_domains()"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa3a3a9a_54cc0114","line":897,"in_reply_to":"8fc59852_4abd16f9","updated":"2023-10-17 14:36:46.000000000","message":"yeah this is a mess and it\u0027s all on libvirt imo, with this i opted for a fixing it with a simple nova-compute restart for running but would also need to update it in XMLdesc","commit_id":"0550659557e937f5d9811a8e3ad216805638ddcc"}]}