)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33786,"name":"HanGuangyu","email":"hanguangyu2@gmail.com","username":"hanguangyu"},"change_message_id":"e3660d8bd526ab15d6a214f03c62a25742568d87","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db397ee1_319a0b34","updated":"2023-10-18 07:25:04.000000000","message":"recheck\n\nhello，could I ask why we need to move lxml after https://review.opendev.org/c/openstack/nova/+/898435/1 ?\n\nIt is not added directly to bindep.txt, but is added to and then removed from roles.Are there any implied rules？ sorry to bother","commit_id":"55df226b1c1c3f3db67dcc2cf2f0e4037e381995"},{"author":{"_account_id":33786,"name":"HanGuangyu","email":"hanguangyu2@gmail.com","username":"hanguangyu"},"change_message_id":"6e7d975c2116bcebee74587d9d601c9e8425219c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d3a4f72_18412e37","in_reply_to":"c89fcb77_9cbae0b6","updated":"2023-10-19 01:46:04.000000000","message":"Get it! thank you so much for your reply","commit_id":"55df226b1c1c3f3db67dcc2cf2f0e4037e381995"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0e6c5294b527b12e651529cd10d25e9e36ad9ce4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c89fcb77_9cbae0b6","in_reply_to":"db397ee1_319a0b34","updated":"2023-10-18 11:59:48.000000000","message":"we were debating two diffent approchs\n\nwe knew one would very likely work (installing it in the job), the second approch via bindep we were less certin about.\n\nbindep does not work because devstack is not configured to use bindep for service projects, only for libs currently.\n\nthis patch is likely going to be amandoned as the lxml dep in the devstack job is installed in the venv form pypi so we like dont want to add a anisble module dep here as that could cause conflict between versions.","commit_id":"55df226b1c1c3f3db67dcc2cf2f0e4037e381995"}],"bindep.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b4a5ccf33217f6c28483d7b806b38f1a0c20af9","unresolved":true,"context_lines":[{"line_number":56,"context_line":"# installed for any nova installation."},{"line_number":57,"context_line":"lsscsi"},{"line_number":58,"context_line":"# This is required for the ansible virt module\u0027s use of libvirt"},{"line_number":59,"context_line":"python3-lxml"}],"source_content_type":"text/plain","patch_set":1,"id":"5f5a46f2_024e25b5","line":59,"updated":"2023-10-16 17:04:35.000000000","message":"so i have traced though devstack on irc and this will be included  called via \nhttps://github.com/openstack/devstack/blob/ca4d5132e63752878620c4e4f374d98d433b3f52/lib/nova#L971\nthe only real question i have is do we need to deal with diffent names on any distro.\n\ni suspect this would be python3-lxml in most/all distos.\nit is python3-lxml for ubuntu, debian and fedora \n\nhttps://packages.ubuntu.com/focal/python3-lxml\nhttps://packages.debian.org/buster/python3-lxml\nhttps://rpmfind.net/linux/rpm2html/search.php?query\u003dpython3-lxml\n\nlxml is a runtime dep of nova although its also generally used form pypi and managed via constraits.\n\nhttps://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/migration.py#L22\n\nso this may cause version conflict if we install this in all cases \ndepending on if we allow site pagages or not.\nas such we should be carful but let see what ci says","commit_id":"55df226b1c1c3f3db67dcc2cf2f0e4037e381995"}]}
