)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"c328aabb9e30390693af56127bacbf8b2d884136","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d69035f9_e5f1fa90","updated":"2023-11-27 12:39:44.000000000","message":"recheck nova-emulation is removed","commit_id":"6fe9dabfc7485637b1dfd55ffba658fcfe6509c9"}],"nova/network/neutron.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80f1df909116da1b6e71032d6163102b971fd9e0","unresolved":true,"context_lines":[{"line_number":1583,"context_line":"        pf_mac \u003d pci_dev.sriov_cap.get(\u0027pf_mac_address\u0027)"},{"line_number":1584,"context_line":"        vf_num \u003d pci_dev.sriov_cap.get(\u0027vf_num\u0027)"},{"line_number":1585,"context_line":"        card_serial_number \u003d pci_dev.card_serial_number"},{"line_number":1586,"context_line":"        if all((pf_mac, vf_num, card_serial_number)):"},{"line_number":1587,"context_line":"            vf_profile.update({"},{"line_number":1588,"context_line":"                \u0027card_serial_number\u0027: card_serial_number,"},{"line_number":1589,"context_line":"                \u0027pf_mac_address\u0027: pf_mac,"}],"source_content_type":"text/x-python","patch_set":3,"id":"993ff0b1_c93e519d","line":1586,"updated":"2024-01-08 13:34:39.000000000","message":"this is not the same logic as \nhttps://review.opendev.org/c/openstack/nova/+/834006/1/nova/network/neutron.py#3679\nand it is not correct.\n\nplease revert this to the same if chain\n\nwe do not require all 3 to be present to update the profile.\n\nin general the card_serial_number will not be present on sriov VFs/PFs\n\nthat is only supported on very new cards.\n\nthat is why this is wrttien as\n\n  binding_profile.update({\u0027pci_slot\u0027: pci_dev.address})\n        if binding_profile.get(\u0027card_serial_number\u0027):\n            binding_profile.update({\n                \u0027card_serial_number\u0027: pci_dev.card_serial_number})\n        if binding_profile.get(\u0027pf_mac_address\u0027):\n            binding_profile.update({\n                \u0027pf_mac_address\u0027: pci_dev.sriov_cap[\u0027pf_mac_address\u0027]})\n        if binding_profile.get(\u0027vf_num\u0027):\n            binding_profile.update({\n                \u0027vf_num\u0027: pci_dev.sriov_cap[\u0027vf_num\u0027]})","commit_id":"7980d46833d4293c658fb7f81ace7816761949f3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8c49cde53f6fe251380dc5399feaf78dcb5f580a","unresolved":true,"context_lines":[{"line_number":1583,"context_line":"        pf_mac \u003d pci_dev.sriov_cap.get(\u0027pf_mac_address\u0027)"},{"line_number":1584,"context_line":"        vf_num \u003d pci_dev.sriov_cap.get(\u0027vf_num\u0027)"},{"line_number":1585,"context_line":"        card_serial_number \u003d pci_dev.card_serial_number"},{"line_number":1586,"context_line":"        if all((pf_mac, vf_num, card_serial_number)):"},{"line_number":1587,"context_line":"            vf_profile.update({"},{"line_number":1588,"context_line":"                \u0027card_serial_number\u0027: card_serial_number,"},{"line_number":1589,"context_line":"                \u0027pf_mac_address\u0027: pf_mac,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a9452126_bc062c50","line":1586,"in_reply_to":"6ab2d835_29bcf869","updated":"2024-01-16 08:04:57.000000000","message":"careated patches here https://review.opendev.org/q/topic:%22refactor-vf-profile-update%22\npleaser have a look","commit_id":"7980d46833d4293c658fb7f81ace7816761949f3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c8d8822db28910076103214ae1a40fd6f5de71e7","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"        pf_mac \u003d pci_dev.sriov_cap.get(\u0027pf_mac_address\u0027)"},{"line_number":1584,"context_line":"        vf_num \u003d pci_dev.sriov_cap.get(\u0027vf_num\u0027)"},{"line_number":1585,"context_line":"        card_serial_number \u003d pci_dev.card_serial_number"},{"line_number":1586,"context_line":"        if all((pf_mac, vf_num, card_serial_number)):"},{"line_number":1587,"context_line":"            vf_profile.update({"},{"line_number":1588,"context_line":"                \u0027card_serial_number\u0027: card_serial_number,"},{"line_number":1589,"context_line":"                \u0027pf_mac_address\u0027: pf_mac,"}],"source_content_type":"text/x-python","patch_set":3,"id":"6ab2d835_29bcf869","line":1586,"in_reply_to":"6c135cec_c778dddf","updated":"2024-01-09 13:24:18.000000000","message":"actully looking at this again this is also in the master version of the patch and in master today.\n\nthis is a latent bug which we shoudl fix on master and backport as a s second patchc on top.","commit_id":"7980d46833d4293c658fb7f81ace7816761949f3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"4c93558add78d200e1494c47244f72588a14df1e","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"        pf_mac \u003d pci_dev.sriov_cap.get(\u0027pf_mac_address\u0027)"},{"line_number":1584,"context_line":"        vf_num \u003d pci_dev.sriov_cap.get(\u0027vf_num\u0027)"},{"line_number":1585,"context_line":"        card_serial_number \u003d pci_dev.card_serial_number"},{"line_number":1586,"context_line":"        if all((pf_mac, vf_num, card_serial_number)):"},{"line_number":1587,"context_line":"            vf_profile.update({"},{"line_number":1588,"context_line":"                \u0027card_serial_number\u0027: card_serial_number,"},{"line_number":1589,"context_line":"                \u0027pf_mac_address\u0027: pf_mac,"}],"source_content_type":"text/x-python","patch_set":3,"id":"6c135cec_c778dddf","line":1586,"in_reply_to":"993ff0b1_c93e519d","updated":"2024-01-09 12:20:39.000000000","message":"Acknowledged","commit_id":"7980d46833d4293c658fb7f81ace7816761949f3"}]}