)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5d62fcbb5845892dcf9cdfbda572f072f1c89228","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Request_specs is not updated during rebuild if we raise an exception"},{"line_number":10,"context_line":"during the scheduling of the instance. we can found update of image_ref"},{"line_number":11,"context_line":"but request_specs missing so we added to not block the next action on"},{"line_number":12,"context_line":"the instance."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2040986"},{"line_number":15,"context_line":"Change-Id: I10a40f89b184826ce3813ee8d645b67868932fdc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"09241d63_25e1be2a","line":12,"updated":"2024-08-06 13:04:11.000000000","message":"ill need to review this more closely but i belive that is intentional\n\nif rebuild fails to pass chdulign we do nto want the request spec to be updated\nas that indicates that the image that was selected was invliad for the current host and rebuild is not a move operation.\n\nas such updating the reqeust sepc woudl currpt the db as the request spec woudl now contian requiremetns that are invlaid for the current host","commit_id":"d722c6e471b6a6a701e420744ad79eb676df295f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"5949954c493cdc1b4a5689302eba1869b037f795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b610f3fd_6be96dff","updated":"2023-10-26 16:04:11.000000000","message":"recheck","commit_id":"bbc6eef7c87a34e5294f1d20b91b4d345e722b28"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"8abb82af68fcd5d2dcd33649d2c879c9ba7ef058","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7acfb6ab_479ce0a0","updated":"2023-10-26 12:36:14.000000000","message":"recheck tempest-integrated-compute-rbac-old-defaults","commit_id":"bbc6eef7c87a34e5294f1d20b91b4d345e722b28"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5d62fcbb5845892dcf9cdfbda572f072f1c89228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a65131ed_1fe10f92","updated":"2024-08-06 13:04:11.000000000","message":"This is missing a repodcuer functional test in a preceeding review and the corrent fix is fixign the symthom not the underlying cause.\n\nno changes to the request spec should be persited to the db until after schduling has validated that the current host is approrate.\n\nin the evecaute case the request spec should not be updated at all in the db.","commit_id":"d722c6e471b6a6a701e420744ad79eb676df295f"}],"nova/conductor/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5d62fcbb5845892dcf9cdfbda572f072f1c89228","unresolved":true,"context_lines":[{"line_number":1354,"context_line":"                        image_meta \u003d objects.ImageMeta.from_image_ref("},{"line_number":1355,"context_line":"                            context, self.image_api, orig_image_ref)"},{"line_number":1356,"context_line":"                        request_spec.image \u003d image_meta"},{"line_number":1357,"context_line":"                        request_spec.save()"},{"line_number":1358,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":1359,"context_line":"                        # NOTE(efried): It would be nice if this were two"},{"line_number":1360,"context_line":"                        # separate events, one for \u0027rebuild\u0027 and one for"}],"source_content_type":"text/x-python","patch_set":2,"id":"d190862c_0836a085","line":1357,"updated":"2024-08-06 13:04:11.000000000","message":"ok so this is not what the commit message descirbes.\n\ni agree that roling back the metadata is correct but we really shoudl not have updated the image_meta in the request spec at this point.\n\nwe should only do that and save it after we pass the schduler verifcation.\n\nso i think this is treating the symthom and not the underlying bug.\n\nnot taht we cant just lookup the current image metadata form glance, that may have changed since the instance was booted.\nwe ether need to retrive the image metadat form the instance or we need to have kept it in memory so this is not the correct way to resolve this issue.","commit_id":"d722c6e471b6a6a701e420744ad79eb676df295f"}]}