)]}'
{"nova/compute/api.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2723c762dea233451cb8ca7247fc7ce581fb1516","unresolved":false,"context_lines":[{"line_number":809,"context_line":"        # Reserve quotas"},{"line_number":810,"context_line":"        num_instances, quota_reservations \u003d self._check_num_instances_quota("},{"line_number":811,"context_line":"                context, instance_type, min_count, max_count)"},{"line_number":812,"context_line":"        LOG.debug(\"Going to run %s instances...\" % num_instances)"},{"line_number":813,"context_line":"        instances \u003d []"},{"line_number":814,"context_line":"        try:"},{"line_number":815,"context_line":"            for i in xrange(num_instances):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2Ft6U%3D","line":812,"updated":"2014-04-28 13:50:12.000000000","message":"Mind correcting the above to use a comma instead of a %. Also, it should be a %d not a %s :)","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"004ebacd52491d1395879fbf64b3b3a7965fdaf6","unresolved":false,"context_lines":[{"line_number":809,"context_line":"        # Reserve quotas"},{"line_number":810,"context_line":"        num_instances, quota_reservations \u003d self._check_num_instances_quota("},{"line_number":811,"context_line":"                context, instance_type, min_count, max_count)"},{"line_number":812,"context_line":"        LOG.debug(\"Going to run %s instances...\" % num_instances)"},{"line_number":813,"context_line":"        instances \u003d []"},{"line_number":814,"context_line":"        try:"},{"line_number":815,"context_line":"            for i in xrange(num_instances):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bad4c104_204d6a73","line":812,"in_reply_to":"AAAAXX%2F%2Ft6U%3D","updated":"2014-04-29 00:19:27.000000000","message":"Jay, I do mind that is out of scope of this change.","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            raise exception.PortLimitExceeded()"},{"line_number":975,"context_line":"        elif max_net_count \u003c max_count:"},{"line_number":976,"context_line":"            LOG.debug(\"max count reduced from %(max_count)d to \""},{"line_number":977,"context_line":"                        \"%(max_net_count)d due to network port quota\","},{"line_number":978,"context_line":"                       {\u0027max_count\u0027: max_count,"},{"line_number":979,"context_line":"                        \u0027max_net_count\u0027: max_net_count})"},{"line_number":980,"context_line":"            max_count \u003d max_net_count"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2FtkE%3D","line":977,"updated":"2014-04-28 14:37:21.000000000","message":"You probably have to fix the width space also.","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"004ebacd52491d1395879fbf64b3b3a7965fdaf6","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            raise exception.PortLimitExceeded()"},{"line_number":975,"context_line":"        elif max_net_count \u003c max_count:"},{"line_number":976,"context_line":"            LOG.debug(\"max count reduced from %(max_count)d to \""},{"line_number":977,"context_line":"                        \"%(max_net_count)d due to network port quota\","},{"line_number":978,"context_line":"                       {\u0027max_count\u0027: max_count,"},{"line_number":979,"context_line":"                        \u0027max_net_count\u0027: max_net_count})"},{"line_number":980,"context_line":"            max_count \u003d max_net_count"}],"source_content_type":"text/x-python","patch_set":2,"id":"bad4c104_a0409a36","line":977,"in_reply_to":"AAAAXX%2F%2FtkE%3D","updated":"2014-04-29 00:19:27.000000000","message":"Since this is a style issue (pep8 E12*) and we don\u0027t gate on it, I don\u0027t think its worth fixing.","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2723c762dea233451cb8ca7247fc7ce581fb1516","unresolved":false,"context_lines":[{"line_number":1836,"context_line":"        if search_opts is None:"},{"line_number":1837,"context_line":"            search_opts \u003d {}"},{"line_number":1838,"context_line":""},{"line_number":1839,"context_line":"        LOG.debug(\"Searching by: %s\" % str(search_opts))"},{"line_number":1840,"context_line":""},{"line_number":1841,"context_line":"        # Fixups for the DB call"},{"line_number":1842,"context_line":"        filters \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2Ft6Q%3D","line":1839,"updated":"2014-04-28 13:50:12.000000000","message":"comma instead of %","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"}],"nova/compute/claims.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2723c762dea233451cb8ca7247fc7ce581fb1516","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        \"\"\"Compute operation requiring claimed resources has failed or"},{"line_number":253,"context_line":"        been aborted."},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        LOG.debug(\"Aborting claim: %s\" % self, instance\u003dself.instance)"},{"line_number":256,"context_line":"        self.tracker.drop_resize_claim(self.instance, self.instance_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2Ft6A%3D","line":255,"updated":"2014-04-28 13:50:12.000000000","message":"comma instead of %, here and above","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"}],"nova/compute/manager.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                    migration.save(context.elevated())"},{"line_number":247,"context_line":"                except Exception:"},{"line_number":248,"context_line":"                    LOG.debug(\u0027Error setting migration status \u0027"},{"line_number":249,"context_line":"                                \u0027for instance %s.\u0027 %"},{"line_number":250,"context_line":"                              migration.instance_uuid, exc_info\u003dTrue)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    return decorated_function"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2Ftjc%3D","line":249,"updated":"2014-04-28 14:37:21.000000000","message":"You probably have to fix the width space here.","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                                  vm_state\u003dvm_states.ERROR)"},{"line_number":634,"context_line":"        except exception.InstanceNotFound:"},{"line_number":635,"context_line":"            LOG.debug(\u0027Instance has been destroyed from under us while \u0027"},{"line_number":636,"context_line":"                        \u0027trying to set it to ERROR\u0027,"},{"line_number":637,"context_line":"                      instance_uuid\u003dinstance_uuid)"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    def _set_instance_obj_error_state(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2FtjM%3D","line":636,"updated":"2014-04-28 14:37:21.000000000","message":"ditto","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            instance.save()"},{"line_number":643,"context_line":"        except exception.InstanceNotFound:"},{"line_number":644,"context_line":"            LOG.debug(\u0027Instance has been destroyed from under us while \u0027"},{"line_number":645,"context_line":"                        \u0027trying to set it to ERROR\u0027, instance\u003dinstance)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    def _get_instances_on_driver(self, context, filters\u003dNone):"},{"line_number":648,"context_line":"        \"\"\"Return a list of instance records for the instances found"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2FtjI%3D","line":645,"updated":"2014-04-28 14:37:21.000000000","message":"ditto","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":817,"context_line":"            # may be set by the api but the host is not so if we get here the"},{"line_number":818,"context_line":"            # instance has already been scheduled to this particular host."},{"line_number":819,"context_line":"            LOG.debug(\"Instance failed to spawn correctly, \""},{"line_number":820,"context_line":"                        \"setting to ERROR state\", instance\u003dinstance)"},{"line_number":821,"context_line":"            instance.task_state \u003d None"},{"line_number":822,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":823,"context_line":"            instance.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2FtjE%3D","line":820,"updated":"2014-04-28 14:37:21.000000000","message":"ditto","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":829,"context_line":"                                    task_states.IMAGE_UPLOADING,"},{"line_number":830,"context_line":"                                    task_states.IMAGE_SNAPSHOT]):"},{"line_number":831,"context_line":"            LOG.debug(\"Instance in transitional state %s at start-up \""},{"line_number":832,"context_line":"                        \"clearing task state\","},{"line_number":833,"context_line":"                        instance[\u0027task_state\u0027], instance\u003dinstance)"},{"line_number":834,"context_line":"            instance.task_state \u003d None"},{"line_number":835,"context_line":"            instance.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2FtjA%3D","line":832,"updated":"2014-04-28 14:37:21.000000000","message":"ditto and I see more on this file.","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":3067,"context_line":"        def do_confirm_resize(context, instance, migration_id):"},{"line_number":3068,"context_line":"            # NOTE(wangpan): Get the migration status from db, if it has been"},{"line_number":3069,"context_line":"            #                confirmed, we do nothing and return here"},{"line_number":3070,"context_line":"            LOG.debug(\"Going to confirm migration %s\" % migration_id,"},{"line_number":3071,"context_line":"                        context\u003dcontext, instance\u003dinstance)"},{"line_number":3072,"context_line":"            try:"},{"line_number":3073,"context_line":"                # TODO(russellb) Why are we sending the migration object just"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2Fth8%3D","line":3070,"updated":"2014-04-28 14:37:21.000000000","message":"as Jay Pipes said, you can use comma here.","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        # get memory overhead required to build this instance:"},{"line_number":116,"context_line":"        overhead \u003d self.driver.estimate_instance_overhead(instance_ref)"},{"line_number":117,"context_line":"        LOG.debug(\"Memory overhead for %(flavor)d MB instance; %(overhead)d \""},{"line_number":118,"context_line":"                    \"MB\", {\u0027flavor\u0027: instance_ref[\u0027memory_mb\u0027],"},{"line_number":119,"context_line":"                            \u0027overhead\u0027: overhead[\u0027memory_mb\u0027]})"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        claim \u003d claims.Claim(instance_ref, self, self.compute_node,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2FthY%3D","line":118,"updated":"2014-04-28 14:37:21.000000000","message":"Can you align the code as before?","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"fb817ab534626457d745e02073c1e6f49952d852","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        # get memory overhead required to build this instance:"},{"line_number":116,"context_line":"        overhead \u003d self.driver.estimate_instance_overhead(instance_ref)"},{"line_number":117,"context_line":"        LOG.debug(\"Memory overhead for %(flavor)d MB instance; %(overhead)d \""},{"line_number":118,"context_line":"                    \"MB\", {\u0027flavor\u0027: instance_ref[\u0027memory_mb\u0027],"},{"line_number":119,"context_line":"                            \u0027overhead\u0027: overhead[\u0027memory_mb\u0027]})"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        claim \u003d claims.Claim(instance_ref, self, self.compute_node,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bad4c104_ed7280e4","line":118,"in_reply_to":"AAAAXX%2F%2FthY%3D","updated":"2014-04-29 20:29:44.000000000","message":"This one, and the MB below I think really need to rewrap. We deleted enough characters that the string should fit on one line, and the current wrapping is just completely confusing.","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        # get memory overhead required to build this instance:"},{"line_number":156,"context_line":"        overhead \u003d self.driver.estimate_instance_overhead(instance_type)"},{"line_number":157,"context_line":"        LOG.debug(\"Memory overhead for %(flavor)d MB instance; %(overhead)d \""},{"line_number":158,"context_line":"                    \"MB\", {\u0027flavor\u0027: instance_type[\u0027memory_mb\u0027],"},{"line_number":159,"context_line":"                            \u0027overhead\u0027: overhead[\u0027memory_mb\u0027]})"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        instance_ref \u003d obj_base.obj_to_primitive(instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2FthU%3D","line":158,"updated":"2014-04-28 14:37:21.000000000","message":"ditto","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        free_ram_mb \u003d resources[\u0027memory_mb\u0027] - resources[\u0027memory_mb_used\u0027]"},{"line_number":407,"context_line":"        free_disk_gb \u003d resources[\u0027local_gb\u0027] - resources[\u0027local_gb_used\u0027]"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        LOG.debug(\"Hypervisor: free ram (MB): %s\" % free_ram_mb)"},{"line_number":410,"context_line":"        LOG.debug(\"Hypervisor: free disk (GB): %s\" % free_disk_gb)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2FthM%3D","line":409,"updated":"2014-04-28 14:37:21.000000000","message":"Can you use comma here?","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        free_disk_gb \u003d resources[\u0027local_gb\u0027] - resources[\u0027local_gb_used\u0027]"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        LOG.debug(\"Hypervisor: free ram (MB): %s\" % free_ram_mb)"},{"line_number":410,"context_line":"        LOG.debug(\"Hypervisor: free disk (GB): %s\" % free_disk_gb)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"},{"line_number":413,"context_line":"        if vcpus:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2FthE%3D","line":410,"updated":"2014-04-28 14:37:21.000000000","message":"ditto and for the other in the file please.","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"}],"nova/compute/utils.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"727811fe2439442047c703358e1df10e27901dd1","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        aggregate_identifier \u003d aggregate_payload.get(\u0027name\u0027, None)"},{"line_number":356,"context_line":"        if not aggregate_identifier:"},{"line_number":357,"context_line":"            LOG.debug(\"No aggregate id or name specified for this \""},{"line_number":358,"context_line":"                        \"notification and it will be ignored\")"},{"line_number":359,"context_line":"            return"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    notifier \u003d rpc.get_notifier(service\u003d\u0027aggregate\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2Ftg0%3D","line":358,"updated":"2014-04-28 14:37:21.000000000","message":"can you align the code?","commit_id":"79ab73e9e0f249c4c1439e0585203b1710c5f362"}],"nova/hacking/checks.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"58ea0dccf0e70280e74543966e1aeb8b37d4740c","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    N319"},{"line_number":208,"context_line":"    \"\"\""},{"line_number":209,"context_line":"    dirs \u003d [\"nova/scheduler\", \"nova/compute\"]"},{"line_number":210,"context_line":"    if max([name in filename for name in dirs]):"},{"line_number":211,"context_line":"        if logical_line.startswith(\"LOG.debug(_(\"):"},{"line_number":212,"context_line":"            yield(0, \"N319 Don\u0027t translate debug level logs\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FEfw%3D","line":209,"updated":"2014-04-24 08:46:47.000000000","message":"Can you please write this as\n[\"nova/scheduler\",\n \"nova/compute\",\n]\n\nThis will ensure that we do not have conflicts when other patches are also merged.\n\nFor example - https://review.openstack.org/90027","commit_id":"2c4200975bcc363a32b775a16069937d8f86400e"}]}