)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7243803ac8add49a80fc9e28b27ce829cbf36d28","unresolved":true,"context_lines":[{"line_number":14,"context_line":"for host CPU features), just stop enabling it at all."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2ff4fdecd9dc69de283f0e52e07df1aeaf0a9048"},{"line_number":17,"context_line":"Partial-bug: 2009280"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"779003f2_f081b58c","line":17,"updated":"2023-12-13 14:17:55.000000000","message":"i think this can be Closes-Bug\n\naddign evmcs support would likely be a specless blueprint as it will likely need a flavor extra spec/image poropety and schduler support.","commit_id":"a137b2013fba8ddff485ed973e36f838f909dede"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"33481bc3bfc69e12b29bac30efda6a32b85f123b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"for host CPU features), just stop enabling it at all."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2ff4fdecd9dc69de283f0e52e07df1aeaf0a9048"},{"line_number":17,"context_line":"Partial-bug: 2009280"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"71770b1b_24031861","line":17,"in_reply_to":"779003f2_f081b58c","updated":"2024-01-08 17:29:51.000000000","message":"Done","commit_id":"a137b2013fba8ddff485ed973e36f838f909dede"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b34b5729f9e4b736949d45417ad96d76679a5cb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea3f8090_622367b7","updated":"2023-11-15 19:19:28.000000000","message":"recheck nova-lvm shelve timeout\n\nProposed https://review.opendev.org/c/openstack/tempest/+/901087 to help debugging in the future","commit_id":"d6835f09146040e5b3f18388fa89e3d5ea27dbef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"59cc3ecef34c63e6dea48becd142fd403453e03e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47ec1455_96ec0b34","updated":"2023-11-16 12:56:17.000000000","message":"this is missing the change to get_updated_guest_xml to check if the source xml is currently using vmcs and include it if it is.\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L56-L73","commit_id":"d6835f09146040e5b3f18388fa89e3d5ea27dbef"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"46db44fd99454824727cf7dc07881aae431c077c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4bdc286d_be308e6b","in_reply_to":"47ec1455_96ec0b34","updated":"2023-11-16 14:47:36.000000000","message":"I\u0027m confused, I thought get_updated_guest_xml() doesn\u0027t change anything unless explicitly coded for, and we didn\u0027t code anything for enlightenments, so won\u0027t those remain unchanged in the XML?","commit_id":"d6835f09146040e5b3f18388fa89e3d5ea27dbef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3726d325df7e264cc839b6da155f189f55502de9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4fbda1e_7bc21480","in_reply_to":"4bdc286d_be308e6b","updated":"2023-12-13 14:15:32.000000000","message":"artom was correct we should not be regenrating this section in live migation\n\n_update_numa_xml updates the pinnign but not the feature section\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L56-L73\n\nso the content wont change as such there is nothign else that is requried in get_updated_guest_xml","commit_id":"d6835f09146040e5b3f18388fa89e3d5ea27dbef"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e4424ffcec7d90d16e8704e6512247eaa115d0cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"faf16b03_dc4b2c05","in_reply_to":"ea3f8090_622367b7","updated":"2024-02-17 21:00:34.000000000","message":"this fix will break live-migration and upgrade according to","commit_id":"d6835f09146040e5b3f18388fa89e3d5ea27dbef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3726d325df7e264cc839b6da155f189f55502de9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"52cd8dde_dc1f8b2c","updated":"2023-12-13 14:15:32.000000000","message":"recheck nova-ceph-multistore timeout\n\nif you respin it would be good to add a relese not with a fixes section","commit_id":"a137b2013fba8ddff485ed973e36f838f909dede"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b185be21741d3bce71eda5e52fe7f8a597365624","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"253c20f6_2d94dae6","updated":"2023-12-13 16:39:49.000000000","message":"Looking into the shelve failure in the nova-lvm job, looks like the glance upload failed with g-api getting oom-killed:\n\nDec 13 15:15:06.403078 np0036030293 devstack@g-api.service[85866]: DEBUG glance_store.backend [None req-45eaed94-f09b-489f-92a7-7e9ad36a36d3 tempest-DeleteServersTestJSON-1773255267 tempest-DeleteServersTestJSON-1773255267-project-member]\n Skipping store.set_acls... not implemented. {{(pid\u003d85866) set_acls /opt/stack/data/venv/lib/python3.10/site-packages/glance_store/backend.py:508}}\n\u003csnip\u003e\nDec 13 15:15:07.403104 np0036030293 systemd[1]: devstack@g-api.service: Failed with result \u0027oom-kill\u0027.\nDec 13 15:15:07.411408 np0036030293 systemd[1]: devstack@g-api.service: Consumed 3min 59.240s CPU time.\nDec 13 15:15:07.578264 np0036030293 systemd[1]: devstack@g-api.service: Scheduled restart job, restart counter is at 1.\nDec 13 15:15:07.578576 np0036030293 systemd[1]: Stopped Devstack devstack@g-api.service.\nDec 13 15:15:07.578645 np0036030293 systemd[1]: devstack@g-api.service: Consumed 3min 59.240s CPU time.\nDec 13 15:15:07.616044 np0036030293 systemd[1]: Starting Devstack devstack@g-api.service...\n\nI wonder if the following line has anything to do with it:\n\nDec 13 15:14:34.390768 np0036030293 devstack@g-api.service[85866]: DEBUG glance_store._drivers.swift.store [None req-45eaed94-f09b-489f-92a7-7e9ad36a36d3 tempest-DeleteServersTestJSON-1773255267 tempest-DeleteServersTestJSON-1773255267-project-member] Cannot determine image size because it is either not provided in the request or chunked-transfer encoding is used. Adding image as a segmented object to Swift. {{(pid\u003d85866) add /opt/stack/data/venv/lib/python3.10/site-packages/glance_store/_drivers/swift/store.py:965}}","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e4424ffcec7d90d16e8704e6512247eaa115d0cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6941ce33_7671053f","updated":"2024-02-17 21:00:34.000000000","message":"This patch breaks a category of people who rely on this functionality and it suddenly stopped working, and we do not give ability to even enabling it back without code modification. Maybe we should consider using this approach https://review.opendev.org/c/openstack/nova/+/900629 when evmcs is disable by default (yes it still will break) but on other hand patch gives ability to enable it back at least.","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"54bba72ae2d1920095b1be53a4697147596d8899","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"38fd98c3_4444bca9","updated":"2024-02-14 19:06:00.000000000","message":"recheck","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"23f10934312294d824d80853d62a597afe5b0efa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fe5e6e1_9b2438f2","updated":"2023-12-16 15:19:17.000000000","message":"recheck","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"6aa88cc461a5ef65eab379672cb3d49c17795223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46618015_b48ac15e","updated":"2024-02-09 15:17:41.000000000","message":"recheck","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":36642,"name":"songjie","display_name":"Jie Song","email":"songjie_yewu@cmss.chinamobile.com","username":"songjie"},"change_message_id":"45b4b687bca22d1e407a350dbf050dafb4e96c37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74e9547b_330d4304","updated":"2024-02-15 06:14:41.000000000","message":"recheck","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9fb8f62b50a7bc3dae346cea085f4c34f6159cda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bf75a6bf_6c272a1a","updated":"2023-12-28 16:25:34.000000000","message":"recheck","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3f8d8969dd57e9cc8f04cd2a121f5b1ad3b1ed50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aab75730_b76bf5ad","updated":"2024-01-19 18:38:01.000000000","message":"recheck (╯°□°）╯︵ ┻━┻","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"a72fa077a620fa21cfc7c1321866e692db9e43ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e31ff1a3_ec80db3b","updated":"2024-02-01 19:06:14.000000000","message":"recheck (╯°□°）╯︵ ┻━┻","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"2995de20e3ec70979bb94eff86407cdba138f887","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f77a73f_ad48cc33","updated":"2023-12-19 17:03:12.000000000","message":"recheck glance error","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9b8764e355cc8c68ea35a6aa7e7b988c05ecc3d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"762225f5_1aec934d","updated":"2023-12-18 19:23:04.000000000","message":"recheck installing packages timeout","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"dcc3c6a01d14bbad51f9c940955b646f41565e1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d9e83dfb_a1df601a","updated":"2023-12-21 16:37:27.000000000","message":"recheck kernel panic","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9f86d1b474bb2097fbe575e7204cef9b702aecd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51569a56_8e3396ee","updated":"2024-01-08 16:12:02.000000000","message":"recheck timed out","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"}],"releasenotes/notes/libvirt-enlightenments-stop-unconditionally-enabling-evmcs-993a825641c4b9f3.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4b77a069f6403f6cbf4e898e81d11767988eb2a8","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    the libvirt driver. evmcs only works on Intel CPUs, and domains with that"},{"line_number":6,"context_line":"    enlightenment cannot be started on AMD hosts. There is a possible future"},{"line_number":7,"context_line":"    feature to enable support for generating this enlightenment only when"},{"line_number":8,"context_line":"    running on Intel hosts."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8b8c756e_a6f0a7a0","line":8,"updated":"2023-12-13 14:30:47.000000000","message":"note for others evmcs  would be a feature not a bug because if we support this we will need an image property/extra spec to request it and schduler support.\nwe would also need a new triat to advertise evmcs supprot as a supproted compute capablity trait or hardware triat only on intel hosts.\n\nall of that would make supporting this a future feature not a bug fix.","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"33481bc3bfc69e12b29bac30efda6a32b85f123b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    the libvirt driver. evmcs only works on Intel CPUs, and domains with that"},{"line_number":6,"context_line":"    enlightenment cannot be started on AMD hosts. There is a possible future"},{"line_number":7,"context_line":"    feature to enable support for generating this enlightenment only when"},{"line_number":8,"context_line":"    running on Intel hosts."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6fdd9cae_57f47f19","line":8,"in_reply_to":"8b8c756e_a6f0a7a0","updated":"2024-01-08 17:29:51.000000000","message":"Acknowledged","commit_id":"86a35e97d286cbb6e23f8cc7bec5a05f022da0cb"}]}