)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3737ba321c306bf31a1c26bd37b83f0e35151fb0","unresolved":true,"context_lines":[{"line_number":15,"context_line":"these environments it is beneficial if nova allows connection between"},{"line_number":16,"context_line":"compute hosts based on the hostname (or FQDN) of the host instead of"},{"line_number":17,"context_line":"trying to configure [DEFAUL]my_ip to an IP address."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patch introduces a new config option"},{"line_number":20,"context_line":"[libvirt]migration_inbound_addr that is used to determine the address"},{"line_number":21,"context_line":"for incoming move operations (cold migrate, resize, evacuate). This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8d7e08b5_5d3e370e","line":18,"updated":"2023-12-05 09:32:54.000000000","message":"nit: [DEFAULT]","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c68ddb091b91d9c0bf9cbe50b7ad8740f0d3280a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fb75718_2ec1f189","updated":"2023-11-07 17:00:16.000000000","message":"add a reno","commit_id":"6d63f6f87f65c5d21bc8720ccba7d0c3bb0c378c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0b59e1d56b8f5bebab99625a2f86aca47ba4e474","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"802904e7_f8bc4b48","in_reply_to":"9fb75718_2ec1f189","updated":"2023-11-12 09:28:47.000000000","message":"Added reno","commit_id":"6d63f6f87f65c5d21bc8720ccba7d0c3bb0c378c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b078fcce665144e39e4e15edd50f188d8e078018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c36790fa_15140992","updated":"2023-11-15 11:06:15.000000000","message":"lgtm, just a nit.","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3737ba321c306bf31a1c26bd37b83f0e35151fb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8d6a69b_b971e50d","updated":"2023-12-05 09:32:54.000000000","message":"nice work gibi this was quite easy to review.\nthe test coverage is good and the release note covers the main poitnts.\ni dont think the nit require a respin so +2w","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"}],"nova/conf/libvirt.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c68ddb091b91d9c0bf9cbe50b7ad8740f0d3280a","unresolved":true,"context_lines":[{"line_number":931,"context_line":""},{"line_number":932,"context_line":"An included \"%s\" is replaced with the hostname of the migration target"},{"line_number":933,"context_line":"hypervisor."},{"line_number":934,"context_line":""},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"Related options:"},{"line_number":937,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"40dd0f9c_5005ada9","line":934,"updated":"2023-11-07 17:00:16.000000000","message":"Note that it should only be changed after the cloud is upgraded to C","commit_id":"6d63f6f87f65c5d21bc8720ccba7d0c3bb0c378c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0b59e1d56b8f5bebab99625a2f86aca47ba4e474","unresolved":false,"context_lines":[{"line_number":931,"context_line":""},{"line_number":932,"context_line":"An included \"%s\" is replaced with the hostname of the migration target"},{"line_number":933,"context_line":"hypervisor."},{"line_number":934,"context_line":""},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"Related options:"},{"line_number":937,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"94ca7c8e_d3b484d1","line":934,"in_reply_to":"40dd0f9c_5005ada9","updated":"2023-11-12 09:28:47.000000000","message":"Noted in the reno.","commit_id":"6d63f6f87f65c5d21bc8720ccba7d0c3bb0c378c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b078fcce665144e39e4e15edd50f188d8e078018","unresolved":true,"context_lines":[{"line_number":921,"context_line":"    cfg.StrOpt(\u0027migration_inbound_addr\u0027,"},{"line_number":922,"context_line":"                       default\u003d\u0027$my_ip\u0027,"},{"line_number":923,"context_line":"                       help\u003d\"\"\""},{"line_number":924,"context_line":"The address used as the migration address for this host."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"This option indicates the IP address, hostname, or FQDN which should be used as"},{"line_number":927,"context_line":"the target for cold migration, resize, and evacuate traffic when moving to this"}],"source_content_type":"text/x-python","patch_set":3,"id":"8b320bca_189ed714","line":924,"range":{"start_line":924,"start_character":34,"end_line":924,"end_character":41},"updated":"2023-11-15 11:06:15.000000000","message":"nit: s/address/target/","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b078fcce665144e39e4e15edd50f188d8e078018","unresolved":false,"context_lines":[{"line_number":930,"context_line":"destination."},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"An included \"%s\" is replaced with the hostname of the migration target"},{"line_number":933,"context_line":"hypervisor."},{"line_number":934,"context_line":""},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"eca84c7e_1d816489","line":933,"updated":"2023-11-15 11:06:15.000000000","message":"fwiw, live_migration_inbound_addr defaults to use the target hostname since its default value is None but I understand the reason why we have a different default value.","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3737ba321c306bf31a1c26bd37b83f0e35151fb0","unresolved":false,"context_lines":[{"line_number":930,"context_line":"destination."},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"An included \"%s\" is replaced with the hostname of the migration target"},{"line_number":933,"context_line":"hypervisor."},{"line_number":934,"context_line":""},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"c1bab714_d2c71273","line":933,"in_reply_to":"eca84c7e_1d816489","updated":"2023-12-05 09:32:54.000000000","message":"yep for future us its to preserve the existing behavior so that operators have to opt in to the new hostname behavior since they may not have dns /etc/hosts configured to make hostnames or fqdns work.","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"}],"nova/tests/functional/libvirt/test_migration_addr.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"21089218c6e5e0fb41efe5ffd00d5558bd7c82a5","unresolved":true,"context_lines":[{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@ddt.ddt"},{"line_number":26,"context_line":"class LibvirtMigrationAddrTest(base.ServersTestBase):"},{"line_number":27,"context_line":"    ADMIN_API \u003d True"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4430e68e_7f8c47c2","line":25,"updated":"2023-11-06 16:14:46.000000000","message":"it is unused","commit_id":"155d7d75adf8d49ffcb1a1c73c5bcf9910e6a921"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c2a63b73cead5f9e14a69484e092434eacd2c3d7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@ddt.ddt"},{"line_number":26,"context_line":"class LibvirtMigrationAddrTest(base.ServersTestBase):"},{"line_number":27,"context_line":"    ADMIN_API \u003d True"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae09086_d1592af6","line":25,"in_reply_to":"4430e68e_7f8c47c2","updated":"2023-11-07 09:38:19.000000000","message":"Done","commit_id":"155d7d75adf8d49ffcb1a1c73c5bcf9910e6a921"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b078fcce665144e39e4e15edd50f188d8e078018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"205ae371_7a383cbf","updated":"2023-11-15 11:06:15.000000000","message":"all good thanks, I understand then that oslo.config uses my_ip config value then by default 😊","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3737ba321c306bf31a1c26bd37b83f0e35151fb0","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super().setUp()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _test_move_op(self, move_op, migration_inbound_addr\u003dNone):"},{"line_number":31,"context_line":"        if migration_inbound_addr:"},{"line_number":32,"context_line":"            CONF.set_default("},{"line_number":33,"context_line":"                \"migration_inbound_addr\", migration_inbound_addr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"29c72f17_7564617c","line":30,"updated":"2023-12-05 09:32:54.000000000","message":"+1 pulling this out into a common test method is nice","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3737ba321c306bf31a1c26bd37b83f0e35151fb0","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        self._evacuate_server(server, expected_state\u003d\u0027ACTIVE\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_cold_migrate_with_ip(self):"},{"line_number":76,"context_line":"        self._test_move_op(self._cold_migrate, migration_inbound_addr\u003dNone)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_cold_migrate_with_hostname(self):"},{"line_number":79,"context_line":"        self._test_move_op(self._cold_migrate, migration_inbound_addr\u003d\"%s\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"744c5293_fa6cad64","line":76,"updated":"2023-12-05 09:32:54.000000000","message":"if you really wnated too this could have been done with DDT but i kind of like doing it by hand instead as we get better names","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3737ba321c306bf31a1c26bd37b83f0e35151fb0","unresolved":true,"context_lines":[{"line_number":19366,"context_line":"        self.assertTrue(drvr._is_path_shared_with(\u0027source-hostname\u0027, \u0027/path\u0027))"},{"line_number":19367,"context_line":"        mock_exec.assert_not_called()"},{"line_number":19368,"context_line":"        mock_exists.assert_not_called()"},{"line_number":19369,"context_line":"        mock_unlink.assert_not_called()"},{"line_number":19370,"context_line":""},{"line_number":19371,"context_line":"    @mock.patch.object(os.path, \u0027exists\u0027)"},{"line_number":19372,"context_line":"    def test_shared_storage_detection_migration_inbound_addr("}],"source_content_type":"text/x-python","patch_set":3,"id":"5efc07ea_1e894ca4","line":19369,"updated":"2023-12-05 09:32:54.000000000","message":"+1 nice i had forgot about same host migration or rather same host resize.","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3737ba321c306bf31a1c26bd37b83f0e35151fb0","unresolved":true,"context_lines":[{"line_number":11472,"context_line":"        #             on the same filesystem: the source and dest migration"},{"line_number":11473,"context_line":"        #             address are the same, or we create a file on the dest"},{"line_number":11474,"context_line":"        #             system via SSH and check whether the source system can"},{"line_number":11475,"context_line":"        #             also see it."},{"line_number":11476,"context_line":"        shared_path \u003d (dest \u003d\u003d self.get_host_ip_addr())"},{"line_number":11477,"context_line":"        if not shared_path:"},{"line_number":11478,"context_line":"            tmp_file \u003d uuidutils.generate_uuid(dashed\u003dFalse) + \u0027.tmp\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"102fe959_db0deacf","line":11475,"updated":"2023-12-05 09:32:54.000000000","message":"un related to this.\n\nthere has been some interest in replacing this method with one that did an rpc instead of ssh to check if the file is visable on the dest host.\n\nbasicaly when using only ceph backed storage some operators would like to remove the ssh requriement entirly.\n\nthatas out of scope of this patch i just recaled it since you updated this.","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"}],"releasenotes/notes/bp-libvirt-migrate-with-hostname-instead-of-ip-98d42c25575590b1.yaml":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b078fcce665144e39e4e15edd50f188d8e078018","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    configuration backward compatible. However it allows an explicit hostname"},{"line_number":8,"context_line":"    or FQDN to be specified, or allows to specify \u0027%s\u0027 that is then resolved to"},{"line_number":9,"context_line":"    the hostname of compute host."},{"line_number":10,"context_line":"    Note that this config should only be changed from its default after every"},{"line_number":11,"context_line":"    compute is upgraded."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9951018d_5a85613f","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":24},"updated":"2023-11-15 11:06:15.000000000","message":"+1, definitely, so a D or E change.","commit_id":"6bca37e904e9e56b250b123abde1901e951c8c9a"}]}