)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e38dbaf668534a8bb3bcc508df6c3dd06289cb2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8ef4d198_1168fe0c","updated":"2023-11-15 19:09:21.000000000","message":"So I have the quick fix here: https://review.opendev.org/c/openstack/nova/+/899776\n\nIn parallel, isn\u0027t this patch missing scheduler smarts? Even with the flavor extra spec/image property, nothing here is preventing such a flavor/image from landing on an AMD host and failing to boot...","commit_id":"3baf80d00d7e83e9fa3c08f1ef1fb4e83baee5d8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6f1d210e3269705f5640ce79f5d8cb84235b38c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ee5635c9_1de29a65","updated":"2023-11-13 06:42:27.000000000","message":"recheck","commit_id":"3baf80d00d7e83e9fa3c08f1ef1fb4e83baee5d8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3cf965c89dbc221a92858ad7edbaac509d8c536d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22def8b9_50eb7ad7","updated":"2023-11-13 10:54:08.000000000","message":"recheck timeout","commit_id":"3baf80d00d7e83e9fa3c08f1ef1fb4e83baee5d8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4de98e93f6d281fcf2ae31354a336a75e2c4d3e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0349602b_30c29719","in_reply_to":"8ef4d198_1168fe0c","updated":"2023-11-16 11:59:43.000000000","message":"yep thats why we need a trait.\n\non intel host we can advertise COMPUTE_VMCS but we should not advertise that on amd hosts\n\nwe can debate if that should be HW_CPU_X86_INTEL_VMCS but i do not be live its actully a cpu flag its a feature of kvm and the ableity to emulate the VMCS enlitenment\n\n\nso it shoudl be a COMPUTE_ trait not a HW_ triat\n\nso we shoudl add the vmcs trait here\nhttps://github.com/openstack/os-traits/blob/master/os_traits/compute/__init__.py#L53\n\nwe will need to also add a new translate function here\n\nhttps://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L187-L195\n\nyou can use https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L265-L272\nas a referece of what that should look like.","commit_id":"3baf80d00d7e83e9fa3c08f1ef1fb4e83baee5d8"}],"nova/objects/image_meta.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7a0a2d9c6762beaf245b64bb77abc5ea306d7d57","unresolved":true,"context_lines":[{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        # boolean - if true will enble evmcs for instance"},{"line_number":480,"context_line":"        \u0027hw_evmcs\u0027: fields.FlexibleBooleanField(),"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        # if true download using bittorrent"},{"line_number":483,"context_line":"        \u0027img_bittorrent\u0027: fields.FlexibleBooleanField(),"},{"line_number":484,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"de6cd16c_8895139d","line":481,"updated":"2023-11-15 18:29:00.000000000","message":"the probalme with this approch is this cannto be backported.\n\n\ni think we need to have two patches.\n\none that stops enabling evmcs and maintains the evmcs in the xml on live migration\n\nand then a second to opt into enableing evmcs\n\nother wise we wont be able to fix this on stable branches.","commit_id":"3baf80d00d7e83e9fa3c08f1ef1fb4e83baee5d8"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7a0a2d9c6762beaf245b64bb77abc5ea306d7d57","unresolved":true,"context_lines":[{"line_number":6230,"context_line":"            hv.reenlightenment \u003d True"},{"line_number":6231,"context_line":"            hv.tlbflush \u003d True"},{"line_number":6232,"context_line":"            hv.ipi \u003d True"},{"line_number":6233,"context_line":"            hv.evmcs \u003d self._get_evmcs(image_meta, flavor)"},{"line_number":6234,"context_line":""},{"line_number":6235,"context_line":"            # NOTE(kosamara): Spoofing the vendor_id aims to allow the nvidia"},{"line_number":6236,"context_line":"            # driver to work on windows VMs. At the moment, the nvidia driver"}],"source_content_type":"text/x-python","patch_set":3,"id":"b93ab8e7_623de98a","line":6233,"updated":"2023-11-15 18:29:00.000000000","message":"note we cannot change this on live migration so\nyou need to add special handleign for that or this will break upgrades.\n\none way to adress this is to recorded hw_evmcs in teh instance system metadata for all instance in a host in inti_host if its not already set.\n\nThat woudl ensure that instnace that have it now would continue to have it going forward.\n\nif we make evmcs optional we also need to advertise that a host supprot evmcs and schdule based on that. normally we woudl add a triat for that and request it automaticly based on the falvor extra spec/image property.","commit_id":"3baf80d00d7e83e9fa3c08f1ef1fb4e83baee5d8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7a0a2d9c6762beaf245b64bb77abc5ea306d7d57","unresolved":true,"context_lines":[{"line_number":6269,"context_line":"    def _get_evmcs(self, image_meta, flavor):"},{"line_number":6270,"context_line":"        return (strutils.bool_from_string("},{"line_number":6271,"context_line":"            flavor.extra_specs.get(\u0027hw:evmcs\u0027, \u0027False\u0027)) or"},{"line_number":6272,"context_line":"                image_meta.properties.get(\u0027hw_evmcs\u0027, False))"},{"line_number":6273,"context_line":""},{"line_number":6274,"context_line":"    def _check_number_of_serial_console(self, num_ports):"},{"line_number":6275,"context_line":"        if ("}],"source_content_type":"text/x-python","patch_set":3,"id":"9e6ff6aa_f215cc99","line":6272,"updated":"2023-11-15 18:29:00.000000000","message":"ack so this will default to disabeld but allow you to opt in.\n\ni think that is ok","commit_id":"3baf80d00d7e83e9fa3c08f1ef1fb4e83baee5d8"}],"releasenotes/notes/hyperv-enligtened-vmcs-310e854b03f7677c.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3d02518d52c9ba385fa517716141843ac25df992","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d5803f94_d5609e7e","line":10,"updated":"2023-11-15 18:29:39.000000000","message":"as currently proposed this would break upgrades and live migration.","commit_id":"3baf80d00d7e83e9fa3c08f1ef1fb4e83baee5d8"}]}