)]}'
{"id":"openstack%2Fnova~900832","triplet_id":"openstack%2Fnova~stable%2Fwallaby~I4bf83d1642b62ab103716aff6dae7438646e2b31","project":"openstack/nova","branch":"stable/wallaby","topic":"bug/2027755","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2024-03-05 19:04:06.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I4bf83d1642b62ab103716aff6dae7438646e2b31","subject":"Decorate only Flavor.get_* methods that execute queries","status":"ABANDONED","created":"2023-11-13 23:26:45.000000000","updated":"2024-03-05 19:04:06.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a19009f1ce73204d634ccb72a9c1bb0ad0577388","_number":900832,"virtual_id_number":900832,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-11-14 01:02:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-13 23:58:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-11-14 01:02:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-05 19:04:05.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"5cb623ebb9ce5c07cbbd86a70dd8612de29af3f1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-11-13 23:26:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9204fea74e812eb5b8bca3022e0aeeac63b2b677","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-13 23:58:32.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e4f07685fc74488a95089b4b828343eb\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/b5d207cee3c640ee930aff8f39db81aa : SUCCESS in 29m 57s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/3bb7082dec5b45e9976e8f72b36ca740 : SUCCESS in 14m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8fd1bd1aaa90168d88685fa7b8624a47139dd7ed","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-14 01:02:09.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/3075dd2ca95b47d5805c5b78311ad911\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/04b040e30181481e9bba5d2ea5e9031c : SUCCESS in 1h 07m 13s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/ab29a4174270403c976d93dd926861c3 : FAILURE in 1h 31m 02s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/023b78a1c2e64be095a01073d5d94cd4 : SUCCESS in 17m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2fcc7d962814462e94b15f2937c1d03d : SUCCESS in 7m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e8dfdfc1b5b442adb42f43bb372e9f0e : SUCCESS in 19m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/cfd5b4b9cc314dc08b9b60d5351ccfc9 : SUCCESS in 12m 45s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e571fce0da6b461b84a8f8faf19401be : SUCCESS in 12m 21s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/da8875e08b544ca8931d6359b10d1aa4 : SUCCESS in 8m 28s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/b6564e9ee1c84b519511a57a49a20fb1 : SUCCESS in 51m 09s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/952309b5894a422493035a298906e73c : SUCCESS in 1h 13m 29s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ec4359f495b14eb9af190734704ecaa5 : SUCCESS in 55m 27s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/77f1b7c18f8d489d9405b53e0a91e1f0 : SUCCESS in 56m 17s\n- nova-next https://zuul.opendev.org/t/openstack/build/2271613634e74fc99d70f3c7d4290b3c : FAILURE in 1h 26m 57s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/76e738c34f53461783f648a7249a5be2 : SUCCESS in 40m 55s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/98c6f639e1364116b72b349a9e9f7bd2 : FAILURE in 5m 43s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/ff65f886e0204080812fbaf72e409eff : SUCCESS in 19m 18s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/52f103a451fb4082b0c78166218f9b6c : SUCCESS in 18m 09s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/f4cab2a1cead416bbcb58cab150037d1 : SUCCESS in 56m 32s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/51c9e221a12c4b9ead2c35418e422387 : SUCCESS in 43m 32s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/4a362cb39fcb455dba60f8471ac58bd7 : SUCCESS in 24m 30s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/36137db6396442bb993e7b8620cf80f5 : FAILURE in 28m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a19009f1ce73204d634ccb72a9c1bb0ad0577388","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 19:04:06.000000000","message":"Abandoned\n\nstable/wallaby branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/wallaby if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"640d2363832b42b3882d640dc168685e5a71fc9b","revisions":{"640d2363832b42b3882d640dc168685e5a71fc9b":{"kind":"REWORK","_number":1,"created":"2023-11-13 23:26:45.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/32/900832/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/32/900832/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/32/900832/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/32/900832/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/32/900832/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/32/900832/1"}}},"commit":{"parents":[{"commit":"2ace99d76b4f4a7d4b879ceb40111db6bcc09121","subject":"Merge \"Accept both 1 and Y as AMD SEV KVM kernel param value\" into stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2ace99d76b4f4a7d4b879ceb40111db6bcc09121"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-14 02:23:23.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-11-13 23:24:25.000000000","tz":0},"subject":"Decorate only Flavor.get_* methods that execute queries","message":"Decorate only Flavor.get_* methods that execute queries\n\nThe get_* methods on the Flavor object use a common helper method to\nbuild a query object to execute later.\n\nCurrently, the @api_db_api.context_manager.reader decorator which\nmanages the session is located on the helper method instead of on the\nmethods that actually execute the database queries. Part of the context\nmanager\u0027s job is to close the session after the query is executed.\nBecause the decorator is not on the methods that actually execute the\nqueries, those database connections are not being closed and it will\neventually lead to errors like:\n\n  sqlalchemy.exc.TimeoutError: QueuePool limit of size 5 overflow 50\n  reached, connection timed out, timeout 30.00 (Background on this\n  error at: https://sqlalche.me/e/14/3o7r)\n\nwhich means the connection pool size plus the overflow size has been\nreached and the pool will block for a fixed period of time before\ntiming out and raising this error.\n\nThis removes the @api_db_api.context_manager.reader decorator from the\nquery build helper method and adds it to the Flavor.get_* methods that\nexecute the database queries.\n\nConflicts:\n    nova/objects/flavor.py\n\nNOTE(melwitt): The conflicts are because change\nIa5304c552ce552ae3c5223a2bfb3a9cd543ec57c (db: Post reshuffle cleanup)\nis not in Wallaby.\n\nCloses-Bug: #2027755\n\nChange-Id: I4bf83d1642b62ab103716aff6dae7438646e2b31\n(cherry picked from commit 9ae6240c92e212b2fa96d5163f68ef1b30ee03b7)\n(cherry picked from commit 4f4f27be27cb202be6a8fb949ad21021a5cd735d)\n(cherry picked from commit 53e3afe3a6024be6ead35132230dc468dd808850)\n(cherry picked from commit 5f1f22c07a00021cacf97d74031c1033916f9b44)\n(cherry picked from commit 47f9606e00d78a7ef8fd5115eada1959b3773c75)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/640d2363832b42b3882d640dc168685e5a71fc9b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/640d2363832b42b3882d640dc168685e5a71fc9b"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}