)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"456ba91f54e2a715f07b3ce97c90a499864a5744","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75e97a66_9e381543","updated":"2023-11-20 15:00:00.000000000","message":"Eventually I haven\u0027t found any problem. Sorry I was overthought.","commit_id":"647e3ace62c4cd396a59331388484893ce395583"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"cd8af8ca936e452eaff11cd76b81ef5dd43a7f0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6779a99e_3fbc80c0","updated":"2023-11-16 17:58:27.000000000","message":"Sounds promising but I need to consider the strategy modification change before +2.","commit_id":"647e3ace62c4cd396a59331388484893ce395583"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6e29641493f4e8403506df59bb786124b3b451b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aad46f8c_40140103","updated":"2023-11-20 12:13:19.000000000","message":"ill hold +2 until sylvain responds but i dont see a isuse with this in regrades to stragey change","commit_id":"647e3ace62c4cd396a59331388484893ce395583"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7cd058a05da92120be8b2b559ae693843744389e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98ce784e_dd8ecb80","updated":"2023-11-20 15:16:36.000000000","message":"looks like \n\nnova.tests.functional.libvirt.test_power_manage.PowerManagementTests.test_hardstop_compute_service_if_wrong_opt\n\nso we need to fix that first","commit_id":"647e3ace62c4cd396a59331388484893ce395583"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e08b895ee43b21bdd05de79044dfb65b415e882d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51bd90dc_9da95664","updated":"2023-11-20 15:16:34.000000000","message":"oh actually, I\u0027d like a relnote because we\u0027re changing the behaviour.","commit_id":"647e3ace62c4cd396a59331388484893ce395583"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d8f2dac628319324a7521cf70d526c1bcabd0a8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab78d199_4b9ecba0","in_reply_to":"51bd90dc_9da95664","updated":"2023-11-21 14:37:10.000000000","message":"Done","commit_id":"647e3ace62c4cd396a59331388484893ce395583"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6edcfcd7e94c12c2aba4f71873f00c083abf7008","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82e0937c_79bd7b1a","in_reply_to":"6779a99e_3fbc80c0","updated":"2023-11-20 10:22:57.000000000","message":"Which strategy modification change do you refer to? With a quick look I don\u0027t see an explicit check about changing strategy. There are some indirect checks in validate_all_dedicated_cpus. I.e. \n1. if the configuration changed from cpu_state to governor then all the pcpus should be up. In the 0 pcpu case the cpu_states set will be empty so no False will be in it. This means with 0 pcpus you can always change from cpu_state to governor. Which seems logical to me.\n2. if the configuration is change from governor to cpu_state then all the pcpus should have a single governor. In 0 pcpu case governors set will be empty. So the code will allow the change with 0 pcpu. Which also seems to be logical to me.","commit_id":"647e3ace62c4cd396a59331388484893ce395583"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6e29641493f4e8403506df59bb786124b3b451b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b9a0b32b_03490d7d","in_reply_to":"82e0937c_79bd7b1a","updated":"2023-11-20 12:13:19.000000000","message":"sylvain i think that is not relevent to this.\n\n\nwhat sylvain is refering to for stragey modifciation is detecting if you change form online to govoner based enforcement.\n\nin which case we want all cpus to be online\n\n\nwe dont have protection for that today other then ensureing that all cores listed in cpu_dedicated_set are online when not using the cpu_state staragey and i dont think we should really be blockign this on that.","commit_id":"647e3ace62c4cd396a59331388484893ce395583"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d8f2dac628319324a7521cf70d526c1bcabd0a8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"039bc7fd_0cba45ca","in_reply_to":"98ce784e_dd8ecb80","updated":"2023-11-21 14:37:10.000000000","message":"Done","commit_id":"647e3ace62c4cd396a59331388484893ce395583"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f4aad5e88807fa094bc1cd5bcdf50500b57626bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5c2cddd_d1602cb2","updated":"2023-11-21 17:34:48.000000000","message":"I\u0027m still not convinced this is a \u0027bug\u0027 and this sounds more an operator/deployer behavioural change but I\u0027m tired on debating it, so let\u0027s pretend this fixes a bug.","commit_id":"b1a0aee1abca0ed61c156dd99544adeaebaf0960"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"166d34a066cc25a28a53c4e3f1229ddab7045677","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9b6b834_7a322547","updated":"2023-11-21 16:33:39.000000000","message":"a slight detail hence +1 but I disagree with the fact this is a bugfix.","commit_id":"b1a0aee1abca0ed61c156dd99544adeaebaf0960"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e928d5034cde54bb155f0c403d5c69c07ab5a54c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5150b62_5571a52e","updated":"2023-11-21 17:37:24.000000000","message":"recheck\n```\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/api/compute/images/test_images.py\", line 140, in test_create_server_from_snapshot\n    image \u003d self.create_image_from_server(server[\u0027id\u0027],\n  File \"/opt/stack/tempest/tempest/api/compute/base.py\", line 355, in create_image_from_server\n    waiters.wait_for_image_status(client, image_id, wait_until)\n  File \"/opt/stack/tempest/tempest/common/waiters.py\", line 162, in wait_for_image_status\n    image \u003d show_image(image_id)\n  File \"/opt/stack/tempest/tempest/lib/services/compute/images_client.py\", line 75, in show_image\n    resp, body \u003d self.get(\"images/%s\" % image_id)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 322, in get\n    return self.request(\u0027GET\u0027, url, extra_headers, headers,\n  File \"/opt/stack/tempest/tempest/lib/services/compute/base_compute_client.py\", line 47, in request\n    resp, resp_body \u003d super(BaseComputeClient, self).request(\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 742, in request\n    self._error_checker(resp, resp_body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 922, in _error_checker\n    raise exceptions.ServerFault(resp_body, resp\u003dresp,\ntempest.lib.exceptions.ServerFault: Got server fault\nDetails: Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.\n\u003cclass \u0027glanceclient.exc.HTTPBadGateway\u0027\u003e\n```","commit_id":"b1a0aee1abca0ed61c156dd99544adeaebaf0960"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"df32d972b4caf1d698a246618f79a9238b661450","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6956c39f_d049aa61","updated":"2023-11-22 03:27:31.000000000","message":"recheck nova-lvm different test (from test_create_server_from_snapshot) failed this time, seems unrelated.","commit_id":"b1a0aee1abca0ed61c156dd99544adeaebaf0960"}],"nova/tests/functional/libvirt/test_power_manage.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a0ccaf145456d28d45774201483a7286aa957616","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        self.flags(vcpu_pin_set\u003dNone)"},{"line_number":115,"context_line":"        self.flags(cpu_power_management\u003dTrue, group\u003d\u0027libvirt\u0027)"},{"line_number":116,"context_line":"        self.start_compute(host_info\u003dself.host_info, hostname\u003d\u0027compute2\u0027)"},{"line_number":117,"context_line":"        # NOTE(gibi): we test that no exception is raised by start_compute"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_create_server(self):"},{"line_number":120,"context_line":"        server \u003d self._create_server("}],"source_content_type":"text/x-python","patch_set":2,"id":"4c6f4130_15922b27","line":117,"updated":"2023-11-21 14:54:24.000000000","message":"+1","commit_id":"b1a0aee1abca0ed61c156dd99544adeaebaf0960"}],"releasenotes/notes/bug-2043707-power-management-no-pcpu-28dd7d07d0473ea2.yaml":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"166d34a066cc25a28a53c4e3f1229ddab7045677","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Relaxed the config option checking of the cpu_power_management feature of"},{"line_number":5,"context_line":"    the libvirt driver. The nova-compute service will start with"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3c113f6d_3b6ee398","line":2,"updated":"2023-11-21 16:33:39.000000000","message":"looks to me more a feature than a bug and I don\u0027t want it to be backported upstream.","commit_id":"b1a0aee1abca0ed61c156dd99544adeaebaf0960"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0ebf31cf3ef6b025748dccc91069e17061beb22e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Relaxed the config option checking of the cpu_power_management feature of"},{"line_number":5,"context_line":"    the libvirt driver. The nova-compute service will start with"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"98dbf708_612f11a1","line":2,"in_reply_to":"3c113f6d_3b6ee398","updated":"2023-11-21 16:59:42.000000000","message":"i disagree i think this was an oversight in the orginal code and should be backported upstream","commit_id":"b1a0aee1abca0ed61c156dd99544adeaebaf0960"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a0ccaf145456d28d45774201483a7286aa957616","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    [libvirt]cpu_power_management\u003dTrue and an empty [compute]cpu_dedicated_set"},{"line_number":7,"context_line":"    configuration. The power management is still only applied to dedicated CPUs."},{"line_number":8,"context_line":"    So the above configuration only allowed to ensure that cpu_power_management"},{"line_number":9,"context_line":"    can be enabled independently for configuring cpu_dedicated_set during"},{"line_number":10,"context_line":"    deployment."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"69729afc_34326829","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":36},"updated":"2023-11-21 14:54:24.000000000","message":"nit: of","commit_id":"b1a0aee1abca0ed61c156dd99544adeaebaf0960"}]}