)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"0528375b9776bd4f235990ee77194a11b1d3f3d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76435d25_355d42b7","updated":"2024-02-06 10:46:56.000000000","message":"recheck","commit_id":"f7747a2e675462b037d15beacc62258828bb530a"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"db1e9409bc66da93066075d6124cd8befc625632","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f1bb55c5_58be44cc","updated":"2023-11-22 12:23:55.000000000","message":"recheck nova-ceph-multistore","commit_id":"f7747a2e675462b037d15beacc62258828bb530a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d7b7e4cb54bf8d1ecd46c01bb75baa2b3922512b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d86aa582_ebd34942","updated":"2024-08-06 14:28:31.000000000","message":"+1 because the direction is correct however the testing is rather light and ideally you would include a relese note.\n\nwhen fixing a issue like this that involve na interaction between multiple nova components, in this case the effect fo a rpc timeout between the conductor and a compute node we generally prefer to see the bug demonstrated in a functional reproduce test.\n\nhttps://github.com/openstack/nova/blob/bb2d7f9cad577f3a32cb9523e2b1d9a6d6db3407/nova/tests/functional/regressions/test_bug_1899835.py\n\nis likely a good example as it testing a failure during pre_live_migration similar to this although not quite the same.","commit_id":"8f77402a3deaa748cdec03cd4249652fd10f2886"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"ecd8ee05244de53a9798fd9db26ba71ec7a18842","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9582ecca_b2d9a888","updated":"2024-08-06 07:32:14.000000000","message":"recheck nova-multi-cell","commit_id":"8f77402a3deaa748cdec03cd4249652fd10f2886"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"4730a954d3711ff2db18ab8393e3060be4e416d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"00ac46bd_fe255b63","in_reply_to":"62ef95c0_423d89d0","updated":"2025-09-12 08:56:53.000000000","message":"Done","commit_id":"8f77402a3deaa748cdec03cd4249652fd10f2886"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8799bfd14e975e8313e5c575a1131b8bf1486285","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"62ef95c0_423d89d0","in_reply_to":"68bbe397_bb235312","updated":"2024-09-02 08:22:14.000000000","message":"Agree to get a functional reproducer first.","commit_id":"8f77402a3deaa748cdec03cd4249652fd10f2886"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52cd8052746e12d61c6b7ad1b919f0c693b04cfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dbf290f1_5e5b2fcf","in_reply_to":"d86aa582_ebd34942","updated":"2024-08-06 14:30:53.000000000","message":"to move this forward ideally a fuctional reproducer woudl be added  in a seperate review and this would be rebased on top of that. addtioanl a release note should be added to this test to document at a high level the for operators why they should apply this bug fix.\n\nyou can use a simplifed verison of the explaiting form the commit message as a 2-3 line \"fixes:\" release note referencing the fixed bug.","commit_id":"8f77402a3deaa748cdec03cd4249652fd10f2886"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c433f0ce07caec96ba0dc2f8b338745ccf6de7d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"68bbe397_bb235312","in_reply_to":"dbf290f1_5e5b2fcf","updated":"2024-08-06 14:34:45.000000000","message":"https://github.com/openstack/nova/commit/2ddb8bf53fdf9a17c09afc4987ab6efe8ba97696\n\nthis is another example functional test for premigration failure handling\n\nit shoudl be simple enough to copy that, mock the relevent function and have it raise the MessagingTimout expeciton\n\nthen assert that the vm is in error state when it shoudl be in active.","commit_id":"8f77402a3deaa748cdec03cd4249652fd10f2886"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"2d0176139196ed90c37543978cd901e908cee266","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1b71d243_17f44284","updated":"2025-09-15 07:46:55.000000000","message":"recheck nova-ceph-multistore","commit_id":"79f60e90eb8d10a2be76a0e5f6361c07ff87f340"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"885fc8e13e3d4a72dc3f0bddece2b7f4a5307ecb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b8109bc6_9ca270a4","updated":"2025-09-16 04:50:35.000000000","message":"LGTM","commit_id":"dc51a4271b6b328fdd655d48559f7220efcf794b"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"7bb086bbda35e59fd49465a654e07cc8e1335598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3db95237_3b9ff4bd","updated":"2025-09-15 21:12:44.000000000","message":"recheck nova-live-migration-ceph","commit_id":"dc51a4271b6b328fdd655d48559f7220efcf794b"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"041b30db88ceca4c7f76d4cc57f03db47f51eccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"61e01f58_342a5803","updated":"2025-09-15 18:13:53.000000000","message":"recheck nova-multi-cell","commit_id":"dc51a4271b6b328fdd655d48559f7220efcf794b"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"2555b7f781ec1bce5b6a44b0b38d062a45111b35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e1148761_76d7c1cd","updated":"2025-09-17 12:42:20.000000000","message":"recheck nova-next","commit_id":"dc51a4271b6b328fdd655d48559f7220efcf794b"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"a027e5190df6e114a671bf1b5a9e27526252083b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"12ddbe74_bcda2d9a","updated":"2025-09-16 06:56:52.000000000","message":"recheck nova-ovs-hybrid-plug","commit_id":"dc51a4271b6b328fdd655d48559f7220efcf794b"}],"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6c0103e27023e6addf0ebe92f25296aaeaf81a47","unresolved":true,"context_lines":[{"line_number":9092,"context_line":"                    self.compute_rpcapi.check_can_live_migrate_source("},{"line_number":9093,"context_line":"                        ctxt, instance, dest_check_data)"},{"line_number":9094,"context_line":"                )"},{"line_number":9095,"context_line":"            except Exception as ex:"},{"line_number":9096,"context_line":"                msg \u003d _(\"Error while check_can_live_migrate_source from \""},{"line_number":9097,"context_line":"                        \"%(src)s to host %(dest)s: %(ex_type)s %(ex)s\") % {"},{"line_number":9098,"context_line":"                            \u0027src\u0027: instance.host,"}],"source_content_type":"text/x-python","patch_set":11,"id":"24a0ac9e_47222603","line":9095,"updated":"2025-09-15 14:57:43.000000000","message":"while this is broader then we normally prefer i think this si ok.\n\nthe other exceptions i can think of form this would be a generic socket/dns error\nor if we have then mandatory deliver flag enable in rabbit and the queue does not exist we would catch that error as well.\n\nin all of those case including the timeout we cannot perform the require prechecks so raisign  exception.MigrationPreCheckError is correct.","commit_id":"dc51a4271b6b328fdd655d48559f7220efcf794b"}]}