)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ceffc49c024a252606f592b30682d925e9f2285","unresolved":true,"context_lines":[{"line_number":14,"context_line":"while on the user side, they were always believed that"},{"line_number":15,"context_line":"the evacuation action is still in progress."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Catching and handling this exception is extremely necessary."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related-Bug: 2044494"},{"line_number":20,"context_line":"Change-Id: I5b203da1a8222cd0d31f6109f60509927243426d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d4e546fc_3c02aa59","line":17,"updated":"2023-11-27 11:21:27.000000000","message":"this is an exaggeration this is a exceedingly minor bug.\ni do not like alarmist statements like this in commit messages.\n\nTechnically nova by design assumes a reliable message bus, meaning\nwe generally don\u0027t consider bug caused by a failure in the message bus to directly\nbe a nova bug. nova can and should try to recover where appropriate and log failures\nas a result but this is a low impact bug.\n\nit does not result in data loss although it does leave the migration in a trasinet state.","commit_id":"4b4bb2b9d52aa4008b8fb96e80cfff215a32725b"},{"author":{"_account_id":36561,"name":"Haidong Pang","display_name":"Haidong Pang","email":"haidong.pang@easystack.cn","username":"haidong.pang"},"change_message_id":"2a507e439089f4877ef4c01bab518e1bd184560a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"while on the user side, they were always believed that"},{"line_number":15,"context_line":"the evacuation action is still in progress."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Catching and handling this exception is extremely necessary."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related-Bug: 2044494"},{"line_number":20,"context_line":"Change-Id: I5b203da1a8222cd0d31f6109f60509927243426d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c06edd31_ed1cd865","line":17,"in_reply_to":"d4e546fc_3c02aa59","updated":"2023-11-27 11:59:54.000000000","message":"I acknowledge that for most users, the message bus has high stability and availability. \nHowever, in our development of high-availability system based on Nova, we could not fully trust that the message queue is completely reliable.\nWe need automated recovery when message bus issues interrupt instance evacuation, which depends on setting the instance to an error state.","commit_id":"4b4bb2b9d52aa4008b8fb96e80cfff215a32725b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ceffc49c024a252606f592b30682d925e9f2285","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37c0b6f8_ce27394e","updated":"2023-11-27 11:21:27.000000000","message":"you shoudl first demonstrate the bug with a reproduce functional test and then fix it in a second patch. that is the main rason for the -1 you need to demonstarte the issue and provide a test case to prevent regressions","commit_id":"4b4bb2b9d52aa4008b8fb96e80cfff215a32725b"},{"author":{"_account_id":36561,"name":"Haidong Pang","display_name":"Haidong Pang","email":"haidong.pang@easystack.cn","username":"haidong.pang"},"change_message_id":"0ea67a8af2d251391129a7a70035620df5f2fc62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e4f91e7_73eea588","in_reply_to":"37c0b6f8_ce27394e","updated":"2023-11-27 12:07:45.000000000","message":"I will try to do it.","commit_id":"4b4bb2b9d52aa4008b8fb96e80cfff215a32725b"}],"nova/conductor/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ceffc49c024a252606f592b30682d925e9f2285","unresolved":true,"context_lines":[{"line_number":1340,"context_line":"                        exception.AllocationUpdateFailed,"},{"line_number":1341,"context_line":"                        # The following exception is raised by"},{"line_number":1342,"context_line":"                        # _schedule_instances"},{"line_number":1343,"context_line":"                        MessagingTimeout,"},{"line_number":1344,"context_line":"                        # the next two can come from fill_provider_mapping and"},{"line_number":1345,"context_line":"                        # signals a software error."},{"line_number":1346,"context_line":"                        NotImplementedError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"68b9d2fc_0f396171","line":1343,"updated":"2023-11-27 11:21:27.000000000","message":"MessagingTimeout can be raised any time we have an rpc failure.","commit_id":"4b4bb2b9d52aa4008b8fb96e80cfff215a32725b"},{"author":{"_account_id":36561,"name":"Haidong Pang","display_name":"Haidong Pang","email":"haidong.pang@easystack.cn","username":"haidong.pang"},"change_message_id":"c2c785678ec37cab7705ffa7ee1a8153697a3c23","unresolved":false,"context_lines":[{"line_number":1340,"context_line":"                        exception.AllocationUpdateFailed,"},{"line_number":1341,"context_line":"                        # The following exception is raised by"},{"line_number":1342,"context_line":"                        # _schedule_instances"},{"line_number":1343,"context_line":"                        MessagingTimeout,"},{"line_number":1344,"context_line":"                        # the next two can come from fill_provider_mapping and"},{"line_number":1345,"context_line":"                        # signals a software error."},{"line_number":1346,"context_line":"                        NotImplementedError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5c6fe91a_faa6f879","line":1343,"in_reply_to":"68b9d2fc_0f396171","updated":"2023-11-27 11:41:27.000000000","message":"Of course MessagingTimeout will be raised.\nHowever,the unhandled exception may mislead users the instance remains in an evacuation execution state.","commit_id":"4b4bb2b9d52aa4008b8fb96e80cfff215a32725b"}]}
