)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1ee8dccda421607b6ac8c768aae15628babec5f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1025e517_6a7a5ee8","updated":"2023-12-04 13:01:38.000000000","message":"Good finding !","commit_id":"99fe8c93a1cac2cb6fa59218ea9bf8687bf8d4df"},{"author":{"_account_id":35499,"name":"alisafari","email":"alisafar1212@gmail.com","username":"alisafari","status":"Software Engineer"},"change_message_id":"7f4b033364b40ffbd4bf3ba5832b733d82c6deed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"88176f10_35c2b9a8","updated":"2023-11-30 21:40:26.000000000","message":"recheck","commit_id":"99fe8c93a1cac2cb6fa59218ea9bf8687bf8d4df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f22d95fd6dee3cd5d297db81bb2f4e3ac5537b54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"06cee1c9_469b79c3","updated":"2023-11-30 13:42:51.000000000","message":"this is a pretty simple but subtle fix.\nthanks for adding the extra test.\ni dont think this need a reasle note as there is nothign for the operator to do\nand this is a relitivly minor bug over all so im fine with merging this as is","commit_id":"99fe8c93a1cac2cb6fa59218ea9bf8687bf8d4df"}],"nova/tests/unit/virt/libvirt/test_utils.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f22d95fd6dee3cd5d297db81bb2f4e3ac5537b54","unresolved":true,"context_lines":[{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    def test_make_reverse_cpu_traits_mapping(self):"},{"line_number":714,"context_line":"        for k in libvirt_utils.make_reverse_cpu_traits_mapping():"},{"line_number":715,"context_line":"            self.assertIsInstance(k, str)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def test_get_flags_by_flavor_specs(self):"},{"line_number":718,"context_line":"        flavor \u003d objects.Flavor("}],"source_content_type":"text/x-python","patch_set":5,"id":"204f03bc_d534d5b0","line":715,"updated":"2023-11-30 13:42:51.000000000","message":"ok i was thinkign of doign this slightly diffenrtly and assertign that at least one \n2 of the keys mapped to the same value.\n\nbut ya asserting all valuses are stirngs also proves the tuples are correctly flattened so this works\n+1","commit_id":"99fe8c93a1cac2cb6fa59218ea9bf8687bf8d4df"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aa80d310a86955f5d77d7c247145885f40ab0d0d","unresolved":true,"context_lines":[{"line_number":114,"context_line":"            traits_cpu_mapping[v] \u003d k"},{"line_number":115,"context_line":"    return traits_cpu_mapping"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Reverse CPU_TRAITS_MAPPING"},{"line_number":119,"context_line":"TRAITS_CPU_MAPPING \u003d make_reverse_cpu_traits_mapping()"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ed1d0eea_731539a8","line":117,"updated":"2023-11-30 11:24:31.000000000","message":"as this is now a split out function can you add a new unit test that directly tests this by calling it directly and assert the touples are flattend","commit_id":"276e5f946477b9ce86342f9a4222a776257b4ea8"},{"author":{"_account_id":35499,"name":"alisafari","email":"alisafar1212@gmail.com","username":"alisafari","status":"Software Engineer"},"change_message_id":"5e47666b38f486b17a6794f31f4453faef198f8c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            traits_cpu_mapping[v] \u003d k"},{"line_number":115,"context_line":"    return traits_cpu_mapping"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Reverse CPU_TRAITS_MAPPING"},{"line_number":119,"context_line":"TRAITS_CPU_MAPPING \u003d make_reverse_cpu_traits_mapping()"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f7558839_238066ae","line":117,"in_reply_to":"004480ae_407497dd","updated":"2023-12-04 12:23:26.000000000","message":"Done","commit_id":"276e5f946477b9ce86342f9a4222a776257b4ea8"},{"author":{"_account_id":35499,"name":"alisafari","email":"alisafar1212@gmail.com","username":"alisafari","status":"Software Engineer"},"change_message_id":"c32567364117a19466f89d4abf539b3f4ac274f4","unresolved":true,"context_lines":[{"line_number":114,"context_line":"            traits_cpu_mapping[v] \u003d k"},{"line_number":115,"context_line":"    return traits_cpu_mapping"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Reverse CPU_TRAITS_MAPPING"},{"line_number":119,"context_line":"TRAITS_CPU_MAPPING \u003d make_reverse_cpu_traits_mapping()"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"004480ae_407497dd","line":117,"in_reply_to":"ed1d0eea_731539a8","updated":"2023-11-30 13:03:06.000000000","message":"Done","commit_id":"276e5f946477b9ce86342f9a4222a776257b4ea8"}]}