)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"391d5a7424588b28c4dcc82051d55c278f594264","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"15856ffa_6cc16bde","updated":"2023-12-07 10:49:50.000000000","message":"I\u0027m not sure this is good idea to show empty AZs to the normal user - this presents the user with AZ choice where you 100% can not boot a VM.\n\nIMO scenarios where you want to know about AZs even if it is not schedulable are only for admin (like monitoring and whatnot), so I\u0027d rather have this patch applicable to admin users only - basically the same who can call \u0027GET /os-availability-zone/detail\u0027","commit_id":"a7260542a2501d16cf91a6c0fc5500f4eec97ae4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"34366988d4175cf03e0d1f317a7018a4d2417e76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d43d119_0fc835f8","updated":"2023-12-07 14:27:04.000000000","message":"thanks for review Pavlo","commit_id":"a7260542a2501d16cf91a6c0fc5500f4eec97ae4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"34366988d4175cf03e0d1f317a7018a4d2417e76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c4302d9a_4a8a0cf8","in_reply_to":"15856ffa_6cc16bde","updated":"2023-12-07 14:27:04.000000000","message":"++ I will move empty AZ into non available AZs.","commit_id":"a7260542a2501d16cf91a6c0fc5500f4eec97ae4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d9544023492b9d6ec128bafeda71d4f10619c1ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d3db7d92_74056ace","updated":"2024-01-10 13:01:14.000000000","message":"recheck unknown bug","commit_id":"bec5a19c54a5939fed7ad3bf504556d452fbecc9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b1b87ad0eebbae478dbe60747f062a3fe56e5277","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ddd9d8bb_8e7d4cd6","updated":"2024-01-23 16:01:26.000000000","message":"Sorry, but we can\u0027t directly modify an API return without providing a new microversion, as this is changing the behaviour.\n\nI\u0027m not -2 because I don\u0027t want this, but it\u0027s rather a procedural concern. I could remove the -2 once a new blueprint is accepted.","commit_id":"7ffd8f3a8961de70c6832bfee71353ad770e671d"}],"nova/availability_zones.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b1b87ad0eebbae478dbe60747f062a3fe56e5277","unresolved":true,"context_lines":[{"line_number":151,"context_line":"            for az in aggregate_zones:"},{"line_number":152,"context_line":"                if az not in azs[0] and az not in azs[1]:"},{"line_number":153,"context_line":"                    azs[1].append(az)"},{"line_number":154,"context_line":"        return azs"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def _get_availability_zones("}],"source_content_type":"text/x-python","patch_set":4,"id":"d1ac2c87_3245d0a6","line":154,"updated":"2024-01-23 16:01:26.000000000","message":"This sounds to me an important behavioural change so we can\u0027t really merge this this way.\nEither we accept to return non-available AZs by a new API microversion or we don\u0027t accept this, but I think this is not a bugfix, rather a new feature, hence the -2 until we discuss about it and we accept a new blueprint.","commit_id":"7ffd8f3a8961de70c6832bfee71353ad770e671d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ce90395bdf9101155586b6ea53446a8c8b5cca46","unresolved":true,"context_lines":[{"line_number":151,"context_line":"            for az in aggregate_zones:"},{"line_number":152,"context_line":"                if az not in azs[0] and az not in azs[1]:"},{"line_number":153,"context_line":"                    azs[1].append(az)"},{"line_number":154,"context_line":"        return azs"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def _get_availability_zones("}],"source_content_type":"text/x-python","patch_set":4,"id":"2bbdc34a_61612c2e","line":154,"in_reply_to":"d1ac2c87_3245d0a6","updated":"2024-01-29 07:30:24.000000000","message":"Thanks for review Sylvain,\n\nDo we really need a new microversion here?\n* we do not change the format of response, it is the same\n* we do not change the status code of response\n* we do not remove any fields in object from payload\n* we do fix a bug where just created availability zone is not shown in availability_zones if its empty\n\nAccording to Microversioning policy we do not need a new API microversion, but may be I\u0027m missing something\nhttps://docs.openstack.org/nova/latest/contributor/microversions.html","commit_id":"7ffd8f3a8961de70c6832bfee71353ad770e671d"}]}