)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"1fb72908c13bb7adf6eaa7ef3cfa6875275f1141","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"044f7db1_e9ae7e9c","updated":"2023-12-12 16:29:53.000000000","message":"Changing the default appears to break the upgrade job. Shame","commit_id":"13ec04e56691170ec4f1331f6fececb8cd26dbdc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"83ec4b882079534e058a28b4bed690f7810e489b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"89bb42a3_02cd6fca","in_reply_to":"044f7db1_e9ae7e9c","updated":"2023-12-13 16:10:54.000000000","message":"hmm, do you know why?","commit_id":"13ec04e56691170ec4f1331f6fececb8cd26dbdc"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"518eb233c8f4d7b7c0c1589f322c74843cbaa378","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"98cea5de_0ac8a7b4","in_reply_to":"89bb42a3_02cd6fca","updated":"2023-12-21 14:27:19.000000000","message":"Unfortunately no, I wasn\u0027t able to conclusively find a cause","commit_id":"13ec04e56691170ec4f1331f6fececb8cd26dbdc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7e75f045199ae6dcaf81b7482a5cb8c7720d30f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9af20c24_a8aadc35","updated":"2024-02-02 14:30:09.000000000","message":"Maybe I\u0027m missing something that being said, so please explain why you want to add that argument.","commit_id":"ab9baf292d7472813a331e81479ce4f1ee03b638"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"faa20333149a391fda6acd9294ed97e06678ea29","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"67eb2745_0cd51103","updated":"2023-12-28 17:26:05.000000000","message":"is this still needed since https://review.opendev.org/c/openstack/kolla/+/902057 merged?","commit_id":"ab9baf292d7472813a331e81479ce4f1ee03b638"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bca9918582cb542266185ae87f3334deed830f52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"927406e6_072e899e","updated":"2024-01-01 18:17:58.000000000","message":"ok, then LGTM","commit_id":"ab9baf292d7472813a331e81479ce4f1ee03b638"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"87ee29ba3a3091f78ee89f78b294327842748e5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"06a808f9_2b53e5bc","in_reply_to":"19493708_b0899b2f","updated":"2024-01-03 09:10:28.000000000","message":"For future reference, this would allow us to automate the \"nova database password\" section of this change: Ibebd6e04de215e1a1aaff52c55d28c4741af98f2","commit_id":"ab9baf292d7472813a331e81479ce4f1ee03b638"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"3b031e2e3cda40f6ebe7d111e403cdae4ada7a8f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"19493708_b0899b2f","in_reply_to":"67eb2745_0cd51103","updated":"2024-01-01 17:52:42.000000000","message":"Yes, this is for a different issue","commit_id":"ab9baf292d7472813a331e81479ce4f1ee03b638"}],"nova/cmd/manage.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f4f63d149c7a33a51b780c901be0a5ffda138cf7","unresolved":true,"context_lines":[{"line_number":742,"context_line":"               \u0027from the Nova configuration.\u0027"},{"line_number":743,"context_line":"         )"},{"line_number":744,"context_line":"    def map_cell0(self, database_connection\u003dNone):"},{"line_number":745,"context_line":"        \"\"\"Create a cell mapping for cell0."},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        cell0 is used for instances that have not been scheduled to any cell."},{"line_number":748,"context_line":"        This generally applies to instances that have encountered an error"},{"line_number":749,"context_line":"        before they have been scheduled."},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        This command creates a cell mapping for this special cell which"},{"line_number":752,"context_line":"        requires a database to store the instance data."},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        Returns 0 if cell0 created/updated successfully or already setup."},{"line_number":755,"context_line":"        \"\"\""},{"line_number":756,"context_line":"        try:"},{"line_number":757,"context_line":"            self._map_cell0(database_connection\u003ddatabase_connection)"}],"source_content_type":"text/x-python","patch_set":3,"id":"8a50d064_a621f3bf","line":754,"range":{"start_line":745,"start_character":0,"end_line":754,"end_character":3},"updated":"2023-12-08 10:52:33.000000000","message":"Docstring could do with an update.","commit_id":"1252601e90b8256e1cdb599d6b1a18d48515043a"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"ea473aabbb8a86336d00163584358f52f4696a9d","unresolved":false,"context_lines":[{"line_number":742,"context_line":"               \u0027from the Nova configuration.\u0027"},{"line_number":743,"context_line":"         )"},{"line_number":744,"context_line":"    def map_cell0(self, database_connection\u003dNone):"},{"line_number":745,"context_line":"        \"\"\"Create a cell mapping for cell0."},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        cell0 is used for instances that have not been scheduled to any cell."},{"line_number":748,"context_line":"        This generally applies to instances that have encountered an error"},{"line_number":749,"context_line":"        before they have been scheduled."},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        This command creates a cell mapping for this special cell which"},{"line_number":752,"context_line":"        requires a database to store the instance data."},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        Returns 0 if cell0 created/updated successfully or already setup."},{"line_number":755,"context_line":"        \"\"\""},{"line_number":756,"context_line":"        try:"},{"line_number":757,"context_line":"            self._map_cell0(database_connection\u003ddatabase_connection)"}],"source_content_type":"text/x-python","patch_set":3,"id":"04609463_d7ce1307","line":754,"range":{"start_line":745,"start_character":0,"end_line":754,"end_character":3},"in_reply_to":"8a50d064_a621f3bf","updated":"2023-12-08 11:30:58.000000000","message":"Done","commit_id":"1252601e90b8256e1cdb599d6b1a18d48515043a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f4f63d149c7a33a51b780c901be0a5ffda138cf7","unresolved":true,"context_lines":[{"line_number":756,"context_line":"        try:"},{"line_number":757,"context_line":"            self._map_cell0(database_connection\u003ddatabase_connection)"},{"line_number":758,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":759,"context_line":"            print(_(\u0027Cell0 is already setup\u0027))"},{"line_number":760,"context_line":"        return 0"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def _map_cell0(self, database_connection\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"52232f71_3d1c40be","line":759,"updated":"2023-12-08 10:52:33.000000000","message":"We should no longer get here.","commit_id":"1252601e90b8256e1cdb599d6b1a18d48515043a"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"ea473aabbb8a86336d00163584358f52f4696a9d","unresolved":true,"context_lines":[{"line_number":756,"context_line":"        try:"},{"line_number":757,"context_line":"            self._map_cell0(database_connection\u003ddatabase_connection)"},{"line_number":758,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":759,"context_line":"            print(_(\u0027Cell0 is already setup\u0027))"},{"line_number":760,"context_line":"        return 0"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def _map_cell0(self, database_connection\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"d4301a30_24e6e7aa","line":759,"in_reply_to":"52232f71_3d1c40be","updated":"2023-12-08 11:30:58.000000000","message":"That should still trigger if no changes are made. Test test_map_cell0_returns_0_if_cell0_already_exists should catch that case: https://github.com/openstack/nova/blob/master/nova/tests/unit/cmd/test_manage.py#L1304","commit_id":"1252601e90b8256e1cdb599d6b1a18d48515043a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"96c9204f88ab97c48d0e319bd4a1fa4ad1afd4b3","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        try:"},{"line_number":757,"context_line":"            self._map_cell0(database_connection\u003ddatabase_connection)"},{"line_number":758,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":759,"context_line":"            print(_(\u0027Cell0 is already setup\u0027))"},{"line_number":760,"context_line":"        return 0"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def _map_cell0(self, database_connection\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fef389ec_2d1cd42b","line":759,"in_reply_to":"d4301a30_24e6e7aa","updated":"2023-12-12 09:48:16.000000000","message":"Only when update\u003dFalse (which didn\u0027t exist in PS3)","commit_id":"1252601e90b8256e1cdb599d6b1a18d48515043a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"96c9204f88ab97c48d0e319bd4a1fa4ad1afd4b3","unresolved":true,"context_lines":[{"line_number":797,"context_line":"                transport_url\u003d\"none:///\","},{"line_number":798,"context_line":"                database_connection\u003ddbc)"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        if update: "},{"line_number":801,"context_line":"            try:"},{"line_number":802,"context_line":"                cell_mapping.save()"},{"line_number":803,"context_line":"                print(_(\u0027Existing Cell0 mapping updated.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3e55efa5_a6b1d3ae","line":800,"range":{"start_line":800,"start_character":18,"end_line":800,"end_character":19},"updated":"2023-12-12 09:48:16.000000000","message":"nit: trailing whitespace","commit_id":"0257319248d89b710a2437fbcb8b91140f7066dc"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"d8460a5c8d4b1d6969ab1adf28d981339fbf8873","unresolved":false,"context_lines":[{"line_number":797,"context_line":"                transport_url\u003d\"none:///\","},{"line_number":798,"context_line":"                database_connection\u003ddbc)"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        if update: "},{"line_number":801,"context_line":"            try:"},{"line_number":802,"context_line":"                cell_mapping.save()"},{"line_number":803,"context_line":"                print(_(\u0027Existing Cell0 mapping updated.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"4bb141cb_486860ff","line":800,"range":{"start_line":800,"start_character":18,"end_line":800,"end_character":19},"in_reply_to":"3e55efa5_a6b1d3ae","updated":"2023-12-12 10:15:31.000000000","message":"Done","commit_id":"0257319248d89b710a2437fbcb8b91140f7066dc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7e75f045199ae6dcaf81b7482a5cb8c7720d30f9","unresolved":true,"context_lines":[{"line_number":744,"context_line":"    @args(\u0027--update\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027update\u0027,"},{"line_number":745,"context_line":"          help\u003d\u0027Update the cell0 mapping if it already exists.\u0027"},{"line_number":746,"context_line":"         )"},{"line_number":747,"context_line":"    def map_cell0(self, database_connection\u003dNone, update\u003dFalse):"},{"line_number":748,"context_line":"        \"\"\"Create a cell mapping for cell0."},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        cell0 is used for instances that have not been scheduled to any cell."}],"source_content_type":"text/x-python","patch_set":9,"id":"0cd8feca_1b38b32e","line":747,"updated":"2024-02-02 14:30:09.000000000","message":"fwiw, we already have an update_cell command that does what you need. Why do you want a specific argument here and why can\u0027t you use update cell ?\nhttps://docs.openstack.org/nova/latest/cli/nova-manage.html#cell-v2-update-cell","commit_id":"ab9baf292d7472813a331e81479ce4f1ee03b638"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"fb09c04ffc083231ef73c7e5d4b10719bab66287","unresolved":true,"context_lines":[{"line_number":744,"context_line":"    @args(\u0027--update\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027update\u0027,"},{"line_number":745,"context_line":"          help\u003d\u0027Update the cell0 mapping if it already exists.\u0027"},{"line_number":746,"context_line":"         )"},{"line_number":747,"context_line":"    def map_cell0(self, database_connection\u003dNone, update\u003dFalse):"},{"line_number":748,"context_line":"        \"\"\"Create a cell mapping for cell0."},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        cell0 is used for instances that have not been scheduled to any cell."}],"source_content_type":"text/x-python","patch_set":9,"id":"98aa5138_eda9c9bf","line":747,"in_reply_to":"0cd8feca_1b38b32e","updated":"2024-02-02 16:00:35.000000000","message":"I\u0027d like a single command that can be used to do both the create and update, since it would help with deployment automation.\nMy specific use case is that I\u0027m trying to improve password rotation support in kolla-ansible. As it is, redeploying with an updated database password will fail, since it is contained in the database connection string.","commit_id":"ab9baf292d7472813a331e81479ce4f1ee03b638"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7e75f045199ae6dcaf81b7482a5cb8c7720d30f9","unresolved":true,"context_lines":[{"line_number":1287,"context_line":"          help\u003d_(\u0027Enables the cell. Note that this makes a disabled cell \u0027"},{"line_number":1288,"context_line":"                 \u0027available for scheduling after a SIGHUP of the \u0027"},{"line_number":1289,"context_line":"                 \u0027nova-scheduler service\u0027))"},{"line_number":1290,"context_line":"    def update_cell(self, cell_uuid, name\u003dNone, transport_url\u003dNone,"},{"line_number":1291,"context_line":"                    db_connection\u003dNone, disable\u003dFalse, enable\u003dFalse):"},{"line_number":1292,"context_line":"        \"\"\"Updates the properties of a cell by the given uuid."},{"line_number":1293,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"edcfef76_2b7cbddc","line":1290,"updated":"2024-02-02 14:30:09.000000000","message":"Have you seen that method ?","commit_id":"ab9baf292d7472813a331e81479ce4f1ee03b638"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"fb09c04ffc083231ef73c7e5d4b10719bab66287","unresolved":false,"context_lines":[{"line_number":1287,"context_line":"          help\u003d_(\u0027Enables the cell. Note that this makes a disabled cell \u0027"},{"line_number":1288,"context_line":"                 \u0027available for scheduling after a SIGHUP of the \u0027"},{"line_number":1289,"context_line":"                 \u0027nova-scheduler service\u0027))"},{"line_number":1290,"context_line":"    def update_cell(self, cell_uuid, name\u003dNone, transport_url\u003dNone,"},{"line_number":1291,"context_line":"                    db_connection\u003dNone, disable\u003dFalse, enable\u003dFalse):"},{"line_number":1292,"context_line":"        \"\"\"Updates the properties of a cell by the given uuid."},{"line_number":1293,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"afafd275_8055e16c","line":1290,"in_reply_to":"edcfef76_2b7cbddc","updated":"2024-02-02 16:00:35.000000000","message":"Acknowledged","commit_id":"ab9baf292d7472813a331e81479ce4f1ee03b638"}]}