)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af0c988c8d758861bdbe80e72614ec973ac6ff77","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Return proper number of pci devices for virtio"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We cannot attach more than 26 volumes when using virtio driver."},{"line_number":10,"context_line":"Now, the compute will raise a correct 403 error in this situation"},{"line_number":11,"context_line":"(instead of 500)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0b9f4a44eb5ca1af59fdca7e239625ce34476374"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"505aab0d_5fcec363","line":10,"updated":"2023-12-09 01:21:46.000000000","message":"403 would be incorect\n\n409 would be accpeable\n\nthe intennded way to attach more then 26 voluems is to use virtio-scsi","commit_id":"aa63906c98c4aa39490cd3eb49f4553be78d597f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b791d3bddd76c58ac854ff82313ac963f12be523","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Return proper number of pci devices for virtio"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We cannot attach more than 26 volumes when using virtio driver."},{"line_number":10,"context_line":"Now, the compute will raise a correct 403 error in this situation"},{"line_number":11,"context_line":"(instead of 500)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0b9f4a44eb5ca1af59fdca7e239625ce34476374"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"752fca62_08cea0fb","line":10,"in_reply_to":"441bb25c_3c6ca987","updated":"2023-12-11 11:28:06.000000000","message":"i would be fine with changing TooManyDiskDevices to 409.\nwe should be intoducign an new excption here as we are reaching the maxuium number of pci devices.","commit_id":"aa63906c98c4aa39490cd3eb49f4553be78d597f"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"67564bd516f4c08bee027c0a96d14ccb46a52bd1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Return proper number of pci devices for virtio"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We cannot attach more than 26 volumes when using virtio driver."},{"line_number":10,"context_line":"Now, the compute will raise a correct 403 error in this situation"},{"line_number":11,"context_line":"(instead of 500)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0b9f4a44eb5ca1af59fdca7e239625ce34476374"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"441bb25c_3c6ca987","line":10,"in_reply_to":"505aab0d_5fcec363","updated":"2023-12-09 12:48:43.000000000","message":"403 is the answer given by TooManyDiskDevices Exception (see [1])\n\nI dont care about the 40x, so if you think I should change the TooManyDiskDevices to 409, let me know.\n\nHowever, I do think it\u0027s better to have a 40x rather than a 500.\n\nI agree with the fact that virtio-scsi is the way to achieve more than 26 (this is also what we do on our side), but virtio-scsi is not always possible. In that situation, a proper failure seems better than a 500.\n\n\n[1] https://github.com/openstack/nova/blob/master/nova/exception.py#L286","commit_id":"aa63906c98c4aa39490cd3eb49f4553be78d597f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"9da095eb194fb81569af12e771f912932bda7c05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93abafa4_89551356","updated":"2024-02-16 15:14:20.000000000","message":"I will need to revisit this","commit_id":"aa63906c98c4aa39490cd3eb49f4553be78d597f"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b791d3bddd76c58ac854ff82313ac963f12be523","unresolved":true,"context_lines":[{"line_number":168,"context_line":"    if disk_bus \u003d\u003d \"ide\":"},{"line_number":169,"context_line":"        return 4"},{"line_number":170,"context_line":"    elif disk_bus \u003d\u003d \u0027virtio\u0027:"},{"line_number":171,"context_line":"        return 26"},{"line_number":172,"context_line":"    else:"},{"line_number":173,"context_line":"        if CONF.compute.max_disk_devices_to_attach \u003c 0:"},{"line_number":174,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"08cfef2b_0a650a07","line":171,"updated":"2023-12-11 11:28:06.000000000","message":"so this is technialcly not the maxium  number of virtio devices if you use pci extention busses you can have more it just the maxium you can atach based on the number of pcie root ports we add today. if you have 20 neutron ports attaached to the instance then you will only be able to have 6 disks because the pci ports will be exausted.\n\nso this is not the correct fix, you will still get 500s.\n\nwe need to catch the error when adding a volume or network port instead.","commit_id":"aa63906c98c4aa39490cd3eb49f4553be78d597f"}]}