)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"35b74b3ebb1add3c18b5eadd21bb69a2d687d4e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4fc310a_1243fa3d","updated":"2023-12-28 16:31:16.000000000","message":"-1 for the unnecessary unit test, otherwise LGTM","commit_id":"763fd9512daa7432616d93d525ec31c2dde98ea0"},{"author":{"_account_id":36642,"name":"songjie","display_name":"Jie Song","email":"songjie_yewu@cmss.chinamobile.com","username":"songjie"},"change_message_id":"a4e58325365376506a8f4f2bbb70fbdd9825e60d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a45d1da5_24c43c0e","updated":"2024-01-17 05:43:16.000000000","message":"Hi, gibi, could you please check if the workflow works when you have a moment? I really appreciate it.","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5834be78b1204917c1a29b15fba4c989538f76cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b929bb82_e07ab41c","updated":"2023-12-29 04:01:44.000000000","message":"im debating if this should have a release note or not.\ni think the livemigration impact is likely something that cloud admins would want to know about so a “fixes” release note is proably warrentted.\n\nim not back form pto until th 8th so ill look at this again then.\n\nwill removing this enlightenment have any other negitive sidefects on windows vms running hyperv or wsl?","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"590cb6e745eda2794fbfd6f3dd5b313699fd608e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc9b6327_f1af8ff8","updated":"2024-01-11 15:49:59.000000000","message":"ok if you need to respin this due to a merge conflict or to other feedback please ad a fixes release note but i think we could proceed with this","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"},{"author":{"_account_id":36642,"name":"songjie","display_name":"Jie Song","email":"songjie_yewu@cmss.chinamobile.com","username":"songjie"},"change_message_id":"9b435a6c917985d724dbcc8fa26b5689505ced7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3c2da051_9777a94f","updated":"2023-12-29 06:19:02.000000000","message":"recheck","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"},{"author":{"_account_id":36642,"name":"songjie","display_name":"Jie Song","email":"songjie_yewu@cmss.chinamobile.com","username":"songjie"},"change_message_id":"a805172aa2f7ef3373d8d94d5d77e4b576d45d09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5df361ed_f3ff6f28","updated":"2024-02-15 09:17:09.000000000","message":"recheck","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"},{"author":{"_account_id":36642,"name":"songjie","display_name":"Jie Song","email":"songjie_yewu@cmss.chinamobile.com","username":"songjie"},"change_message_id":"677bf1d35d7a679c0128cd9c2dfa31a6de428a70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a2748173_5f02888e","updated":"2024-02-15 02:36:43.000000000","message":"recheck","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9eeaab789a9d967ad1b34acd0228cd84fbd23f97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aadd708d_e990fdd3","updated":"2024-02-14 19:06:19.000000000","message":"recheck","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"2f0a504379d19acda3b3cad3e028ff1cd3a70a19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"082b7cf5_d1664d13","updated":"2023-12-29 01:44:23.000000000","message":"thanks!","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"},{"author":{"_account_id":36642,"name":"songjie","display_name":"Jie Song","email":"songjie_yewu@cmss.chinamobile.com","username":"songjie"},"change_message_id":"7e8fc3e4303183462f4885d66f59da9dd9adf20e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f41e220e_32878626","in_reply_to":"19476d17_a5f2e560","updated":"2024-01-11 09:51:11.000000000","message":"Hi, Sean. You can look at this again when you have time. Thank you.","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"},{"author":{"_account_id":36642,"name":"songjie","display_name":"Jie Song","email":"songjie_yewu@cmss.chinamobile.com","username":"songjie"},"change_message_id":"ea2db448d96f9d7bd294fe933b6ee0cd74117a7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"19476d17_a5f2e560","in_reply_to":"b929bb82_e07ab41c","updated":"2023-12-29 06:45:11.000000000","message":"Removing this enlightenment has no other negative sideeffects on windows vms running hyperv or wsl. It mainly works during vms migration.\n\n\u003e When reenlightenment is enabled, it provides several MSRs allowing the guest to get notified when TSC frequency changes (only happens on migration) and keep using old frequency (through emulation in the hypervisor) until it is ready to switch to the new one. This, in conjunction with hv-frequencies, allows Hyper-V on KVM to pass stable clocksource (Reference TSC page) to its own guests.\nhttps://www.qemu.org/docs/master/system/i386/hyperv.html","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"},{"author":{"_account_id":36642,"name":"songjie","display_name":"Jie Song","email":"songjie_yewu@cmss.chinamobile.com","username":"songjie"},"change_message_id":"d4952270b75ae689bf1543cfab725a36d5d2164b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1f340396_808163e0","in_reply_to":"dc9b6327_f1af8ff8","updated":"2024-01-12 00:50:32.000000000","message":"OK, thanks.","commit_id":"e618e78edc6293d248a5fa2eb63b3fa636250fca"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"35b74b3ebb1add3c18b5eadd21bb69a2d687d4e3","unresolved":true,"context_lines":[{"line_number":2421,"context_line":"            \u003cevmcs state\u003d\u0027on\u0027/\u003e"},{"line_number":2422,"context_line":"          \u003c/hyperv\u003e\"\"\")"},{"line_number":2423,"context_line":""},{"line_number":2424,"context_line":"    def test_feature_hyperv_enabled(self):"},{"line_number":2425,"context_line":""},{"line_number":2426,"context_line":"        obj \u003d config.LibvirtConfigGuestFeatureHyperV()"},{"line_number":2427,"context_line":"        obj.relaxed \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9121c21f_52363eb0","line":2424,"updated":"2023-12-28 16:31:16.000000000","message":"This test looks identical to the previous one, only with `reenlightenment` omitted, I\u0027m not sure it adds much value...","commit_id":"763fd9512daa7432616d93d525ec31c2dde98ea0"},{"author":{"_account_id":36642,"name":"songjie","display_name":"Jie Song","email":"songjie_yewu@cmss.chinamobile.com","username":"songjie"},"change_message_id":"9b435a6c917985d724dbcc8fa26b5689505ced7b","unresolved":false,"context_lines":[{"line_number":2421,"context_line":"            \u003cevmcs state\u003d\u0027on\u0027/\u003e"},{"line_number":2422,"context_line":"          \u003c/hyperv\u003e\"\"\")"},{"line_number":2423,"context_line":""},{"line_number":2424,"context_line":"    def test_feature_hyperv_enabled(self):"},{"line_number":2425,"context_line":""},{"line_number":2426,"context_line":"        obj \u003d config.LibvirtConfigGuestFeatureHyperV()"},{"line_number":2427,"context_line":"        obj.relaxed \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2407506_bed969a4","line":2424,"in_reply_to":"9121c21f_52363eb0","updated":"2023-12-29 06:19:02.000000000","message":"Done","commit_id":"763fd9512daa7432616d93d525ec31c2dde98ea0"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"35b74b3ebb1add3c18b5eadd21bb69a2d687d4e3","unresolved":true,"context_lines":[{"line_number":28050,"context_line":"        self.assertTrue(hv.frequencies)"},{"line_number":28051,"context_line":"        # NOTE(jie) reenlightenment will cause instances live-migration"},{"line_number":28052,"context_line":"        # failure, so don\u0027t enable it now. See bug 2046549."},{"line_number":28053,"context_line":"        self.assertFalse(hv.reenlightenment)"},{"line_number":28054,"context_line":"        self.assertTrue(hv.tlbflush)"},{"line_number":28055,"context_line":"        self.assertTrue(hv.ipi)"},{"line_number":28056,"context_line":"        self.assertTrue(hv.evmcs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"23340549_cd14d971","line":28053,"updated":"2023-12-28 16:31:16.000000000","message":"This is good, it tests the os_type\u003dwindows behaviour","commit_id":"763fd9512daa7432616d93d525ec31c2dde98ea0"},{"author":{"_account_id":36642,"name":"songjie","display_name":"Jie Song","email":"songjie_yewu@cmss.chinamobile.com","username":"songjie"},"change_message_id":"9b435a6c917985d724dbcc8fa26b5689505ced7b","unresolved":false,"context_lines":[{"line_number":28050,"context_line":"        self.assertTrue(hv.frequencies)"},{"line_number":28051,"context_line":"        # NOTE(jie) reenlightenment will cause instances live-migration"},{"line_number":28052,"context_line":"        # failure, so don\u0027t enable it now. See bug 2046549."},{"line_number":28053,"context_line":"        self.assertFalse(hv.reenlightenment)"},{"line_number":28054,"context_line":"        self.assertTrue(hv.tlbflush)"},{"line_number":28055,"context_line":"        self.assertTrue(hv.ipi)"},{"line_number":28056,"context_line":"        self.assertTrue(hv.evmcs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8d669cca_51559be2","line":28053,"in_reply_to":"23340549_cd14d971","updated":"2023-12-29 06:19:02.000000000","message":"Thanks.","commit_id":"763fd9512daa7432616d93d525ec31c2dde98ea0"}]}