)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"61f40a348697c43a4b8592c1fbfba5b061cc6c6e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change moves the console_script that do not"},{"line_number":10,"context_line":"require eventlets to a seperate bin dir."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This removes the unused eventlet monkey patching"},{"line_number":13,"context_line":"and allow us to split entrypoints based on there"},{"line_number":14,"context_line":"eventlet usage."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I721b77ef2d719f673ddccf935ff9b6cde18ce3fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"c0463ec9_2a44c715","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":15},"updated":"2024-05-03 10:08:33.000000000","message":"I don\u0027t see any removals going on here. Have I missed something?","commit_id":"8690cbb500d80f9647bc03696e136999558f4509"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b5ff7c9d8ef13f4494ae27dcd17556446e58fa5c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change moves the console_script that do not"},{"line_number":10,"context_line":"require eventlets to a seperate bin dir."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This removes the unused eventlet monkey patching"},{"line_number":13,"context_line":"and allow us to split entrypoints based on there"},{"line_number":14,"context_line":"eventlet usage."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I721b77ef2d719f673ddccf935ff9b6cde18ce3fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"4c656402_f25876b2","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":15},"in_reply_to":"c0463ec9_2a44c715","updated":"2024-06-21 14:16:10.000000000","message":"i discussed this ofline with stephen but tldr the monkey patchtich was done as a sidefect of __init__.py and by movign the script that was nolonger appliend\nthats what stephen missed for context\n\ni have slightly reworked how that works in the preceeding patch and i have refactored this one to be closer to the layout in neutron.","commit_id":"8690cbb500d80f9647bc03696e136999558f4509"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3c93dcd3f17585d7d9de01443226f44b65fa4023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"722ceb12_4d3f7e84","updated":"2023-12-30 16:09:54.000000000","message":"recheck unrelated vm delete timeout","commit_id":"45c5c660536c4dadd7689c32321e7140d5766ed4"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"72ca222ebdd5d41b04f0e8e40c5e2ae9be89d8e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"55f925e5_37d41da8","updated":"2024-01-26 09:26:09.000000000","message":"Nice, thanks","commit_id":"8738882501062e07fbcf6439b35fda1ac31e0b82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"61f40a348697c43a4b8592c1fbfba5b061cc6c6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7200585c_dcf47d4f","updated":"2024-05-03 10:08:33.000000000","message":"This doesn\u0027t seem to do anything bar move stuff around thus my question: do we need to do this? Couldn\u0027t we enforce \"no eventlet in these modules\" (a list that will presumably grow over time) via a simple hacking check?","commit_id":"8690cbb500d80f9647bc03696e136999558f4509"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7c6302f11178ec8488cc2393a963a72a4aa1bf83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e1754578_05974fd4","updated":"2024-08-26 13:44:13.000000000","message":"I think nova-manage still depends on scatter-gather and that still depends on eventlet.","commit_id":"b4e560473524570c2e90ae299b865ab00e06e012"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"3b706ac2d4a15142770829bc259c1618f4a0960e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ca65b4f4_2c37c373","updated":"2024-10-10 07:04:18.000000000","message":"@Sean: o/. Do you mean if I set the topic to \"eventlet-removal\" to also have your patches in the big picture?","commit_id":"61fedbb2217fd6a11b9317b1a15389cc3c3cd927"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"425889426f1aac445749a44c05710876262e0a15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1b01146c_797c45c0","in_reply_to":"ca65b4f4_2c37c373","updated":"2024-10-10 07:04:41.000000000","message":"s/mean/mind/","commit_id":"61fedbb2217fd6a11b9317b1a15389cc3c3cd927"}],"nova/cmd/standalone/manage.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7c6302f11178ec8488cc2393a963a72a4aa1bf83","unresolved":true,"context_lines":[{"line_number":2553,"context_line":"            cell_uuid, cn_host, cn_node \u003d self.cn_uuid_mapping[cn_uuid]"},{"line_number":2554,"context_line":"        else:"},{"line_number":2555,"context_line":"            # We need to find the compute node record from all cells."},{"line_number":2556,"context_line":"            results \u003d context.scatter_gather_skip_cell0("},{"line_number":2557,"context_line":"                ctxt, objects.ComputeNode.get_by_uuid, cn_uuid)"},{"line_number":2558,"context_line":"            for result_cell_uuid, result in results.items():"},{"line_number":2559,"context_line":"                if not context.is_cell_failure_sentinel(result):"}],"source_content_type":"text/x-python","patch_set":12,"id":"23f0285c_b41e6645","line":2556,"updated":"2024-08-26 13:44:13.000000000","message":"Those this still require eventlet or it is translated to native threading already?\n//later\n\nas far as I see this still uses eventlet https://github.com/openstack/nova/blob/3bdb298e685417ed0ecabbba12062d148ad58826/nova/context.py#L433-L437\n\nSo we cannot move this to the standalone module.","commit_id":"b4e560473524570c2e90ae299b865ab00e06e012"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d9586bca106e2c9bdbf8c58524c5deb166a204bd","unresolved":true,"context_lines":[{"line_number":2553,"context_line":"            cell_uuid, cn_host, cn_node \u003d self.cn_uuid_mapping[cn_uuid]"},{"line_number":2554,"context_line":"        else:"},{"line_number":2555,"context_line":"            # We need to find the compute node record from all cells."},{"line_number":2556,"context_line":"            results \u003d context.scatter_gather_skip_cell0("},{"line_number":2557,"context_line":"                ctxt, objects.ComputeNode.get_by_uuid, cn_uuid)"},{"line_number":2558,"context_line":"            for result_cell_uuid, result in results.items():"},{"line_number":2559,"context_line":"                if not context.is_cell_failure_sentinel(result):"}],"source_content_type":"text/x-python","patch_set":12,"id":"528bd551_30176566","line":2556,"in_reply_to":"23f0285c_b41e6645","updated":"2024-08-26 14:08:03.000000000","message":"You either pull https://review.opendev.org/c/openstack/nova/+/905284 before this patch, or change this patch to keep nova-manage in the eventlet group and only move it to standalon in or after https://review.opendev.org/c/openstack/nova/+/905284/6","commit_id":"b4e560473524570c2e90ae299b865ab00e06e012"}]}
