)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9fe740044d64da7d102669f72a6f43da3fa78239","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Amit Uniyal \u003cauniyal@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-17 04:54:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes bug 2048184"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"we only need to verify if bdm has attachment id and it should be present"},{"line_number":10,"context_line":"in both nova and cinde DB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"2396d885_7c4c1f3e","line":7,"updated":"2024-01-17 16:25:59.000000000","message":"This is not a reasonable summary line for this patch. This needs to say what it\u0027s fixing and not just a generic \"fixes bug\".","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"61810cd5d37951b6ad60a0c2ebb0d6f5258dbb1f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Amit Uniyal \u003cauniyal@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-17 04:54:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes bug 2048184"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"we only need to verify if bdm has attachment id and it should be present"},{"line_number":10,"context_line":"in both nova and cinde DB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"44133587_5dfc2042","line":7,"in_reply_to":"2396d885_7c4c1f3e","updated":"2024-01-18 06:51:55.000000000","message":"Done","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"bcc693036befd5bfb0a64af5f5992c0ddb06053b","unresolved":true,"context_lines":[{"line_number":12,"context_line":"For tests coverage, added tests for bfv server to test different bdm source"},{"line_number":13,"context_line":"type."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: 2048184"},{"line_number":16,"context_line":"Change-Id: Icffcbad27d99a800e3f285565c0b823f697e388c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"f14db26b_a167e9d8","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":19},"updated":"2024-01-17 10:29:53.000000000","message":"I think it also close 2048154, can you reference this bug as well.","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"61810cd5d37951b6ad60a0c2ebb0d6f5258dbb1f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"For tests coverage, added tests for bfv server to test different bdm source"},{"line_number":13,"context_line":"type."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: 2048184"},{"line_number":16,"context_line":"Change-Id: Icffcbad27d99a800e3f285565c0b823f697e388c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9060da5f_2769dbc8","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":19},"in_reply_to":"e693544c_01f361e3","updated":"2024-01-18 06:51:55.000000000","message":"Done","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"c042b29181681d1ff9f0b788763c15e794d2bbae","unresolved":true,"context_lines":[{"line_number":12,"context_line":"For tests coverage, added tests for bfv server to test different bdm source"},{"line_number":13,"context_line":"type."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: 2048184"},{"line_number":16,"context_line":"Change-Id: Icffcbad27d99a800e3f285565c0b823f697e388c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"e693544c_01f361e3","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":19},"in_reply_to":"f14db26b_a167e9d8","updated":"2024-01-17 10:49:29.000000000","message":"ack, will update","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e1ef73f14153588327affb1cfd49efa3dbd1cdfc","unresolved":true,"context_lines":[{"line_number":11,"context_line":"For tests coverage, added tests for bfv server to test different bdm source type."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 2048154"},{"line_number":14,"context_line":"Closes-Bug: 2048184"},{"line_number":15,"context_line":"Change-Id: Icffcbad27d99a800e3f285565c0b823f697e388c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"70affcab_4d39bdef","line":14,"updated":"2024-01-18 09:52:13.000000000","message":"we should close/duplicate that one but meh.","commit_id":"b5173b419219437b50f49c88bce9727ed0ed1ee8"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2d7569dc05e2cad947edab74949af0cd6ee10b27","unresolved":false,"context_lines":[{"line_number":11,"context_line":"For tests coverage, added tests for bfv server to test different bdm source type."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 2048154"},{"line_number":14,"context_line":"Closes-Bug: 2048184"},{"line_number":15,"context_line":"Change-Id: Icffcbad27d99a800e3f285565c0b823f697e388c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"f79e1564_fe365d4a","line":14,"in_reply_to":"70affcab_4d39bdef","updated":"2024-01-19 05:23:52.000000000","message":"Done","commit_id":"b5173b419219437b50f49c88bce9727ed0ed1ee8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"cdb023501ab8a311c82f2d798646ac091aac1add","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"65a1f051_73ca8d84","updated":"2024-01-17 15:23:08.000000000","message":"A slight but important detail as an empty string is even not needed","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"bcc693036befd5bfb0a64af5f5992c0ddb06053b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bd5cb31f_96a86d1c","updated":"2024-01-17 10:29:53.000000000","message":"Hi Amit, that looks good to me, it\u0027s great you manage to fix that quickly as it is annoying for users (see my comment about bug ref).\nLooking at the user bug, I was worried because I was unsure we cover all the source type possibilities. It is good you provide a check that should cover all of them.","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9fe740044d64da7d102669f72a6f43da3fa78239","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f7b75916_9433c03e","updated":"2024-01-17 16:25:59.000000000","message":"I haven\u0027t re-reviewed this, but I\u0027ve been seeing all the traffic in my mail. The subject for those mails is not very descriptive about what is being discussed because the summary line for this patch is *way* too generic. So please, fix that.","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"c042b29181681d1ff9f0b788763c15e794d2bbae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6cd4bb81_c882f2ee","updated":"2024-01-17 10:49:29.000000000","message":"replied on comment and will add other bug id in next resping, thanks for noticing and review","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"}],"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7997119a9473d227727a85d8766bda01c112c9e","unresolved":true,"context_lines":[{"line_number":4222,"context_line":"        nova_attachments \u003d []"},{"line_number":4223,"context_line":"        bdms_to_delete \u003d []"},{"line_number":4224,"context_line":"        for bdm in bdms.objects:"},{"line_number":4225,"context_line":"            if bdm.attachment_id:"},{"line_number":4226,"context_line":"                try:"},{"line_number":4227,"context_line":"                    self.volume_api.attachment_get(context, bdm.attachment_id)"},{"line_number":4228,"context_line":"                except exception.VolumeAttachmentNotFound:"}],"source_content_type":"text/x-python","patch_set":2,"id":"80efc046_0b9717d9","line":4225,"updated":"2024-01-06 13:07:14.000000000","message":"so on one hand yes we shoudl ahve an attachemnt id for all cinder volumes\n\nbut we shoudl also have and attachemtn id when\n\n```\n  if bdm.volume_id and bdm.source_type \u003d\u003d \u0027volume\u0027 and \\\n                bdm.destination_type \u003d\u003d \u0027volume\u0027:\n```\n\nis true\n\nby guess would be that  \"bdm.source_type \u003d\u003d \u0027volume\u0027\"  is the problem\n\nas that would fail to enter this if for voluems that are created form an image or snapshot\n\n\nthe valid values of source_type are \n\n```\nThe source type of the block device. Valid values are:\n\n    blank: Depending on the destination_type and guest_format, this will either be a blank persistent volume or an ephemeral (or swap) disk local to the compute host on which the server resides\n\n    image: This is only valid with destination_type\u003dvolume; creates an image-backed volume in the block storage service and attaches it to the server\n\n    snapshot: This is only valid with destination_type\u003dvolume; creates a volume backed by the given volume snapshot referenced via the block_device_mapping_v2.uuid parameter and attaches it to the server\n\n    volume: This is only valid with destination_type\u003dvolume; uses the existing persistent volume referenced via the block_device_mapping_v2.uuid parameter and attaches it to the server\n\nThis parameter is required unless block_device_mapping_v2.no_device is specified.\n\nSee Block Device Mapping in Nova for more details on valid source and destination types.\n```\n\nin this contenxt the source_type is not relevent so \n\nthis if could have been\n\n```\nif bdm.destination_type \u003d\u003d \u0027volume\u0027:\n```\n\ni guess\n\n```\nif bdm.attachment_id:\n```\n\nis similar","commit_id":"6244656b3ab49726c8b2ec18bf2c71fb9c4b32f7"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2d7569dc05e2cad947edab74949af0cd6ee10b27","unresolved":false,"context_lines":[{"line_number":4222,"context_line":"        nova_attachments \u003d []"},{"line_number":4223,"context_line":"        bdms_to_delete \u003d []"},{"line_number":4224,"context_line":"        for bdm in bdms.objects:"},{"line_number":4225,"context_line":"            if bdm.attachment_id:"},{"line_number":4226,"context_line":"                try:"},{"line_number":4227,"context_line":"                    self.volume_api.attachment_get(context, bdm.attachment_id)"},{"line_number":4228,"context_line":"                except exception.VolumeAttachmentNotFound:"}],"source_content_type":"text/x-python","patch_set":2,"id":"c6b2145f_9b3c4305","line":4225,"in_reply_to":"427517f9_27dd0983","updated":"2024-01-19 05:23:52.000000000","message":"Done","commit_id":"6244656b3ab49726c8b2ec18bf2c71fb9c4b32f7"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9597761f29a5ce7f8753793d0e554c15410ca65d","unresolved":true,"context_lines":[{"line_number":4222,"context_line":"        nova_attachments \u003d []"},{"line_number":4223,"context_line":"        bdms_to_delete \u003d []"},{"line_number":4224,"context_line":"        for bdm in bdms.objects:"},{"line_number":4225,"context_line":"            if bdm.attachment_id:"},{"line_number":4226,"context_line":"                try:"},{"line_number":4227,"context_line":"                    self.volume_api.attachment_get(context, bdm.attachment_id)"},{"line_number":4228,"context_line":"                except exception.VolumeAttachmentNotFound:"}],"source_content_type":"text/x-python","patch_set":2,"id":"427517f9_27dd0983","line":4225,"in_reply_to":"80efc046_0b9717d9","updated":"2024-01-17 10:56:19.000000000","message":"updated as bdm must have, bdm.volume_id and bdm.attachment_id","commit_id":"6244656b3ab49726c8b2ec18bf2c71fb9c4b32f7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"cdb023501ab8a311c82f2d798646ac091aac1add","unresolved":false,"context_lines":[{"line_number":4222,"context_line":"        nova_attachments \u003d []"},{"line_number":4223,"context_line":"        bdms_to_delete \u003d []"},{"line_number":4224,"context_line":"        for bdm in bdms.objects:"},{"line_number":4225,"context_line":"            if bdm.volume_id and bdm.attachment_id:"},{"line_number":4226,"context_line":"                try:"},{"line_number":4227,"context_line":"                    self.volume_api.attachment_get(context, bdm.attachment_id)"},{"line_number":4228,"context_line":"                except exception.VolumeAttachmentNotFound:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f98a3ea_15bb2893","line":4225,"updated":"2024-01-17 15:23:08.000000000","message":"ahah, I see, we were too restrictive (yeah we can create volumes from images)","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"}],"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"cdb023501ab8a311c82f2d798646ac091aac1add","unresolved":false,"context_lines":[{"line_number":703,"context_line":"            self.cinder.create_vol_attachment("},{"line_number":704,"context_line":"                volume_id, server[\u0027id\u0027])"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    def _create_server_boot_from_volume(self):"},{"line_number":707,"context_line":"        bfv_image_id \u003d uuids.bfv_image_uuid"},{"line_number":708,"context_line":"        timestamp \u003d datetime.datetime(2011, 1, 1, 1, 2, 3)"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"8781b4fc_129dc86e","line":706,"range":{"start_line":706,"start_character":8,"end_line":706,"end_character":39},"updated":"2024-01-17 15:23:08.000000000","message":"nit: technically, this is bfv from an image but OK.","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"bcc693036befd5bfb0a64af5f5992c0ddb06053b","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        self.glance.create(None, image)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        server \u003d self._build_server(image_uuid\u003d\u0027\u0027)"},{"line_number":726,"context_line":"        server[\u0027block_device_mapping_v2\u0027] \u003d [{"},{"line_number":727,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":728,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"d79448fc_65ec7993","line":725,"range":{"start_line":725,"start_character":47,"end_line":725,"end_character":49},"updated":"2024-01-17 10:29:53.000000000","message":"I would not pass the image_uuid parameter here as it is optional if we are using the block_device_mapping_v2, according to the doc.","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"61810cd5d37951b6ad60a0c2ebb0d6f5258dbb1f","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        self.glance.create(None, image)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        server \u003d self._build_server(image_uuid\u003d\u0027\u0027)"},{"line_number":726,"context_line":"        server[\u0027block_device_mapping_v2\u0027] \u003d [{"},{"line_number":727,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":728,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"10cca10a_691345a6","line":725,"range":{"start_line":725,"start_character":47,"end_line":725,"end_character":49},"in_reply_to":"0cdf0ee0_f720d061","updated":"2024-01-18 06:51:55.000000000","message":"thanks Rene, Sylvain, updated.","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2d7569dc05e2cad947edab74949af0cd6ee10b27","unresolved":false,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        self.glance.create(None, image)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        server \u003d self._build_server(image_uuid\u003d\u0027\u0027)"},{"line_number":726,"context_line":"        server[\u0027block_device_mapping_v2\u0027] \u003d [{"},{"line_number":727,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":728,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"30674902_9c5d46f0","line":725,"range":{"start_line":725,"start_character":47,"end_line":725,"end_character":49},"in_reply_to":"10cca10a_691345a6","updated":"2024-01-19 05:23:52.000000000","message":"Done","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"cdb023501ab8a311c82f2d798646ac091aac1add","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        self.glance.create(None, image)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        server \u003d self._build_server(image_uuid\u003d\u0027\u0027)"},{"line_number":726,"context_line":"        server[\u0027block_device_mapping_v2\u0027] \u003d [{"},{"line_number":727,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":728,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"f0a9f180_aa6265df","line":725,"range":{"start_line":725,"start_character":47,"end_line":725,"end_character":49},"in_reply_to":"22854bc1_796d1a1f","updated":"2024-01-17 15:23:08.000000000","message":"I agree with René, I\u0027d prefer that you generate the dict without passing an empty string and then you\u0027d just delete the imageRef attribute if you really want to make sure you boot from the volume.\n\nThe API reference is clear : imageRef isn\u0027t a required attribute : \n```\nThe UUID of the image to use for your server instance. This is not required in case of boot from volume. In all other cases it is required and must be a valid UUID otherwise API will return 400.\n```\nhttps://docs.openstack.org/api-ref/compute/#id11","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9597761f29a5ce7f8753793d0e554c15410ca65d","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        self.glance.create(None, image)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        server \u003d self._build_server(image_uuid\u003d\u0027\u0027)"},{"line_number":726,"context_line":"        server[\u0027block_device_mapping_v2\u0027] \u003d [{"},{"line_number":727,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":728,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffdd33b9_18e89458","line":725,"range":{"start_line":725,"start_character":47,"end_line":725,"end_character":49},"in_reply_to":"24197b2e_e1fb83ce","updated":"2024-01-17 10:56:19.000000000","message":"~~also~~ as we are creating a bfv server, so image id should remain \u0027\u0027.","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"c042b29181681d1ff9f0b788763c15e794d2bbae","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        self.glance.create(None, image)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        server \u003d self._build_server(image_uuid\u003d\u0027\u0027)"},{"line_number":726,"context_line":"        server[\u0027block_device_mapping_v2\u0027] \u003d [{"},{"line_number":727,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":728,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"24197b2e_e1fb83ce","line":725,"range":{"start_line":725,"start_character":47,"end_line":725,"end_character":49},"in_reply_to":"d79448fc_65ec7993","updated":"2024-01-17 10:49:29.000000000","message":"the build_server will set an image id if we do not provide one, that why we have to give an empty string arg here, also we are creating a bfv server, so image id will \n remain \u0027\u0027.","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a763cf48410bc66ea119475c5d89f3cded504e7d","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        self.glance.create(None, image)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        server \u003d self._build_server(image_uuid\u003d\u0027\u0027)"},{"line_number":726,"context_line":"        server[\u0027block_device_mapping_v2\u0027] \u003d [{"},{"line_number":727,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":728,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"0cdf0ee0_f720d061","line":725,"range":{"start_line":725,"start_character":47,"end_line":725,"end_character":49},"in_reply_to":"f0a9f180_aa6265df","updated":"2024-01-17 15:37:11.000000000","message":"A better alternative would be to use some kind of sentinel argument for image_id on _build_server that would explicitly mean that if None is passed as a value, we wouldn\u0027t add it in the returned dict.\n\nsome kind of thing like :  \n\n```\n _sentinel \u003d uuids.sentinel\n def mymethod(image_id\u003d_sentinel):\n    if image_id is not None:\n       if image_id is _sentinel:\n           \u003ctake the image id from the fixture\u003e\n       else:\n           returned_dict[imageRef] \u003d image_id\n```","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"ebadb0525b8d00636104092b89b9ab13707ff53d","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        self.glance.create(None, image)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        server \u003d self._build_server(image_uuid\u003d\u0027\u0027)"},{"line_number":726,"context_line":"        server[\u0027block_device_mapping_v2\u0027] \u003d [{"},{"line_number":727,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":728,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"22854bc1_796d1a1f","line":725,"range":{"start_line":725,"start_character":47,"end_line":725,"end_character":49},"in_reply_to":"ffdd33b9_18e89458","updated":"2024-01-17 13:50:25.000000000","message":"From the doc, I thought that whatever you pass to the image_uuid parameter will be ignored by the settings in block_device_mapping_v2. Is that not the case ?","commit_id":"eae66dab7db0b3127c00a39476c7d8e40570a254"}],"nova/tests/functional/test_boot_from_volume.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52190b24fcb6994dda35e2f20412714231b6aa32","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        volume_uuid \u003d nova_fixtures.CinderFixture.IMAGE_BACKED_VOL"},{"line_number":208,"context_line":"        bdm \u003d {\u0027boot_index\u0027: 0,"},{"line_number":209,"context_line":"               \u0027uuid\u0027: volume_uuid,"},{"line_number":210,"context_line":"               \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":211,"context_line":"               \u0027destination_type\u0027: \u0027volume\u0027}"},{"line_number":212,"context_line":"        _server[\u0027block_device_mapping_v2\u0027] \u003d [bdm]"},{"line_number":213,"context_line":"        server \u003d self.api.post_server({\"server\": _server})"}],"source_content_type":"text/x-python","patch_set":2,"id":"e7b7b8c5_c5e91413","line":210,"updated":"2024-01-06 13:10:28.000000000","message":"we shoudl check source_type: snapshot and source_type:image as well","commit_id":"6244656b3ab49726c8b2ec18bf2c71fb9c4b32f7"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9597761f29a5ce7f8753793d0e554c15410ca65d","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        volume_uuid \u003d nova_fixtures.CinderFixture.IMAGE_BACKED_VOL"},{"line_number":208,"context_line":"        bdm \u003d {\u0027boot_index\u0027: 0,"},{"line_number":209,"context_line":"               \u0027uuid\u0027: volume_uuid,"},{"line_number":210,"context_line":"               \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":211,"context_line":"               \u0027destination_type\u0027: \u0027volume\u0027}"},{"line_number":212,"context_line":"        _server[\u0027block_device_mapping_v2\u0027] \u003d [bdm]"},{"line_number":213,"context_line":"        server \u003d self.api.post_server({\"server\": _server})"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2b517b9_3ade79eb","line":210,"in_reply_to":"68d22bfb_c1cec702","updated":"2024-01-17 10:56:19.000000000","message":"Done, please have another look.","commit_id":"6244656b3ab49726c8b2ec18bf2c71fb9c4b32f7"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2d7569dc05e2cad947edab74949af0cd6ee10b27","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        volume_uuid \u003d nova_fixtures.CinderFixture.IMAGE_BACKED_VOL"},{"line_number":208,"context_line":"        bdm \u003d {\u0027boot_index\u0027: 0,"},{"line_number":209,"context_line":"               \u0027uuid\u0027: volume_uuid,"},{"line_number":210,"context_line":"               \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":211,"context_line":"               \u0027destination_type\u0027: \u0027volume\u0027}"},{"line_number":212,"context_line":"        _server[\u0027block_device_mapping_v2\u0027] \u003d [bdm]"},{"line_number":213,"context_line":"        server \u003d self.api.post_server({\"server\": _server})"}],"source_content_type":"text/x-python","patch_set":2,"id":"67b06573_6b3c0c5e","line":210,"in_reply_to":"a2b517b9_3ade79eb","updated":"2024-01-19 05:23:52.000000000","message":"Done","commit_id":"6244656b3ab49726c8b2ec18bf2c71fb9c4b32f7"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"ac8dc70fb3836bbf4a6bfbd9a89ad1ca13c16c2b","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        volume_uuid \u003d nova_fixtures.CinderFixture.IMAGE_BACKED_VOL"},{"line_number":208,"context_line":"        bdm \u003d {\u0027boot_index\u0027: 0,"},{"line_number":209,"context_line":"               \u0027uuid\u0027: volume_uuid,"},{"line_number":210,"context_line":"               \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":211,"context_line":"               \u0027destination_type\u0027: \u0027volume\u0027}"},{"line_number":212,"context_line":"        _server[\u0027block_device_mapping_v2\u0027] \u003d [bdm]"},{"line_number":213,"context_line":"        server \u003d self.api.post_server({\"server\": _server})"}],"source_content_type":"text/x-python","patch_set":2,"id":"68d22bfb_c1cec702","line":210,"in_reply_to":"e7b7b8c5_c5e91413","updated":"2024-01-13 14:51:36.000000000","message":"covered scenerios earlier in danling patch\n`\u0027source_type\u0027: \u0027image\u0027, \u0027destination_type\u0027: \u0027local\u0027,\n\u0027source_type\u0027: \u0027volume\u0027, \u0027destination_type\u0027: \u0027volume\u0027\n`\n\ncovered here: \n`\u0027source_type\u0027: \u0027image\u0027, \u0027destination_type\u0027: \u0027volume\u0027,`\n\nWIP patch\nsource_type: snapshot","commit_id":"6244656b3ab49726c8b2ec18bf2c71fb9c4b32f7"}]}