)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"30dd0d52433f581bc20ccad30e2ffcb08a340046","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a port of Ifb1c407df1f888c72e008578232d53a76b3d2e40"},{"line_number":10,"context_line":"to replace the use of eventlet in the nova api with"},{"line_number":11,"context_line":"futureist."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I63eeee3c4e9207e3869f3f40d43f1892c3c1f589"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8f3769_73979fad","line":11,"updated":"2024-01-11 08:45:40.000000000","message":"typos: \"futureist\" \"scater_gather\"","commit_id":"e13132ec8f471a74d352b2ac87a77f279034a11a"}],"nova/compute/multi_cell_list.py":[{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"30dd0d52433f581bc20ccad30e2ffcb08a340046","unresolved":true,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    if not eventletutils.is_monkey_patched(\u0027thread\u0027):"},{"line_number":105,"context_line":"        timer \u003d threading.Timer(context.CELL_TIMEOUT, timed_out)"},{"line_number":106,"context_line":"        timer.start()"},{"line_number":107,"context_line":"    else:"},{"line_number":108,"context_line":"        timer \u003d eventlet.timeout.Timeout("},{"line_number":109,"context_line":"            context.CELL_TIMEOUT, exception.CellTimeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ee5aaa8_5c9e1720","line":106,"updated":"2024-01-11 08:45:40.000000000","message":"Does this work in the way that we can catch the exception down below? I tried to reproduce it with https://paste.opendev.org/show/bNMRuKFEMVwVPlrTS59H/ but that just prints the traceback from another thread and continues on. \n\nAm I holding it wrong? How does that work?","commit_id":"e13132ec8f471a74d352b2ac87a77f279034a11a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e79e6abb882e59cefeae49e9cb4db3602a95c146","unresolved":true,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    if not eventletutils.is_monkey_patched(\u0027thread\u0027):"},{"line_number":105,"context_line":"        timer \u003d threading.Timer(context.CELL_TIMEOUT, timed_out)"},{"line_number":106,"context_line":"        timer.start()"},{"line_number":107,"context_line":"    else:"},{"line_number":108,"context_line":"        timer \u003d eventlet.timeout.Timeout("},{"line_number":109,"context_line":"            context.CELL_TIMEOUT, exception.CellTimeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ebd8972_37449611","line":106,"in_reply_to":"18f70023_dd12d069","updated":"2024-01-11 20:36:13.000000000","message":"Yeah, I think it would be best to move them into the try block. I used this example as a starting point https://eventlet.net/doc/modules/timeout.html#eventlet.timeout.Timeout and I wondered how it would work. I\u0027ll change that in my patch next time I respin.","commit_id":"e13132ec8f471a74d352b2ac87a77f279034a11a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a4bba1aa23809541fa6b3a1fd84c4e3a0817c614","unresolved":true,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    if not eventletutils.is_monkey_patched(\u0027thread\u0027):"},{"line_number":105,"context_line":"        timer \u003d threading.Timer(context.CELL_TIMEOUT, timed_out)"},{"line_number":106,"context_line":"        timer.start()"},{"line_number":107,"context_line":"    else:"},{"line_number":108,"context_line":"        timer \u003d eventlet.timeout.Timeout("},{"line_number":109,"context_line":"            context.CELL_TIMEOUT, exception.CellTimeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"18f70023_dd12d069","line":106,"in_reply_to":"1ee5aaa8_5c9e1720","updated":"2024-01-11 13:23:41.000000000","message":"im not sure it will be caught without moving the start into the try\n\nso ya i think ill move the if else into the try block.\n\nit might work but this is something i need to chack more closely thanks for highlighting it.","commit_id":"e13132ec8f471a74d352b2ac87a77f279034a11a"}]}