)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6faff055a03cd3ea5704e457c2f8f7936bcc1caa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"31406e47_c3cbd156","line":13,"updated":"2025-04-28 22:54:57.000000000","message":"i have not reviewed this properly but yes we shoudl have remvod this a long time ago so +1 for doing the clean up\n\nill try and loop back to this again during the week","commit_id":"c8762acaa89a25026c03e730395ab6179bcf3be7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c150db4df543fb654466ca3a5a1f1e278288c739","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"32397508_0a24eaa1","updated":"2024-01-12 17:25:44.000000000","message":"i think this makes sense to remove at this point","commit_id":"6b1aab15820be9dfa1f3e857f07c726b3324d085"}],"nova/conductor/tasks/live_migrate.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c150db4df543fb654466ca3a5a1f1e278288c739","unresolved":true,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        raise exception.MigrationPreCheckError("},{"line_number":207,"context_line":"            reason\u003d\u0027Instance has an associated NUMA topology, cell \u0027"},{"line_number":208,"context_line":"                   \u0027contains compute nodes older than train\u0027)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def _check_can_migrate_pci(self, src_host, dest_host):"},{"line_number":211,"context_line":"        \"\"\"Checks that an instance can migrate with PCI requests."}],"source_content_type":"text/x-python","patch_set":3,"id":"502359b2_95661ebc","line":208,"updated":"2024-01-12 17:25:44.000000000","message":"personally i would also include\n\n                       \u0027Refusing to perform the live migration, as the \u0027\n                       \u0027instance NUMA topology, including related attributes \u0027\n                       \u0027such as CPU pinning, huge page and emulator thread \u0027\n                       \u0027pinning information, cannot be recalculated. See \u0027\n                       \u0027bug #1289064 for more information.\u0027)","commit_id":"6b1aab15820be9dfa1f3e857f07c726b3324d085"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d8ee41e00ff03d5e1ae10b2ac3ae1723a70f337b","unresolved":true,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        raise exception.MigrationPreCheckError("},{"line_number":207,"context_line":"            reason\u003d\u0027Instance has an associated NUMA topology, cell \u0027"},{"line_number":208,"context_line":"                   \u0027contains compute nodes older than train\u0027)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def _check_can_migrate_pci(self, src_host, dest_host):"},{"line_number":211,"context_line":"        \"\"\"Checks that an instance can migrate with PCI requests."}],"source_content_type":"text/x-python","patch_set":3,"id":"84d7fa0f_c4da1889","line":208,"in_reply_to":"502359b2_95661ebc","updated":"2025-04-25 19:53:09.000000000","message":"I agree I think it would be best to keep useful information in the exception message. On its own, \"contains compute nodes older than train\" doesn\u0027t really explain anything about why that\u0027s a problem. The counterargument is I guess the low probability anyone will see the message -- although if we are bothering to keep the exception at all, that implies we expect someone could see it.","commit_id":"6b1aab15820be9dfa1f3e857f07c726b3324d085"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"6dd0c25fe928873247c5cbb9e4b66fbd15f934e1","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        raise exception.MigrationPreCheckError("},{"line_number":207,"context_line":"            reason\u003d\u0027Instance has an associated NUMA topology, cell \u0027"},{"line_number":208,"context_line":"                   \u0027contains compute nodes older than train\u0027)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def _check_can_migrate_pci(self, src_host, dest_host):"},{"line_number":211,"context_line":"        \"\"\"Checks that an instance can migrate with PCI requests."}],"source_content_type":"text/x-python","patch_set":3,"id":"ea655aa4_c98f04b3","line":208,"in_reply_to":"84d7fa0f_c4da1889","updated":"2025-04-28 21:50:23.000000000","message":"Done","commit_id":"6b1aab15820be9dfa1f3e857f07c726b3324d085"}]}