)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a6a3911731929d218a674aaaa010d245682d1ab9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"disk.  This is because the correct block_device_info dict that"},{"line_number":15,"context_line":"is passed to the compute manager\u0027s reboot_instance method does"},{"line_number":16,"context_line":"not contain swap or ephemeral disk key values that are necessary"},{"line_number":17,"context_line":"to recrate those disks.  This patch updates"},{"line_number":18,"context_line":"_get_instance_volume_block_device_info to return the swap and"},{"line_number":19,"context_line":"ephemeral disk key values, in addition to the block_device_mapping"},{"line_number":20,"context_line":"it already returns today."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAXX%2F%2Fw5g%3D","line":17,"updated":"2014-04-28 06:17:51.000000000","message":"recreate","commit_id":"3350e646add82ed1b0bd6c582972df46199b299f"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"d520c5c7955ce1092063eb30869d7c8f663ef90e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"disk.  This is because the correct block_device_info dict that"},{"line_number":15,"context_line":"is passed to the compute manager\u0027s reboot_instance method does"},{"line_number":16,"context_line":"not contain swap or ephemeral disk key values that are necessary"},{"line_number":17,"context_line":"to recrate those disks.  This patch updates"},{"line_number":18,"context_line":"_get_instance_volume_block_device_info to return the swap and"},{"line_number":19,"context_line":"ephemeral disk key values, in addition to the block_device_mapping"},{"line_number":20,"context_line":"it already returns today."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAXX%2F%2FuKY%3D","line":17,"in_reply_to":"AAAAXX%2F%2Fw5g%3D","updated":"2014-04-28 13:34:19.000000000","message":"Done","commit_id":"3350e646add82ed1b0bd6c582972df46199b299f"}],"nova/compute/manager.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a6a3911731929d218a674aaaa010d245682d1ab9","unresolved":false,"context_lines":[{"line_number":1845,"context_line":""},{"line_number":1846,"context_line":"        return {\u0027swap\u0027: swap,"},{"line_number":1847,"context_line":"                \u0027ephemerals\u0027: ephemerals,"},{"line_number":1848,"context_line":"                \u0027block_device_mapping\u0027: block_device_mapping}"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"    # NOTE(mikal): No object_compat wrapper on this method because its"},{"line_number":1851,"context_line":"    # callers all pass objects already"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2Fw5o%3D","line":1848,"updated":"2014-04-28 06:17:51.000000000","message":"should we add some type of exception handling like we \ndid in _prep_block_device? or should we consider combine those two functions ?looks to me most of them are trying to get block device info and almost same (of course, not mandatory, only discussion :)","commit_id":"3350e646add82ed1b0bd6c582972df46199b299f"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"d520c5c7955ce1092063eb30869d7c8f663ef90e","unresolved":false,"context_lines":[{"line_number":1845,"context_line":""},{"line_number":1846,"context_line":"        return {\u0027swap\u0027: swap,"},{"line_number":1847,"context_line":"                \u0027ephemerals\u0027: ephemerals,"},{"line_number":1848,"context_line":"                \u0027block_device_mapping\u0027: block_device_mapping}"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"    # NOTE(mikal): No object_compat wrapper on this method because its"},{"line_number":1851,"context_line":"    # callers all pass objects already"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2FuDU%3D","line":1848,"in_reply_to":"AAAAXX%2F%2Fw5o%3D","updated":"2014-04-28 13:34:19.000000000","message":"It is not entirely the same.  This function queries bdms using block_device_obj.BlockDeviceMappingList.get_by_instance_uuid.  _prep_block_device attaches the volumes in addition to querying bdms (with driver_block_device.attach_block_devices), so they cannot be combined.  Also, there are no exceptions thrown by the methods used here (at least from what I saw), hence no exception handling.","commit_id":"3350e646add82ed1b0bd6c582972df46199b299f"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"013b16197243801ddbdb5ad146e30e1a31344f22","unresolved":false,"context_lines":[{"line_number":1808,"context_line":"        self.network_api.deallocate_for_instance("},{"line_number":1809,"context_line":"            context, instance, requested_networks\u003drequested_networks)"},{"line_number":1810,"context_line":""},{"line_number":1811,"context_line":"    def _get_instance_volume_block_device_info(self, context, instance,"},{"line_number":1812,"context_line":"                                               refresh_conn_info\u003dFalse,"},{"line_number":1813,"context_line":"                                               bdms\u003dNone):"},{"line_number":1814,"context_line":"        \"\"\"Transform volumes to the driver block_device format.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXX%2F%2Ftp8%3D","line":1811,"updated":"2014-04-28 14:24:21.000000000","message":"Well at this point the name is misleading so we need to change it too.","commit_id":"b2927e3b2c4901867c63acd8314ae78fa74c8401"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"5425568328b4120cd1c9c5a46247cd1ad6ba5e2d","unresolved":false,"context_lines":[{"line_number":1808,"context_line":"        self.network_api.deallocate_for_instance("},{"line_number":1809,"context_line":"            context, instance, requested_networks\u003drequested_networks)"},{"line_number":1810,"context_line":""},{"line_number":1811,"context_line":"    def _get_instance_volume_block_device_info(self, context, instance,"},{"line_number":1812,"context_line":"                                               refresh_conn_info\u003dFalse,"},{"line_number":1813,"context_line":"                                               bdms\u003dNone):"},{"line_number":1814,"context_line":"        \"\"\"Transform volumes to the driver block_device format.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1371a2_87c0e87d","line":1811,"in_reply_to":"AAAAXX%2F%2Ftp8%3D","updated":"2014-04-28 19:32:56.000000000","message":"Done","commit_id":"b2927e3b2c4901867c63acd8314ae78fa74c8401"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f161125b0665ac483b31f80328323e005ba323fc","unresolved":false,"context_lines":[{"line_number":1810,"context_line":"    def _get_instance_block_device_info(self, context, instance,"},{"line_number":1811,"context_line":"                                        refresh_conn_info\u003dFalse,"},{"line_number":1812,"context_line":"                                        bdms\u003dNone):"},{"line_number":1813,"context_line":"        \"\"\"Transform volumes to the driver block_device format.\"\"\""},{"line_number":1814,"context_line":""},{"line_number":1815,"context_line":"        if not bdms:"},{"line_number":1816,"context_line":"            bdms \u003d (block_device_obj.BlockDeviceMappingList."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_dd9a6862","line":1813,"updated":"2014-05-05 19:09:17.000000000","message":"Might be worth changing the word \"volume\" to \"block devices\" to make it more clear that not just Cinder volumes are being returned, but ephemerals, too","commit_id":"f087a6f77ef1338bb8d10943d2a18712220c3c44"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f161125b0665ac483b31f80328323e005ba323fc","unresolved":false,"context_lines":[{"line_number":1840,"context_line":"                block_device_mapping)"},{"line_number":1841,"context_line":""},{"line_number":1842,"context_line":"        # Get swap out of the list"},{"line_number":1843,"context_line":"        swap \u003d driver_block_device.get_swap(swap)"},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"        return {\u0027swap\u0027: swap,"},{"line_number":1846,"context_line":"                \u0027ephemerals\u0027: ephemerals,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_84b96417","line":1843,"updated":"2014-05-05 19:09:17.000000000","message":"The get_swap() method is absurdly named, IMO, but whatever...","commit_id":"f087a6f77ef1338bb8d10943d2a18712220c3c44"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a5391b289264422de1efe91984da597226ad546e","unresolved":false,"context_lines":[{"line_number":2657,"context_line":""},{"line_number":2658,"context_line":"            mock_get_by_instance_uuid.assert_called_once_with(self.context,"},{"line_number":2659,"context_line":"                                                              instance.uuid)"},{"line_number":2660,"context_line":"            self.assertEqual(block_device_info, expected_block_device_info)"},{"line_number":2661,"context_line":""},{"line_number":2662,"context_line":"    def test_set_admin_password(self):"},{"line_number":2663,"context_line":"        # Ensure instance can have its admin password set."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2Fy6k%3D","line":2660,"updated":"2014-04-27 06:39:15.000000000","message":"the expected should be the first parameter","commit_id":"7b0d95f5cb86e1425d9e61ed6427ae7dab1981aa"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"6df7e76cfeee8317f4ad28939fd1fe44377b7940","unresolved":false,"context_lines":[{"line_number":2657,"context_line":""},{"line_number":2658,"context_line":"            mock_get_by_instance_uuid.assert_called_once_with(self.context,"},{"line_number":2659,"context_line":"                                                              instance.uuid)"},{"line_number":2660,"context_line":"            self.assertEqual(block_device_info, expected_block_device_info)"},{"line_number":2661,"context_line":""},{"line_number":2662,"context_line":"    def test_set_admin_password(self):"},{"line_number":2663,"context_line":"        # Ensure instance can have its admin password set."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2FyRo%3D","line":2660,"in_reply_to":"AAAAXX%2F%2Fy6k%3D","updated":"2014-04-27 16:45:13.000000000","message":"Done","commit_id":"7b0d95f5cb86e1425d9e61ed6427ae7dab1981aa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f161125b0665ac483b31f80328323e005ba323fc","unresolved":false,"context_lines":[{"line_number":2657,"context_line":""},{"line_number":2658,"context_line":"            mock_get_by_instance_uuid.assert_called_once_with(self.context,"},{"line_number":2659,"context_line":"                                                              instance.uuid)"},{"line_number":2660,"context_line":"            self.assertEqual(expected_block_device_info, block_device_info)"},{"line_number":2661,"context_line":""},{"line_number":2662,"context_line":"    def test_set_admin_password(self):"},{"line_number":2663,"context_line":"        # Ensure instance can have its admin password set."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_0413940d","line":2660,"updated":"2014-05-05 19:09:17.000000000","message":"The above is good, but I\u0027d like to see a test when there are \u003e1 ephemeral (but not swap) disks in the BDM....","commit_id":"f087a6f77ef1338bb8d10943d2a18712220c3c44"}]}