)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"85f607f0a3be7032d6d3bd409457a6a63b929329","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a55a8555_f20c2c45","updated":"2024-01-29 09:35:10.000000000","message":"can you please add an regression test as well.","commit_id":"7af42d116d29a5d41e0c1f6b7fb5e2d91b1ad82e"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"4c818297ac011323626250726e66321314e9c1d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1eef4444_e5f6e52f","in_reply_to":"a55a8555_f20c2c45","updated":"2024-02-04 02:23:44.000000000","message":"Done","commit_id":"7af42d116d29a5d41e0c1f6b7fb5e2d91b1ad82e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"c0ece8e3f21786db47cf9a536b2bd3df6ff27fcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4fdeb038_e4d3b306","updated":"2024-01-30 07:40:14.000000000","message":"it is a possible bug but I could not reproduce this locally.\nit may be because I could not test with image which actually has/required min_ram more then 512MB, so just updated image min-ram property manually while creating image and I was able to resize bfv server.\n\nwill it be possible for you to share or provide a downloadable link of image you used.\n\nthanks.","commit_id":"479c0f76016a732e29559b7300baaab4cb95a60c"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"4c818297ac011323626250726e66321314e9c1d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ba5838e_0e880880","in_reply_to":"4fdeb038_e4d3b306","updated":"2024-02-04 02:23:44.000000000","message":"I don\u0027t have a specific image to cause OS system exceptions, as most distributions optimize memory mechanisms. However, if an image runs some applications, what I can ensure is that if the memory given to the instance is very small like 512MB, it is not enough for these applications to run, which can lead to applications being killed by OOM.","commit_id":"479c0f76016a732e29559b7300baaab4cb95a60c"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"323de92b5f4582bec85f5824c2e711b00991be26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"64b00672_126feb6c","updated":"2024-02-04 10:03:26.000000000","message":"recheck","commit_id":"ab244c542bfe762eb37fc393e9b964fb070078e2"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"79af50dc8733b20cd8d6886c6839d022c9a6676d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7c011d04_ba9d9d84","updated":"2024-02-04 13:37:05.000000000","message":"recheck setup_evacuate_resources","commit_id":"ab244c542bfe762eb37fc393e9b964fb070078e2"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"982f7d766490fd748a7ddd07e01d6ae8947e0552","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"474c4706_af202ff5","updated":"2024-03-01 06:32:58.000000000","message":"Hi, \nplease help me review the fix, thanks!","commit_id":"6a82abf95af4ef204b8c859a75d3c3d2fb4c658e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"53795ff3cdbe5ac62e2af19d29a6a310d6ac1714","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1491ddaa_c6c6e649","updated":"2024-04-17 19:26:19.000000000","message":"I tried testing it locally, on calling every API got `[ERROR] Unhandled object from iterator: \u0027Out of date osapi_compute service This service is older (v66) than the minimum (v67) version of the rest of the deployment. Unable to continue.\\n\u0027`\nbecause your change is not rebased see here https://github.com/openstack/nova/blame/master/nova/objects/service.py#L33 there is a version change.\n\nalso its not rebased with your regression patch too, which means latest changes of https://review.opendev.org/c/openstack/nova/+/907642 are not reflected here.\n\nchange works fine after version is fixed.","commit_id":"6a82abf95af4ef204b8c859a75d3c3d2fb4c658e"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"30a02d8545ba204205f5d57db874714e9c565abf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"38afa6d1_16fe0d23","in_reply_to":"1491ddaa_c6c6e649","updated":"2024-04-18 03:02:21.000000000","message":"Done","commit_id":"6a82abf95af4ef204b8c859a75d3c3d2fb4c658e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3a9fdc4177fc651aaa437db1c448c8d99b31de9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"641b4c49_be9058a5","updated":"2024-04-18 12:45:52.000000000","message":"+1 same quetion as the reproducer\ndoes this also affect non boot form volume insntaces\nif it does i would like to see test coverage for both but overall i think this looks good.\n\nyou could add a short \"fixes\" release not but its not strictly required.","commit_id":"f3eb76e57b8cafaeb892366550dc6bfaa4d2b4bb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"42535b0e1213399789b5e432a069376410b71d6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d7b8b808_5fa3bd3f","updated":"2024-04-19 21:10:42.000000000","message":"LGTM, thanks","commit_id":"f3eb76e57b8cafaeb892366550dc6bfaa4d2b4bb"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"5dbdc142057dde5bf1dfc53c05b1a8bbc611356f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b3d3725a_47a802ba","updated":"2024-04-18 04:07:00.000000000","message":"lgtm","commit_id":"f3eb76e57b8cafaeb892366550dc6bfaa4d2b4bb"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"93b05e53280f2ef208f8c89237238b0997fe7bad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"68f42bc6_69cc7722","updated":"2024-04-18 06:19:47.000000000","message":"recheck","commit_id":"f3eb76e57b8cafaeb892366550dc6bfaa4d2b4bb"}],"nova/compute/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3140b8d3b3ddbf95efd2a74e7daecc787cf8851","unresolved":true,"context_lines":[{"line_number":4269,"context_line":"            if volume_backed:"},{"line_number":4270,"context_line":"                self._validate_flavor_image_numa_pci("},{"line_number":4271,"context_line":"                    image, new_flavor, validate_pci\u003dTrue)"},{"line_number":4272,"context_line":"                if new_flavor[\u0027memory_mb\u0027] \u003c int(image.get(\u0027min_ram\u0027) or 0):"},{"line_number":4273,"context_line":"                    raise exception.FlavorMemoryTooSmall()"},{"line_number":4274,"context_line":"            else:"},{"line_number":4275,"context_line":"                self._validate_flavor_image_nostatus("}],"source_content_type":"text/x-python","patch_set":2,"id":"f69a8da1_b970e3fe","line":4272,"updated":"2024-02-01 12:36:41.000000000","message":"in additon to the fucntional test plase add a unit test for this\n\nalso i belive you can do image.get(\u0027min_ram\u0027, 0)","commit_id":"479c0f76016a732e29559b7300baaab4cb95a60c"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"4c818297ac011323626250726e66321314e9c1d0","unresolved":false,"context_lines":[{"line_number":4269,"context_line":"            if volume_backed:"},{"line_number":4270,"context_line":"                self._validate_flavor_image_numa_pci("},{"line_number":4271,"context_line":"                    image, new_flavor, validate_pci\u003dTrue)"},{"line_number":4272,"context_line":"                if new_flavor[\u0027memory_mb\u0027] \u003c int(image.get(\u0027min_ram\u0027) or 0):"},{"line_number":4273,"context_line":"                    raise exception.FlavorMemoryTooSmall()"},{"line_number":4274,"context_line":"            else:"},{"line_number":4275,"context_line":"                self._validate_flavor_image_nostatus("}],"source_content_type":"text/x-python","patch_set":2,"id":"8e27021a_82f5e5ed","line":4272,"in_reply_to":"f69a8da1_b970e3fe","updated":"2024-02-04 02:23:44.000000000","message":"Done","commit_id":"479c0f76016a732e29559b7300baaab4cb95a60c"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"53795ff3cdbe5ac62e2af19d29a6a310d6ac1714","unresolved":false,"context_lines":[{"line_number":4272,"context_line":"                # The server that image-backed already has the verification of"},{"line_number":4273,"context_line":"                # image min_ram when calling _validate_flavor_image_nostatus."},{"line_number":4274,"context_line":"                # Here, the verification is added for the server that"},{"line_number":4275,"context_line":"                # volume-backed."},{"line_number":4276,"context_line":"                if new_flavor[\u0027memory_mb\u0027] \u003c int(image.get(\u0027min_ram\u0027, 0)):"},{"line_number":4277,"context_line":"                    raise exception.FlavorMemoryTooSmall()"},{"line_number":4278,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"d3eada19_4d00a3c3","line":4275,"updated":"2024-04-17 19:26:19.000000000","message":"ack","commit_id":"6a82abf95af4ef204b8c859a75d3c3d2fb4c658e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"42535b0e1213399789b5e432a069376410b71d6f","unresolved":true,"context_lines":[{"line_number":4272,"context_line":"                # The server that image-backed already has the verification of"},{"line_number":4273,"context_line":"                # image min_ram when calling _validate_flavor_image_nostatus."},{"line_number":4274,"context_line":"                # Here, the verification is added for the server that"},{"line_number":4275,"context_line":"                # volume-backed."},{"line_number":4276,"context_line":"                if new_flavor[\u0027memory_mb\u0027] \u003c int(image.get(\u0027min_ram\u0027, 0)):"},{"line_number":4277,"context_line":"                    raise exception.FlavorMemoryTooSmall()"},{"line_number":4278,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9d2bf851_82e89fe2","line":4275,"updated":"2024-04-19 21:10:42.000000000","message":"++ thanks for including a code comment","commit_id":"f3eb76e57b8cafaeb892366550dc6bfaa4d2b4bb"}],"nova/objects/service.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"53795ff3cdbe5ac62e2af19d29a6a310d6ac1714","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# NOTE(danms): This is the global service version counter"},{"line_number":34,"context_line":"SERVICE_VERSION \u003d 66"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# NOTE(danms): This is our SERVICE_VERSION history. The idea is that any"},{"line_number":38,"context_line":"# time we bump the version, we will put an entry here to record the change,"}],"source_content_type":"text/x-python","patch_set":10,"id":"4ea5d1da_894998e3","line":35,"updated":"2024-04-17 19:26:19.000000000","message":"here.","commit_id":"6a82abf95af4ef204b8c859a75d3c3d2fb4c658e"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"30a02d8545ba204205f5d57db874714e9c565abf","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# NOTE(danms): This is the global service version counter"},{"line_number":34,"context_line":"SERVICE_VERSION \u003d 66"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# NOTE(danms): This is our SERVICE_VERSION history. The idea is that any"},{"line_number":38,"context_line":"# time we bump the version, we will put an entry here to record the change,"}],"source_content_type":"text/x-python","patch_set":10,"id":"d7556fb2_5af3e68e","line":35,"in_reply_to":"4ea5d1da_894998e3","updated":"2024-04-18 03:02:21.000000000","message":"Done","commit_id":"6a82abf95af4ef204b8c859a75d3c3d2fb4c658e"}],"nova/tests/functional/regressions/test_bug_2007968.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3140b8d3b3ddbf95efd2a74e7daecc787cf8851","unresolved":true,"context_lines":[{"line_number":14,"context_line":"from nova.tests.functional import integrated_helpers"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Bug2007968RegressionTest("},{"line_number":18,"context_line":"    test.TestCase, integrated_helpers.InstanceHelperMixin):"},{"line_number":19,"context_line":"    \"\"\"Regression test for bug 2007968"},{"line_number":20,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1b2a84_19707a9a","line":17,"updated":"2024-02-01 12:36:41.000000000","message":"you shoudl create the repdouce test in a seperate review demonstrating the bug\nand asset th the  resize is allow to get to the resize verify state.\n\nthen in this patch update it to show that your patch now fixes the error.\n\ncan you refactor this into two patches and make that change","commit_id":"479c0f76016a732e29559b7300baaab4cb95a60c"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"4c818297ac011323626250726e66321314e9c1d0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from nova.tests.functional import integrated_helpers"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Bug2007968RegressionTest("},{"line_number":18,"context_line":"    test.TestCase, integrated_helpers.InstanceHelperMixin):"},{"line_number":19,"context_line":"    \"\"\"Regression test for bug 2007968"},{"line_number":20,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"57279fa2_3201d084","line":17,"in_reply_to":"1a1b2a84_19707a9a","updated":"2024-02-04 02:23:44.000000000","message":"Done，reproduce test at https://review.opendev.org/c/openstack/nova/+/907642","commit_id":"479c0f76016a732e29559b7300baaab4cb95a60c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3a9fdc4177fc651aaa437db1c448c8d99b31de9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # and will not continue the resize."},{"line_number":63,"context_line":"        ex \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":64,"context_line":"                               self._resize_server, server, new_flavor)"},{"line_number":65,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":66,"context_line":"        self.assertIn(\u0027Flavor\\\u0027s memory is too small for requested image.\u0027,"},{"line_number":67,"context_line":"                      ex.response.text)"}],"source_content_type":"text/x-python","patch_set":12,"id":"cd1c31ff_bd6cef7a","line":65,"updated":"2024-04-18 12:45:52.000000000","message":"i agree that a 400 bad request is approate in this case.\n409 would have alos been correct for FlavorMemoryTooSmall but you are not addign that expcetion you are just using it so we should not change it.","commit_id":"f3eb76e57b8cafaeb892366550dc6bfaa4d2b4bb"}]}