)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"584e6f2398e9b69cf944ef7e1ecd4441079c6b84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fdaf78a9_071e107a","updated":"2024-02-13 11:06:34.000000000","message":"i have some nits inline but i think this is gereally in a good state\n\nill try and loop back to this again later in the week","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"762521100dd4a2bb5c68ad3abcdb670392f2621b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"243b1f93_eac57a8b","updated":"2024-02-14 10:16:17.000000000","message":"Hi, thanks for the review.\nI have responded to all comments.\nPlease see the new patch.","commit_id":"85069325ac49cbfa3d2b8bec97858c26e8599925"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7a6079829322092921db6fde15837a7bcf91ba5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7449ab3_3c959f24","updated":"2024-02-26 17:39:37.000000000","message":"Pretty rock solid but lacking a few unittests. I\u0027d appreciate if you could provide either a revision or a follow-up patch with the required additions before I could turn my vote into +2.\nAs a reminder, Thursday is Feature Freeze so I\u0027d appreciate if you could communicate to me if you can\u0027t provide such changes before that date, so I could reevaluate my opinion.","commit_id":"14c3c5fa4d7285c22ea71d13dd337c37c3e742e8"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"36122ec72b192d0af29be2fdf23d7f6874509ea9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cee7b168_9feb375e","in_reply_to":"a7449ab3_3c959f24","updated":"2024-02-27 05:25:02.000000000","message":"Thanks for the review! I submitted patchset 4 with fixes.","commit_id":"14c3c5fa4d7285c22ea71d13dd337c37c3e742e8"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"10cc4c4ed6281966eb5ab886e5522609afb9b90f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"962d73b7_10ef3146","updated":"2024-02-28 01:47:01.000000000","message":"recheck unrelated failure tempest.api.volume.test_volumes_actions.VolumesActionsTest.test_volume_upload","commit_id":"1038a633870b24b2409205cc3c5fe066442dd49f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"099cfac71ef45843531a63cf8ba0912e5ae2efbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"22925aad_ff00e1ef","updated":"2024-02-27 10:59:05.000000000","message":"thanks !","commit_id":"1038a633870b24b2409205cc3c5fe066442dd49f"}],"nova/scheduler/filters/compute_capabilities_filter.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"584e6f2398e9b69cf944ef7e1ecd4441079c6b84","unresolved":true,"context_lines":[{"line_number":76,"context_line":"            # Replace it with a capabilities filter specially."},{"line_number":77,"context_line":"            if key \u003d\u003d \u0027hw:maxphysaddr_bits\u0027:"},{"line_number":78,"context_line":"                key \u003d \u0027capabilities:cpu_info:maxphysaddr:bits\u0027"},{"line_number":79,"context_line":"                req \u003d \u0027\u003e\u003d \u0027 + req"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"            # Either not scope format, or in capabilities scope"},{"line_number":82,"context_line":"            scope \u003d key.split(\u0027:\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bbac6e60_c69d61c0","line":79,"updated":"2024-02-13 11:06:34.000000000","message":"with out testing this locally this looks suspious to me as i woudl expet those assignments to modify the flavor.extra_specs\n\n\u003e\u003e\u003e data \u003d {\u0027key_1\u0027: 42, \u0027key_2\u0027: 100}\n\u003e\u003e\u003e for k, v in data.items():\n...   if k \u003d\u003d \u0027key_2\u0027:\n...     k\u003d\u0027currpt\u0027\n...     v\u003dk\n... \n\u003e\u003e\u003e data\n{\u0027key_1\u0027: 42, \u0027key_2\u0027: 100}\n\ninstead they are jut rebindign the key and req names to point at diffent data within the body of the loop.\n\ni guess this is ok but its not intuitive.","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66903524eb68f966bc03a9c1c192b6e4a5786906","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            # Replace it with a capabilities filter specially."},{"line_number":77,"context_line":"            if key \u003d\u003d \u0027hw:maxphysaddr_bits\u0027:"},{"line_number":78,"context_line":"                key \u003d \u0027capabilities:cpu_info:maxphysaddr:bits\u0027"},{"line_number":79,"context_line":"                req \u003d \u0027\u003e\u003d \u0027 + req"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"            # Either not scope format, or in capabilities scope"},{"line_number":82,"context_line":"            scope \u003d key.split(\u0027:\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7b691b1_df603b9f","line":79,"in_reply_to":"40aa8921_ca774f58","updated":"2024-02-23 11:19:21.000000000","message":"Acknowledged","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"762521100dd4a2bb5c68ad3abcdb670392f2621b","unresolved":true,"context_lines":[{"line_number":76,"context_line":"            # Replace it with a capabilities filter specially."},{"line_number":77,"context_line":"            if key \u003d\u003d \u0027hw:maxphysaddr_bits\u0027:"},{"line_number":78,"context_line":"                key \u003d \u0027capabilities:cpu_info:maxphysaddr:bits\u0027"},{"line_number":79,"context_line":"                req \u003d \u0027\u003e\u003d \u0027 + req"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"            # Either not scope format, or in capabilities scope"},{"line_number":82,"context_line":"            scope \u003d key.split(\u0027:\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"40aa8921_ca774f58","line":79,"in_reply_to":"bbac6e60_c69d61c0","updated":"2024-02-14 10:16:17.000000000","message":"Fixed to perform this replacement outside of the loop. I think it is now easier to understand.","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"}],"nova/scheduler/filters/image_props_filter.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"584e6f2398e9b69cf944ef7e1ecd4441079c6b84","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            if not bits:"},{"line_number":99,"context_line":"                return True"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"            return bits \u003e\u003d bits_required"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        for supp_inst in supp_instances:"},{"line_number":104,"context_line":"            if _compare_props(checked_img_props, supp_inst):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bedc969c_584596a7","line":101,"updated":"2024-02-13 11:06:34.000000000","message":"+1 thanks for including this","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66903524eb68f966bc03a9c1c192b6e4a5786906","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if not bits:"},{"line_number":99,"context_line":"                return True"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"            return bits \u003e\u003d bits_required"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        for supp_inst in supp_instances:"},{"line_number":104,"context_line":"            if _compare_props(checked_img_props, supp_inst):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7dd372_8bb3f349","line":101,"in_reply_to":"bedc969c_584596a7","updated":"2024-02-23 11:19:21.000000000","message":"Acknowledged","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"}],"nova/scheduler/utils.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66903524eb68f966bc03a9c1c192b6e4a5786906","unresolved":true,"context_lines":[{"line_number":273,"context_line":"        self._add_trait(trait, \u0027required\u0027)"},{"line_number":274,"context_line":"        LOG.debug(\"Requiring secure boot support via trait %s.\", trait)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def _translate_maxphysaddr_request("},{"line_number":277,"context_line":"        self,"},{"line_number":278,"context_line":"        flavor: \u0027objects.Flavor\u0027,"},{"line_number":279,"context_line":"        image: \u0027objects.ImageMeta\u0027,"},{"line_number":280,"context_line":"    ) -\u003e None:"},{"line_number":281,"context_line":"        mode \u003d hardware.get_maxphysaddr_mode(flavor, image)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        if mode is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ef93602_2a30a7ec","line":280,"range":{"start_line":276,"start_character":2,"end_line":280,"end_character":14},"updated":"2024-02-23 11:19:21.000000000","message":"just a general stype nit\n\none line per arg wastes virtical space and its generaly not the perfered style.\n\nwe generally prefer to wrap multiple args on the same line and place the ) on the same line as the last arg we have a mix of differnet style but the black style will recive -1s form some peole as not accpatable.","commit_id":"85069325ac49cbfa3d2b8bec97858c26e8599925"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"55f93fc811fb2b301cf5c933f5c9049b972553f0","unresolved":true,"context_lines":[{"line_number":273,"context_line":"        self._add_trait(trait, \u0027required\u0027)"},{"line_number":274,"context_line":"        LOG.debug(\"Requiring secure boot support via trait %s.\", trait)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def _translate_maxphysaddr_request("},{"line_number":277,"context_line":"        self,"},{"line_number":278,"context_line":"        flavor: \u0027objects.Flavor\u0027,"},{"line_number":279,"context_line":"        image: \u0027objects.ImageMeta\u0027,"},{"line_number":280,"context_line":"    ) -\u003e None:"},{"line_number":281,"context_line":"        mode \u003d hardware.get_maxphysaddr_mode(flavor, image)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        if mode is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"79b69c47_9cf3ec77","line":280,"range":{"start_line":276,"start_character":2,"end_line":280,"end_character":14},"in_reply_to":"6ef93602_2a30a7ec","updated":"2024-02-26 03:57:59.000000000","message":"Thanks for the review! I fixed it.","commit_id":"85069325ac49cbfa3d2b8bec97858c26e8599925"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7a6079829322092921db6fde15837a7bcf91ba5b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        self._add_trait(trait, \u0027required\u0027)"},{"line_number":274,"context_line":"        LOG.debug(\"Requiring secure boot support via trait %s.\", trait)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def _translate_maxphysaddr_request("},{"line_number":277,"context_line":"        self,"},{"line_number":278,"context_line":"        flavor: \u0027objects.Flavor\u0027,"},{"line_number":279,"context_line":"        image: \u0027objects.ImageMeta\u0027,"},{"line_number":280,"context_line":"    ) -\u003e None:"},{"line_number":281,"context_line":"        mode \u003d hardware.get_maxphysaddr_mode(flavor, image)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        if mode is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"e9d38cf0_ee03356a","line":280,"range":{"start_line":276,"start_character":2,"end_line":280,"end_character":14},"in_reply_to":"79b69c47_9cf3ec77","updated":"2024-02-26 17:39:37.000000000","message":"Done","commit_id":"85069325ac49cbfa3d2b8bec97858c26e8599925"}],"nova/tests/unit/objects/test_fields.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"584e6f2398e9b69cf944ef7e1ecd4441079c6b84","unresolved":true,"context_lines":[{"line_number":723,"context_line":"        self.assertEqual(\"\u0027passthrough\u0027\", self.field.stringify(\u0027passthrough\u0027))"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"    def test_stringify_invalid(self):"},{"line_number":726,"context_line":"        self.assertRaises(ValueError, self.field.stringify, \u0027hoge\u0027)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"class TestSchemaGeneration(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"41528371_76457505","line":726,"updated":"2024-02-13 11:06:34.000000000","message":"we dont really ned to test converting things to strings\nwe can but we get that for free from oslo.\n\nits following hte patttern but is not reallly that userful\n\nthat said there is no reason to remove it :)","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"762521100dd4a2bb5c68ad3abcdb670392f2621b","unresolved":true,"context_lines":[{"line_number":723,"context_line":"        self.assertEqual(\"\u0027passthrough\u0027\", self.field.stringify(\u0027passthrough\u0027))"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"    def test_stringify_invalid(self):"},{"line_number":726,"context_line":"        self.assertRaises(ValueError, self.field.stringify, \u0027hoge\u0027)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"class TestSchemaGeneration(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a6b8e4be_18f5cab7","line":726,"in_reply_to":"41528371_76457505","updated":"2024-02-14 10:16:17.000000000","message":"I have removed these test cases for now.","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"}],"nova/tests/unit/objects/test_image_meta.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7a6079829322092921db6fde15837a7bcf91ba5b","unresolved":true,"context_lines":[{"line_number":358,"context_line":"            \u0027img_hv_requested_version\u0027: \u0027\u003e\u003d 1.0\u0027,"},{"line_number":359,"context_line":"            \u0027os_require_quiesce\u0027: True,"},{"line_number":360,"context_line":"            \u0027os_secure_boot\u0027: \u0027required\u0027,"},{"line_number":361,"context_line":"            \u0027hw_maxphysaddr_mode\u0027: \u0027passthrough\u0027,"},{"line_number":362,"context_line":"            \u0027hw_rescue_bus\u0027: \u0027ide\u0027,"},{"line_number":363,"context_line":"            \u0027hw_rescue_device\u0027: \u0027disk\u0027,"},{"line_number":364,"context_line":"            \u0027hw_watchdog_action\u0027: fields.WatchdogAction.DISABLED,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4baa1f41_03f639bf","line":361,"updated":"2024-02-26 17:39:37.000000000","message":"hw_maxphysaddr_bits shall be added too.","commit_id":"14c3c5fa4d7285c22ea71d13dd337c37c3e742e8"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"36122ec72b192d0af29be2fdf23d7f6874509ea9","unresolved":false,"context_lines":[{"line_number":358,"context_line":"            \u0027img_hv_requested_version\u0027: \u0027\u003e\u003d 1.0\u0027,"},{"line_number":359,"context_line":"            \u0027os_require_quiesce\u0027: True,"},{"line_number":360,"context_line":"            \u0027os_secure_boot\u0027: \u0027required\u0027,"},{"line_number":361,"context_line":"            \u0027hw_maxphysaddr_mode\u0027: \u0027passthrough\u0027,"},{"line_number":362,"context_line":"            \u0027hw_rescue_bus\u0027: \u0027ide\u0027,"},{"line_number":363,"context_line":"            \u0027hw_rescue_device\u0027: \u0027disk\u0027,"},{"line_number":364,"context_line":"            \u0027hw_watchdog_action\u0027: fields.WatchdogAction.DISABLED,"}],"source_content_type":"text/x-python","patch_set":3,"id":"eef424bc_b56b5030","line":361,"in_reply_to":"4baa1f41_03f639bf","updated":"2024-02-27 05:25:02.000000000","message":"I added the hw_maxphysaddr_bit here. Thanks.","commit_id":"14c3c5fa4d7285c22ea71d13dd337c37c3e742e8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7a6079829322092921db6fde15837a7bcf91ba5b","unresolved":true,"context_lines":[{"line_number":501,"context_line":"        self.assertEqual(\"required\", secure_props.os_secure_boot)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def test_set_hw_maxphysaddr_mode(self):"},{"line_number":504,"context_line":"        props \u003d {\u0027hw_maxphysaddr_mode\u0027: \"passthrough\"}"},{"line_number":505,"context_line":"        obj \u003d objects.ImageMetaProps.from_dict(props)"},{"line_number":506,"context_line":"        self.assertEqual(\"passthrough\", obj.hw_maxphysaddr_mode)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"083826da_7bbddf42","line":504,"updated":"2024-02-26 17:39:37.000000000","message":"you shall add a negative test for some other mode which would be unsupported.\nAs an example, please double-check that  {\u0027hw_maxphysaddr_mode\u0027: \"blah\"} raises an exception when calling .from_dict()","commit_id":"14c3c5fa4d7285c22ea71d13dd337c37c3e742e8"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"36122ec72b192d0af29be2fdf23d7f6874509ea9","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        self.assertEqual(\"required\", secure_props.os_secure_boot)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def test_set_hw_maxphysaddr_mode(self):"},{"line_number":504,"context_line":"        props \u003d {\u0027hw_maxphysaddr_mode\u0027: \"passthrough\"}"},{"line_number":505,"context_line":"        obj \u003d objects.ImageMetaProps.from_dict(props)"},{"line_number":506,"context_line":"        self.assertEqual(\"passthrough\", obj.hw_maxphysaddr_mode)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b7ecbeca_5000d3df","line":504,"in_reply_to":"083826da_7bbddf42","updated":"2024-02-27 05:25:02.000000000","message":"I added the negative test.","commit_id":"14c3c5fa4d7285c22ea71d13dd337c37c3e742e8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7a6079829322092921db6fde15837a7bcf91ba5b","unresolved":true,"context_lines":[{"line_number":504,"context_line":"        props \u003d {\u0027hw_maxphysaddr_mode\u0027: \"passthrough\"}"},{"line_number":505,"context_line":"        obj \u003d objects.ImageMetaProps.from_dict(props)"},{"line_number":506,"context_line":"        self.assertEqual(\"passthrough\", obj.hw_maxphysaddr_mode)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def test_obj_make_compatible_img_hide_hypervisor_id(self):"},{"line_number":509,"context_line":"        \"\"\"Tests that checks if we pop img_hide_hypervisor_id.\"\"\""},{"line_number":510,"context_line":"        obj \u003d objects.ImageMetaProps(img_hide_hypervisor_id\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"22121093_87452cee","line":507,"updated":"2024-02-26 17:39:37.000000000","message":"you shall also check that you can set hw_maxphysaddr_bits","commit_id":"14c3c5fa4d7285c22ea71d13dd337c37c3e742e8"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"36122ec72b192d0af29be2fdf23d7f6874509ea9","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        props \u003d {\u0027hw_maxphysaddr_mode\u0027: \"passthrough\"}"},{"line_number":505,"context_line":"        obj \u003d objects.ImageMetaProps.from_dict(props)"},{"line_number":506,"context_line":"        self.assertEqual(\"passthrough\", obj.hw_maxphysaddr_mode)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def test_obj_make_compatible_img_hide_hypervisor_id(self):"},{"line_number":509,"context_line":"        \"\"\"Tests that checks if we pop img_hide_hypervisor_id.\"\"\""},{"line_number":510,"context_line":"        obj \u003d objects.ImageMetaProps(img_hide_hypervisor_id\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d9846d3e_2efb68f2","line":507,"in_reply_to":"22121093_87452cee","updated":"2024-02-27 05:25:02.000000000","message":"I added the test case for hw_maxphysaddr_bits.","commit_id":"14c3c5fa4d7285c22ea71d13dd337c37c3e742e8"}],"nova/tests/unit/scheduler/filters/test_compute_capabilities_filters.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"584e6f2398e9b69cf944ef7e1ecd4441079c6b84","unresolved":true,"context_lines":[{"line_number":103,"context_line":"            passes\u003dFalse)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_compute_filter_pass_maxphysaddr_bits(self):"},{"line_number":106,"context_line":"        cpu_info \u003d \"\"\" {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 42}} \"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        cpu_info \u003d str(cpu_info)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c872ce91_dbcbcac9","line":106,"range":{"start_line":106,"start_character":19,"end_line":106,"end_character":23},"updated":"2024-02-13 11:06:34.000000000","message":"instead of creating a single line multi line string just use \u0027\u0027\ni.e. \u0027{\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 42}}\u0027","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66903524eb68f966bc03a9c1c192b6e4a5786906","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            passes\u003dFalse)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_compute_filter_pass_maxphysaddr_bits(self):"},{"line_number":106,"context_line":"        cpu_info \u003d \"\"\" {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 42}} \"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        cpu_info \u003d str(cpu_info)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ef089fd9_290948c2","line":106,"range":{"start_line":106,"start_character":19,"end_line":106,"end_character":23},"in_reply_to":"58a74efd_289528fc","updated":"2024-02-23 11:19:21.000000000","message":"Done","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"762521100dd4a2bb5c68ad3abcdb670392f2621b","unresolved":true,"context_lines":[{"line_number":103,"context_line":"            passes\u003dFalse)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_compute_filter_pass_maxphysaddr_bits(self):"},{"line_number":106,"context_line":"        cpu_info \u003d \"\"\" {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 42}} \"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        cpu_info \u003d str(cpu_info)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"58a74efd_289528fc","line":106,"range":{"start_line":106,"start_character":19,"end_line":106,"end_character":23},"in_reply_to":"c872ce91_dbcbcac9","updated":"2024-02-14 10:16:17.000000000","message":"Of course. I fixed it.","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"584e6f2398e9b69cf944ef7e1ecd4441079c6b84","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    def test_compute_filter_pass_maxphysaddr_bits(self):"},{"line_number":106,"context_line":"        cpu_info \u003d \"\"\" {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 42}} \"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        cpu_info \u003d str(cpu_info)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self._do_test_compute_filter_extra_specs("},{"line_number":111,"context_line":"            ecaps\u003d{\u0027cpu_info\u0027: cpu_info},"}],"source_content_type":"text/x-python","patch_set":1,"id":"5e5cecf9_341ff396","line":108,"updated":"2024-02-13 11:06:34.000000000","message":"why are you calling str on this \nit is a string\n\u003e\u003e\u003e cpu_info \u003d \"\"\" {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 42}} \"\"\"\n\u003e\u003e\u003e cpu_info\n\u0027 {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 42}} \u0027\n\u003e\u003e\u003e type(cpu_info)\n\u003cclass \u0027str\u0027\u003e","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"762521100dd4a2bb5c68ad3abcdb670392f2621b","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    def test_compute_filter_pass_maxphysaddr_bits(self):"},{"line_number":106,"context_line":"        cpu_info \u003d \"\"\" {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 42}} \"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        cpu_info \u003d str(cpu_info)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self._do_test_compute_filter_extra_specs("},{"line_number":111,"context_line":"            ecaps\u003d{\u0027cpu_info\u0027: cpu_info},"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba4f65da_dda4cb38","line":108,"in_reply_to":"5e5cecf9_341ff396","updated":"2024-02-14 10:16:17.000000000","message":"This was a mistake. It is unnecessary and I removed it.","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66903524eb68f966bc03a9c1c192b6e4a5786906","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def test_compute_filter_pass_maxphysaddr_bits(self):"},{"line_number":106,"context_line":"        cpu_info \u003d \"\"\" {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 42}} \"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        cpu_info \u003d str(cpu_info)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self._do_test_compute_filter_extra_specs("},{"line_number":111,"context_line":"            ecaps\u003d{\u0027cpu_info\u0027: cpu_info},"}],"source_content_type":"text/x-python","patch_set":1,"id":"880764ce_a0d6ab02","line":108,"in_reply_to":"ba4f65da_dda4cb38","updated":"2024-02-23 11:19:21.000000000","message":"Acknowledged","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"584e6f2398e9b69cf944ef7e1ecd4441079c6b84","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            passes\u003dTrue)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_compute_filter_fails_maxphysaddr_bits(self):"},{"line_number":116,"context_line":"        cpu_info \u003d \"\"\" {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 20}} \"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        cpu_info \u003d str(cpu_info)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dcac65d7_b306668f","line":116,"range":{"start_line":116,"start_character":19,"end_line":116,"end_character":22},"updated":"2024-02-13 11:06:34.000000000","message":"same here and below.","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66903524eb68f966bc03a9c1c192b6e4a5786906","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            passes\u003dTrue)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_compute_filter_fails_maxphysaddr_bits(self):"},{"line_number":116,"context_line":"        cpu_info \u003d \"\"\" {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 20}} \"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        cpu_info \u003d str(cpu_info)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d59792cd_7cb220bf","line":116,"range":{"start_line":116,"start_character":19,"end_line":116,"end_character":22},"in_reply_to":"d4aaa615_1c54bc74","updated":"2024-02-23 11:19:21.000000000","message":"Done","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"762521100dd4a2bb5c68ad3abcdb670392f2621b","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            passes\u003dTrue)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_compute_filter_fails_maxphysaddr_bits(self):"},{"line_number":116,"context_line":"        cpu_info \u003d \"\"\" {\"maxphysaddr\": {\"mode\": \"emulate\", \"bits\": 20}} \"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        cpu_info \u003d str(cpu_info)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d4aaa615_1c54bc74","line":116,"range":{"start_line":116,"start_character":19,"end_line":116,"end_character":22},"in_reply_to":"dcac65d7_b306668f","updated":"2024-02-14 10:16:17.000000000","message":"OK. I fixed.","commit_id":"31b17020910c79d7c77e3df0796b68a68343eb84"}],"nova/tests/unit/scheduler/test_utils.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7a6079829322092921db6fde15837a7bcf91ba5b","unresolved":true,"context_lines":[{"line_number":1375,"context_line":"        )"},{"line_number":1376,"context_line":"        rs \u003d objects.RequestSpec(flavor\u003dflavor, is_bfv\u003dFalse)"},{"line_number":1377,"context_line":"        rr \u003d utils.ResourceRequest.from_request_spec(rs)"},{"line_number":1378,"context_line":"        self.assertResourceRequestsEqual(expected, rr)"},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"    def test_resource_request_from_request_groups(self):"},{"line_number":1381,"context_line":"        rgs \u003d objects.RequestGroup.from_extended_port_request("}],"source_content_type":"text/x-python","patch_set":3,"id":"1d0333af_7324e086","line":1378,"updated":"2024-02-26 17:39:37.000000000","message":"that\u0027s cool but you miss one conditional check with emulate.","commit_id":"14c3c5fa4d7285c22ea71d13dd337c37c3e742e8"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"36122ec72b192d0af29be2fdf23d7f6874509ea9","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"        )"},{"line_number":1376,"context_line":"        rs \u003d objects.RequestSpec(flavor\u003dflavor, is_bfv\u003dFalse)"},{"line_number":1377,"context_line":"        rr \u003d utils.ResourceRequest.from_request_spec(rs)"},{"line_number":1378,"context_line":"        self.assertResourceRequestsEqual(expected, rr)"},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"    def test_resource_request_from_request_groups(self):"},{"line_number":1381,"context_line":"        rgs \u003d objects.RequestGroup.from_extended_port_request("}],"source_content_type":"text/x-python","patch_set":3,"id":"62fa07a7_ad0ee6eb","line":1378,"in_reply_to":"1d0333af_7324e086","updated":"2024-02-27 05:25:02.000000000","message":"OK. I added it.","commit_id":"14c3c5fa4d7285c22ea71d13dd337c37c3e742e8"}]}