)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"b43b5ca7f572698e802e0a66811af949df6a094b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9bbd9336_951015f9","updated":"2024-04-02 14:58:15.000000000","message":"a nit on arg name, rest lgtm.","commit_id":"dececbd968ff45c0504353025c6fd1cbd24ed6a1"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"94f25c49ae7ac30c6c11543b06172eedef6cd7c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5f32b57e_c59c0645","updated":"2024-04-17 19:18:29.000000000","message":"thanks for the update, regression tc lgtm,\n\nthough I tried to reproduce it and as you said in bug-report, resize went successful, but for me server reboot after resize was successful too,  only this in boot logs around `20/20` times, but I tested it with cirros, so this might be issue for large images or in prod env.\n`failed 1/20: up 3.05. request failed\nfailed 2/20: up 5.08. request failed\nfailed 3/20: up 7.08. request failed\nfailed 4/20: up 9.09. request failed\n`","commit_id":"7db43425119f16dc7519dae9efaf5b02ee04c401"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c387810355291423ea312e738eed6493de7224ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0d561b91_136c9c6c","updated":"2024-04-19 21:10:18.000000000","message":"LGTM, appreciate the code comments explaining in the test","commit_id":"b434b4276194e6205362b3b7b4beb35686b3d585"}],"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"b43b5ca7f572698e802e0a66811af949df6a094b","unresolved":true,"context_lines":[{"line_number":703,"context_line":"            self.cinder.create_vol_attachment("},{"line_number":704,"context_line":"                volume_id, server[\u0027id\u0027])"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    def _create_server_boot_from_volume(self, images_updates\u003dNone,"},{"line_number":707,"context_line":"                                        flavor_id\u003dNone, networks\u003dNone):"},{"line_number":708,"context_line":"        bfv_image_id \u003d uuids.bfv_image_uuid"},{"line_number":709,"context_line":"        timestamp \u003d datetime.datetime(2011, 1, 1, 1, 2, 3)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ee2c2ddd_48dc1bf2","line":706,"range":{"start_line":706,"start_character":46,"end_line":706,"end_character":60},"updated":"2024-04-02 14:58:15.000000000","message":"can we call this image_args instead.","commit_id":"dececbd968ff45c0504353025c6fd1cbd24ed6a1"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"fce06f9913a3ebe55fc45bb44ad99ce17618e8ed","unresolved":false,"context_lines":[{"line_number":703,"context_line":"            self.cinder.create_vol_attachment("},{"line_number":704,"context_line":"                volume_id, server[\u0027id\u0027])"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    def _create_server_boot_from_volume(self, images_updates\u003dNone,"},{"line_number":707,"context_line":"                                        flavor_id\u003dNone, networks\u003dNone):"},{"line_number":708,"context_line":"        bfv_image_id \u003d uuids.bfv_image_uuid"},{"line_number":709,"context_line":"        timestamp \u003d datetime.datetime(2011, 1, 1, 1, 2, 3)"}],"source_content_type":"text/x-python","patch_set":7,"id":"e67fc395_c9bf9315","line":706,"range":{"start_line":706,"start_character":46,"end_line":706,"end_character":60},"in_reply_to":"ee2c2ddd_48dc1bf2","updated":"2024-04-03 06:57:09.000000000","message":"Done","commit_id":"dececbd968ff45c0504353025c6fd1cbd24ed6a1"}],"nova/tests/functional/regressions/test_bug_2007968.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dfff05c144f95e2f379185bab39998a08b94f6a1","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        # get to the resize verify status, but the instance\u0027s application runs"},{"line_number":58,"context_line":"        # abnormally due to insufficient memory, and it may be killed by OOM."},{"line_number":59,"context_line":"        server \u003d self._resize_server(server, new_flavor)"},{"line_number":60,"context_line":"        self.assertEqual(server[\u0027status\u0027], \u0027VERIFY_RESIZE\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"a4d47bbb_abf2f121","line":60,"updated":"2024-04-18 12:43:06.000000000","message":"does this bug only affect BFV or doe sthe saem happen for a normal instance?\n\nthe bug report does not specify this only affect BFV so we likely shoudl test both.","commit_id":"b434b4276194e6205362b3b7b4beb35686b3d585"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a4a03235ba357963f413af324b8c2e47f85471c4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # get to the resize verify status, but the instance\u0027s application runs"},{"line_number":58,"context_line":"        # abnormally due to insufficient memory, and it may be killed by OOM."},{"line_number":59,"context_line":"        server \u003d self._resize_server(server, new_flavor)"},{"line_number":60,"context_line":"        self.assertEqual(server[\u0027status\u0027], \u0027VERIFY_RESIZE\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"cb7bce17_395413a8","line":60,"in_reply_to":"461a34d6_50c0c8ca","updated":"2024-04-19 09:36:45.000000000","message":"Acknowledged","commit_id":"b434b4276194e6205362b3b7b4beb35686b3d585"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"ecc00a1b5ca02ac8ae239a8f029fa3a9ee5d7928","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        # get to the resize verify status, but the instance\u0027s application runs"},{"line_number":58,"context_line":"        # abnormally due to insufficient memory, and it may be killed by OOM."},{"line_number":59,"context_line":"        server \u003d self._resize_server(server, new_flavor)"},{"line_number":60,"context_line":"        self.assertEqual(server[\u0027status\u0027], \u0027VERIFY_RESIZE\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"461a34d6_50c0c8ca","line":60,"in_reply_to":"895ba6fd_6d40d3bd","updated":"2024-04-19 02:42:31.000000000","message":"the bug is only affect bfv instance, the existing code has already covered the normal instance check, at https://github.com/openstack/nova/blob/dcc32981ddad1cad5f41d3715132d72ddd7de435/nova/compute/api.py#L751, and I also added the comment to explain this patch is only affect bfv .","commit_id":"b434b4276194e6205362b3b7b4beb35686b3d585"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"a14e9208532ae987c94fb52eaa4381453c22a9cd","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        # get to the resize verify status, but the instance\u0027s application runs"},{"line_number":58,"context_line":"        # abnormally due to insufficient memory, and it may be killed by OOM."},{"line_number":59,"context_line":"        server \u003d self._resize_server(server, new_flavor)"},{"line_number":60,"context_line":"        self.assertEqual(server[\u0027status\u0027], \u0027VERIFY_RESIZE\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"895ba6fd_6d40d3bd","line":60,"in_reply_to":"a4d47bbb_abf2f121","updated":"2024-04-18 15:06:02.000000000","message":"for normal instance on resize request we get error msg something like \u0027flavor memory is small for image.\u0027","commit_id":"b434b4276194e6205362b3b7b4beb35686b3d585"}]}