)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"83fbcf93b319bfdd6a01137c0e090256556b8dfb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"859cf9bd_e9932d73","updated":"2024-08-16 15:05:28.000000000","message":"Downstream, we rely on https://review.opendev.org/c/openstack/nova/+/612272\nto make this one available.\nWhen I did the rebase on top of master, I may have imported some changes from 612272 by mistake.\nSo let\u0027s wait for the previous one to be finished before moving this forward here","commit_id":"d01cdb92c6333e436dbe6ac0275446af4d6e8d92"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4a1ab2123ed8c9ec5d8d24902242627528e05f90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81605d46_0084e1cd","updated":"2024-05-31 07:39:36.000000000","message":"Hey, looks like reasonable change, just some comments","commit_id":"d01cdb92c6333e436dbe6ac0275446af4d6e8d92"}],"nova/conf/libvirt.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4a1ab2123ed8c9ec5d8d24902242627528e05f90","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"libvirt_general_opts \u003d ["},{"line_number":43,"context_line":"    cfg.IntOpt(\u0027device_job_retry_count\u0027,"},{"line_number":44,"context_line":"        default\u003d50,"},{"line_number":45,"context_line":"        min\u003d0,"},{"line_number":46,"context_line":"        help\u003d\"\"\""},{"line_number":47,"context_line":"Maximum number of retries in dev.get_job_info() and dev.abort_job()."}],"source_content_type":"text/x-python","patch_set":2,"id":"259f194d_bc4c2db1","line":44,"updated":"2024-05-31 07:39:36.000000000","message":"Previously there was no attempts and now 50, is that not too big?","commit_id":"d01cdb92c6333e436dbe6ac0275446af4d6e8d92"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4a1ab2123ed8c9ec5d8d24902242627528e05f90","unresolved":true,"context_lines":[{"line_number":747,"context_line":"                self._guest._domain.blockJobAbort(self._disk, flags\u003dflags)"},{"line_number":748,"context_line":"            except libvirt.libvirtError as ex:"},{"line_number":749,"context_line":"                if ex.get_error_code() \u003d\u003d libvirt.VIR_ERR_OPERATION_TIMEOUT:"},{"line_number":750,"context_line":"                    LOG.warning(\"Hit VIR_ERR_OPERATION_TIMEOUT while \""},{"line_number":751,"context_line":"                                \"aborting block job info msg: %(err)s.\","},{"line_number":752,"context_line":"                                {\u0027err\u0027: ex.get_error_message()})"},{"line_number":753,"context_line":"                    raise RuntimeError(ex.get_error_message())"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba61a64b_fc25a2fe","line":750,"updated":"2024-05-31 07:39:36.000000000","message":"This message looks a bit hard to understand for an operator. Can your rephrase it to make it more clear for a no-dev point of view, Also adding context to the message so we understand the operation in progress. You can still add libvirtd error message as-well.","commit_id":"d01cdb92c6333e436dbe6ac0275446af4d6e8d92"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4a1ab2123ed8c9ec5d8d24902242627528e05f90","unresolved":true,"context_lines":[{"line_number":751,"context_line":"                                \"aborting block job info msg: %(err)s.\","},{"line_number":752,"context_line":"                                {\u0027err\u0027: ex.get_error_message()})"},{"line_number":753,"context_line":"                    raise RuntimeError(ex.get_error_message())"},{"line_number":754,"context_line":"                elif ex.get_error_code() \u003d\u003d libvirt.VIR_ERR_INVALID_ARG:"},{"line_number":755,"context_line":"                    if ignore_invalid:"},{"line_number":756,"context_line":"                        return"},{"line_number":757,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"2905f0f7_38c335e1","line":754,"updated":"2024-05-31 07:39:36.000000000","message":"I think what you want here is to pass for an `VIR_ERR_OPERATION_INVALID` right?\n\nVIR_ERR_INVALID_ARG\t\u003d \t8 (0x8)\tinvalid function argument\nVIR_ERR_OPERATION_INVALID\t\u003d \t55 (0x37)\toperation is not applicable at this time\n\nThe question I have is why you quit the loop when this happens?","commit_id":"d01cdb92c6333e436dbe6ac0275446af4d6e8d92"}]}