)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c55cac45677cd1bc2257965249b5a9eacd42dbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"01e902d1_d3c1f9e4","updated":"2024-04-18 16:54:28.000000000","message":"i belive https://review.opendev.org/c/openstack/nova/+/916322 is a more correct fix for this issue.\n\ni marked it as WIP as its missing test coverage.","commit_id":"a657858acf2b6348aedcc7f5ead08dde8f5204a2"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"073f9e98b8719a1fac028e29da15375ec29a2f25","unresolved":true,"context_lines":[{"line_number":2032,"context_line":""},{"line_number":2033,"context_line":"        try:"},{"line_number":2034,"context_line":"            _disconnect_volume()"},{"line_number":2035,"context_line":"        except retrying.RetryError:"},{"line_number":2036,"context_line":"            LOG.info(\u0027Detected multiple connections on this host for \u0027"},{"line_number":2037,"context_line":"                     \u0027volume: %(volume)s, skipping target disconnect.\u0027,"},{"line_number":2038,"context_line":"                     {\u0027volume\u0027: volume_id})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5769747a_b7b9172e","line":2035,"updated":"2024-04-18 12:53:57.000000000","message":"im not sure this is the correc approch.\n\ninstead i think we need to use a lock on the volume uuid to synconise this critical section.\n\n_should_disconnect_target is racey and it and the call to disconnect chould be wrapped in a lock.","commit_id":"a657858acf2b6348aedcc7f5ead08dde8f5204a2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c654948a0b9bb63542799b39ec50600515c98cf","unresolved":true,"context_lines":[{"line_number":2032,"context_line":""},{"line_number":2033,"context_line":"        try:"},{"line_number":2034,"context_line":"            _disconnect_volume()"},{"line_number":2035,"context_line":"        except retrying.RetryError:"},{"line_number":2036,"context_line":"            LOG.info(\u0027Detected multiple connections on this host for \u0027"},{"line_number":2037,"context_line":"                     \u0027volume: %(volume)s, skipping target disconnect.\u0027,"},{"line_number":2038,"context_line":"                     {\u0027volume\u0027: volume_id})"}],"source_content_type":"text/x-python","patch_set":3,"id":"c259ae6c_d977e0a6","line":2035,"in_reply_to":"5769747a_b7b9172e","updated":"2024-04-18 14:10:58.000000000","message":"i should alos point out that the rety loop is still a race condtion\nit not a correct fix on its own.","commit_id":"a657858acf2b6348aedcc7f5ead08dde8f5204a2"}]}