)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"592e78ab3d499774fd287634ce2e02cc4ea7c0f4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix debug PciPassthroughFilter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The filter was not printing correct values"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5cd600d7f8bc3dea42e45ace8f63bf051ed93475"},{"line_number":12,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"71bf20c4_9038a2e1","line":9,"updated":"2024-03-20 21:15:27.000000000","message":"not quite it just the object is missing a `__rper__` function that list the details of the request.\n\nwhat it was printing before was valid just not that helpful.","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"bcf8ee2270919dee8d60e848b10623653dcb321f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fcb1d382_d4cd0be9","updated":"2024-08-16 14:32:26.000000000","message":"Hey tema, can we move this change forward?\nIt doesn\u0027t prevent the change from sean to be merged later and this one is still useful anyway 😊","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"36836de2e317b23d0193411c32cf444bc367d088","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"197b9d8e_aea135c1","updated":"2024-03-20 16:31:15.000000000","message":"Looks correct to me","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"90122a487cb14e1ef8e74e155b04c168a45b215b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aeba6fe9_e34e731e","updated":"2024-08-19 12:58:26.000000000","message":"i do not want ot proceeed with this one off approch","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b8ed2557decc77f9b5f6a311621311a349d1cd1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe1b0c6c_3cc44c13","updated":"2024-08-19 16:53:47.000000000","message":"i have adressed the feedback on https://review.opendev.org/c/openstack/nova/+/898057","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"dbd3c694e074bd137e18444e13bdf87b3e98eed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c530713b_2eaf2470","updated":"2024-02-16 14:51:06.000000000","message":"recheck nova-ovs-hybrid-plug","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"8f226c44dbf716aff0dc338c1a769a30823a813e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"683a0bd7_db0b6628","updated":"2024-02-16 19:24:38.000000000","message":"recheck tempest-integrated-compute","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"592e78ab3d499774fd287634ce2e02cc4ea7c0f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecfa6e5c_454f3c6e","updated":"2024-03-20 21:15:27.000000000","message":"this is fine the -1 is just because i have a more complete logging fix","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7dd67e01120af511d2bc16d02bdfb6b4f1a3faf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fdeaaaa4_1b4ad0bc","in_reply_to":"83961f0f_8758c3d0","updated":"2024-08-19 16:35:04.000000000","message":"the other patch is equally as ready as this as neither have test coverage showing that it works which is why sylvain -1 the othet patch.","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a9d08c0a2e3aa6a5ff10159851497c7327d8ed6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"83961f0f_8758c3d0","in_reply_to":"aeba6fe9_e34e731e","updated":"2024-08-19 15:54:37.000000000","message":"The other patch isn\u0027t ready and this is an improvement. We can do both 😄","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"}],"nova/scheduler/filters/pci_passthrough_filter.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"36836de2e317b23d0193411c32cf444bc367d088","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            LOG.debug(\"%(host_state)s doesn\u0027t have the required PCI devices\""},{"line_number":56,"context_line":"                      \" (%(requests)s)\","},{"line_number":57,"context_line":"                      {\u0027host_state\u0027: host_state,"},{"line_number":58,"context_line":"                       \u0027requests\u0027: pci_requests.requests})"},{"line_number":59,"context_line":"            return False"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        good_candidates \u003d self.filter_candidates("}],"source_content_type":"text/x-python","patch_set":1,"id":"58ed503e_ed6d3b6e","line":58,"updated":"2024-03-20 16:31:15.000000000","message":"Indeed just logging `spec_obj.pci_requests` doesn\u0027t show any detail of each InstancePCIRequest but `spec_obj.pci_requests.requests` does.\n```\n\u003e\u003e\u003e r\nRequestSpec(availability_zone\u003d\u003c?\u003e,flavor\u003d\u003c?\u003e,force_hosts\u003d\u003c?\u003e,force_nodes\u003d\u003c?\u003e,id\u003d\u003c?\u003e,ignore_hosts\u003d\u003c?\u003e,image\u003d\u003c?\u003e,instance_group\u003d\u003c?\u003e,instance_uuid\u003d\u003c?\u003e,is_bfv\u003d\u003c?\u003e,limits\u003d\u003c?\u003e,network_metadata\u003d\u003c?\u003e,num_instances\u003d\u003c?\u003e,numa_topology\u003d\u003c?\u003e,pci_requests\u003dInstancePCIRequests,project_id\u003d\u003c?\u003e,request_level_params\u003d\u003c?\u003e,requested_destination\u003d\u003c?\u003e,requested_networks\u003d\u003c?\u003e,requested_resources\u003d\u003c?\u003e,retry\u003d\u003c?\u003e,scheduler_hints\u003d\u003c?\u003e,security_groups\u003d\u003c?\u003e,user_id\u003d\u003c?\u003e)\n\u003e\u003e\u003e r.pci_requests\nInstancePCIRequests(instance_uuid\u003d\u003c?\u003e,requests\u003d[InstancePCIRequest,InstancePCIRequest])\n\u003e\u003e\u003e r.pci_requests.requests\n[InstancePCIRequest(alias_name\u003d\u003c?\u003e,count\u003d\u003c?\u003e,is_new\u003d\u003c?\u003e,numa_policy\u003d\u003c?\u003e,request_id\u003d\u003c?\u003e,requester_id\u003d\u0027foo\u0027,spec\u003d\u003c?\u003e), InstancePCIRequest(alias_name\u003d\u003c?\u003e,count\u003d\u003c?\u003e,is_new\u003d\u003c?\u003e,numa_policy\u003d\u003c?\u003e,request_id\u003d\u003c?\u003e,requester_id\u003d\u0027bar\u0027,spec\u003d\u003c?\u003e)]\n```","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"592e78ab3d499774fd287634ce2e02cc4ea7c0f4","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            LOG.debug(\"%(host_state)s doesn\u0027t have the required PCI devices\""},{"line_number":56,"context_line":"                      \" (%(requests)s)\","},{"line_number":57,"context_line":"                      {\u0027host_state\u0027: host_state,"},{"line_number":58,"context_line":"                       \u0027requests\u0027: pci_requests.requests})"},{"line_number":59,"context_line":"            return False"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        good_candidates \u003d self.filter_candidates("}],"source_content_type":"text/x-python","patch_set":1,"id":"043200dd_74fefba6","line":58,"in_reply_to":"58ed503e_ed6d3b6e","updated":"2024-03-20 21:15:27.000000000","message":"i have a patch somewhere to add a `__repr__` to fix that but but we can make this change too.\n---later---\nok i found it its here https://review.opendev.org/c/openstack/nova/+/898057\n\nis a better fix.","commit_id":"eb17ca9361a1dd75f80aff96810b7a80c4215a8e"}]}