)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"729ac0621ab2afd201507ceb59840bd33724e872","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Libvirt uses swtpm_ioctl to terminate swtpm processes. If the binary"},{"line_number":10,"context_line":"does not exist, swtpm processes are kept running after the associated"},{"line_number":11,"context_line":"VM terminates, because QEMU does not send shutdown to swtpm."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2052761"},{"line_number":14,"context_line":"Change-Id: I682f71512fc33a49b8dfe93894f144e48f33abe6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"064f443c_fcec9789","line":11,"updated":"2024-02-13 09:44:07.000000000","message":"is this a new requirement or a recnet packaging change?\n\ni belive on rhel/centos thease are all in one rpm package\ni also belive that ubuntu pulls them all in together so we have never had this problem previously.","commit_id":"5a611a4337e08047d2a8c447dfdb2ce79f992fe7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e29461bd784864b3191a409f4ea5500c7b1ed8ce","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Libvirt uses swtpm_ioctl to terminate swtpm processes. If the binary"},{"line_number":10,"context_line":"does not exist, swtpm processes are kept running after the associated"},{"line_number":11,"context_line":"VM terminates, because QEMU does not send shutdown to swtpm."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2052761"},{"line_number":14,"context_line":"Change-Id: I682f71512fc33a49b8dfe93894f144e48f33abe6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"cf1b4dbd_de0b0222","line":11,"in_reply_to":"064f443c_fcec9789","updated":"2024-02-13 09:58:11.000000000","message":"The usage of swtpm_ioctl was added when vTPM support was initially added to libvirt. So this is not a new dependency added later, but is something implicitly required but not checked.\n\nhttps://github.com/libvirt/libvirt/commit/2a606b863ebdc0a74e87c453bb9b76278a72d13b\n\nIn both CentOS and Ubuntu, swtpm_ioctl is installed by the swtpm-tools package, which also contains swtpm_setup so if swtpm_setup exists then we can assume swtpm_ioctl should exist.","commit_id":"5a611a4337e08047d2a8c447dfdb2ce79f992fe7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1500634dc5256ae613081b805c83d98120e2c8a7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Libvirt uses swtpm_ioctl to terminate swtpm processes. If the binary"},{"line_number":10,"context_line":"does not exist, swtpm processes are kept running after the associated"},{"line_number":11,"context_line":"VM terminates, because QEMU does not send shutdown to swtpm."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2052761"},{"line_number":14,"context_line":"Change-Id: I682f71512fc33a49b8dfe93894f144e48f33abe6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1d6864c8_b9ab78a8","line":11,"in_reply_to":"cf1b4dbd_de0b0222","updated":"2024-02-15 09:56:43.000000000","message":"Acknowledged","commit_id":"5a611a4337e08047d2a8c447dfdb2ce79f992fe7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bf74d5095d9d27ef5fa94bc2e70c11c4aa398c3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a0ac68bd_805db6fc","updated":"2024-05-27 13:22:00.000000000","message":"+2 but I\u0027ll review the whole series before +Wing.","commit_id":"5a611a4337e08047d2a8c447dfdb2ce79f992fe7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"56f24396bb5ae5750f08369d82f5448abe2ae9a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4c529a03_2c44d746","updated":"2024-02-13 09:59:51.000000000","message":"The core context change is that libvirt itself now checks not only swtpm and swtpm_setup but also swtpm_ioctl, to determine supportability of emulated vTPM. \n\nThis change aims to align the current logic in nova with libvirt\u0027s one.","commit_id":"5a611a4337e08047d2a8c447dfdb2ce79f992fe7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"729ac0621ab2afd201507ceb59840bd33724e872","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b8b914da_71729fac","updated":"2024-02-13 09:44:07.000000000","message":"im more concerned about requiring a new lib if this is libvirt version dependet or if this depends on the way tools are packaged across distos.\n\nits sounds like this was an implcit dependcy that was alwasy there but before we enforce that it would like you to confirm that swtpm and or libvirt did not  add this in a alter revision.","commit_id":"5a611a4337e08047d2a8c447dfdb2ce79f992fe7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71ff3711e77c0c02daaf16b2f5dbeafd1419dec2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9fd7b6c3_61bd354d","updated":"2024-08-09 02:58:17.000000000","message":"lets proceed with the first two patches in the series.\n\nim happy with the unitlity of them on there own\nthe final patch has a few minor issues but over all it looks good as well\n\ni would like to avoid merging these closer to feature freeze if we can make progress on them now instead.","commit_id":"9a11bb25238288139c4473d9d91bf365ed88f435"}]}