)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ba3a688fb6d5c00d3082b9d058a80f700675449e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7104677_d271cb43","updated":"2024-02-12 18:37:00.000000000","message":"Small cleanup that improves the error message that ends up being shown, I this this is worthwhile.","commit_id":"13c5cd80309e410eee297a18bb92ebe8b2b6cbe0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7d774a2ac3d49749e0a45c890bae266b46dd787","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3420256c_962cc2dd","updated":"2024-02-29 12:16:11.000000000","message":"Sane fix. Error codes haven\u0027t changed so no reason to modify docs","commit_id":"77851bb3655be34ad310e70b5c17d13f87da4449"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"df44e0ba4e8b79a19bb59c57775e7e137b33725c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c647cd61_a4a72dae","updated":"2024-02-19 09:20:38.000000000","message":"recheck nova-ceph-multistore  unrelated","commit_id":"77851bb3655be34ad310e70b5c17d13f87da4449"}],"nova/cmd/manage.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b672f72eef6339351ed1e3704fb69ee2d1151a25","unresolved":true,"context_lines":[{"line_number":3209,"context_line":"            return 4"},{"line_number":3210,"context_line":"        except ValueError:"},{"line_number":3211,"context_line":"            print("},{"line_number":3212,"context_line":"                f\u0027Failed to open {connector_path}. Does it contain valid \u0027"},{"line_number":3213,"context_line":"                f\u0027connector_info data?\u0027"},{"line_number":3214,"context_line":"            )"},{"line_number":3215,"context_line":"            return 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f7a77fd_f031c6bd","line":3212,"updated":"2024-02-13 12:58:01.000000000","message":"this message is wrong\n\nif we get value error we were able to open it but not parse it\nyou are also breaking the public api of this fucntion.\n\nyou should have 2 seperate excpt blocks one for value error and one for OSError\nboth returning 3\n\nim honetly tempeted so say you should not make this change and just leave it as it was. but instead include the errror mssage in addtion to the current message\n\nso \n\n print(f\u0027Failed to open {connector_path}. Does it contain valid \u0027\n       f\u0027connector_info data? error:{str(e)}\u0027)","commit_id":"13c5cd80309e410eee297a18bb92ebe8b2b6cbe0"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"80580baa3fdb431ea7d8eaf01c338d5af0d2e4f8","unresolved":true,"context_lines":[{"line_number":3209,"context_line":"            return 4"},{"line_number":3210,"context_line":"        except ValueError:"},{"line_number":3211,"context_line":"            print("},{"line_number":3212,"context_line":"                f\u0027Failed to open {connector_path}. Does it contain valid \u0027"},{"line_number":3213,"context_line":"                f\u0027connector_info data?\u0027"},{"line_number":3214,"context_line":"            )"},{"line_number":3215,"context_line":"            return 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"5d02993b_40c8e4f8","line":3212,"in_reply_to":"4f7a77fd_f031c6bd","updated":"2024-02-15 05:43:55.000000000","message":"ack, added err msg with current msg\nyeah OSError should return 3, `failed to open` instead of `file not found`","commit_id":"13c5cd80309e410eee297a18bb92ebe8b2b6cbe0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f475da3fb6259775df54f770630e1ba700b38057","unresolved":false,"context_lines":[{"line_number":3209,"context_line":"            return 4"},{"line_number":3210,"context_line":"        except ValueError:"},{"line_number":3211,"context_line":"            print("},{"line_number":3212,"context_line":"                f\u0027Failed to open {connector_path}. Does it contain valid \u0027"},{"line_number":3213,"context_line":"                f\u0027connector_info data?\u0027"},{"line_number":3214,"context_line":"            )"},{"line_number":3215,"context_line":"            return 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"60deed9a_6c9af6cc","line":3212,"in_reply_to":"5d02993b_40c8e4f8","updated":"2024-02-23 12:16:06.000000000","message":"Done","commit_id":"13c5cd80309e410eee297a18bb92ebe8b2b6cbe0"}]}