)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ecd9dcefe8b4a7366c8d144d5e7e5f45762d3135","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a61112fc_7f83e982","updated":"2024-08-19 14:11:17.000000000","message":"soft -1 because of the libvirt driver change but otherwise this looks ok to me","commit_id":"009974e739892dc3f45ee2f3c780e637e8251438"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6547e2edd9d6cb8ff5b5cd840f86802f4afeef02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"abb44637_ea42f283","updated":"2024-08-29 14:30:16.000000000","message":"Nothing to report here","commit_id":"b475f0f99b53fbc95ef9ba6cb1245989d8f7a948"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"02bed7766fcf8d1c0c83773d9a6eb69cfd8356cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bb5c39e7_c0d290e4","updated":"2024-08-20 11:12:41.000000000","message":"so your not explictly setting it to false for the libvirt driver like the others\n\nhowever by not setting it at all it will never be reported so its fine\n\nwe can confirm that form this log message\n\n\nAug 20 00:58:52.045350 np0038219697 nova-compute[76011]: DEBUG nova.scheduler.client.report [None req-df528b41-739e-43d8-a245-f8ca03650a8f tempest-DeleteServersAdminTestJSON-1316547597 tempest-DeleteServersAdminTestJSON-1316547597-project-admin] Refreshing trait associations for resource provider 62bb8e4c-461c-4511-b45c-deddc4d139fa, traits: COMPUTE_DEVICE_TAGGING,COMPUTE_IMAGE_TYPE_AKI,COMPUTE_IMAGE_TYPE_ISO,HW_CPU_X86_SSSE3,HW_CPU_X86_SSE2,COMPUTE_NET_VIF_MODEL_RTL8139,COMPUTE_VIOMMU_MODEL_SMMUV3,COMPUTE_STORAGE_BUS_SCSI,COMPUTE_STORAGE_BUS_VIRTIO,COMPUTE_IMAGE_TYPE_ARI,COMPUTE_STORAGE_BUS_IDE,COMPUTE_GRAPHICS_MODEL_NONE,COMPUTE_VOLUME_EXTEND,COMPUTE_GRAPHICS_MODEL_BOCHS,COMPUTE_TRUSTED_CERTS,COMPUTE_NET_VIF_MODEL_E1000E,COMPUTE_NET_VIF_MODEL_E1000,COMPUTE_GRAPHICS_MODEL_VGA,COMPUTE_SOCKET_PCI_NUMA_AFFINITY,COMPUTE_VOLUME_ATTACH_WITH_TAG,COMPUTE_IMAGE_TYPE_RAW,HW_CPU_X86_SSE42,COMPUTE_NET_VIF_MODEL_VIRTIO,COMPUTE_GRAPHICS_MODEL_VMVGA,COMPUTE_IMAGE_TYPE_QCOW2,COMPUTE_ACCELERATORS,COMPUTE_NET_ATTACH_INTERFACE_WITH_TAG,COMPUTE_NET_ATTACH_INTERFACE,COMPUTE_NET_VIF_MODEL_LAN9118,COMPUTE_VOLUME_MULTI_ATTACH,COMPUTE_NET_VIF_MODEL_NE2K_PCI,HW_CPU_X86_SSE41,COMPUTE_NET_VIF_MODEL_VMXNET3,COMPUTE_VIOMMU_MODEL_AUTO,COMPUTE_IMAGE_TYPE_AMI,COMPUTE_NET_VIRTIO_PACKED,COMPUTE_GRAPHICS_MODEL_VIRTIO,COMPUTE_NODE,HW_CPU_X86_MMX,COMPUTE_STORAGE_BUS_SATA,COMPUTE_VIOMMU_MODEL_INTEL,COMPUTE_NET_VIF_MODEL_PCNET,COMPUTE_GRAPHICS_MODEL_CIRRUS,COMPUTE_NET_VIF_MODEL_SPAPR_VLAN,COMPUTE_STORAGE_BUS_FDC,HW_CPU_X86_SSE,COMPUTE_STORAGE_BUS_USB,COMPUTE_RESCUE_BFV,COMPUTE_GRAPHICS_MODEL_QXL {{(pid\u003d76011) _refresh_associations /opt/stack/nova/nova/scheduler/client/report.py:839}}\n\n\nalthough i will note that based on domcaiablieis it looks like ubuntu 22.04 also does not supprot this at the libvirt level\n\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]: \u003cdomainCapabilities\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:   \u003cpath\u003e/usr/bin/qemu-system-x86_64\u003c/path\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:   \u003cdomain\u003eqemu\u003c/domain\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:   \u003cmachine\u003epc-q35-6.2\u003c/machine\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:   \u003carch\u003ex86_64\u003c/arch\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:   \u003cvcpu max\u003d\u0027288\u0027/\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:   \u003ciothreads supported\u003d\u0027yes\u0027/\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:   \u003cos supported\u003d\u0027yes\u0027\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:     \u003cenum name\u003d\u0027firmware\u0027/\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:     \u003cloader supported\u003d\u0027yes\u0027\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:       \u003cenum name\u003d\u0027type\u0027\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:         \u003cvalue\u003erom\u003c/value\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:         \u003cvalue\u003epflash\u003c/value\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:       \u003c/enum\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:       \u003cenum name\u003d\u0027readonly\u0027\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:         \u003cvalue\u003eyes\u003c/value\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:         \u003cvalue\u003eno\u003c/value\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:       \u003c/enum\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:       \u003cenum name\u003d\u0027secure\u0027\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:         \u003cvalue\u003eno\u003c/value\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:       \u003c/enum\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:     \u003c/loader\u003e\nAug 20 00:53:45.106480 np0038219697 nova-compute[76011]:   \u003c/os\u003e","commit_id":"b475f0f99b53fbc95ef9ba6cb1245989d8f7a948"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0bfbf7637ed5c09c5d8e0125c1d841b3728b870d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8a898647_550aba7d","in_reply_to":"bb5c39e7_c0d290e4","updated":"2024-08-20 11:14:25.000000000","message":"ah yes this need libvirt 8.6.0\nand 22.04 ships 8.0.0 so that makes sense.","commit_id":"b475f0f99b53fbc95ef9ba6cb1245989d8f7a948"}],"nova/virt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ecd9dcefe8b4a7366c8d144d5e7e5f45762d3135","unresolved":true,"context_lines":[{"line_number":169,"context_line":"        os_traits.COMPUTE_ADDRESS_SPACE_EMULATED,"},{"line_number":170,"context_line":"    \"supports_stateless_firmware\":"},{"line_number":171,"context_line":"        os_traits.COMPUTE_SECURITY_STATELESS_FIRMWARE,"},{"line_number":172,"context_line":"}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def _check_image_type_exclude_list(capability, supported):"}],"source_content_type":"text/x-python","patch_set":6,"id":"eef844d4_79bfb4da","line":172,"updated":"2024-08-19 14:11:17.000000000","message":"so at this point all drivers shoudl report this as false.","commit_id":"009974e739892dc3f45ee2f3c780e637e8251438"}],"nova/virt/fake.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ecd9dcefe8b4a7366c8d144d5e7e5f45762d3135","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        \"supports_remote_managed_ports\": True,"},{"line_number":122,"context_line":"        \"supports_address_space_passthrough\": True,"},{"line_number":123,"context_line":"        \"supports_address_space_emulated\": True,"},{"line_number":124,"context_line":"        \"supports_stateless_firmware\": True,"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Supported image types"},{"line_number":127,"context_line":"        \"supports_image_type_raw\": True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dcd5eb70_57ce84a2","line":124,"updated":"2024-08-19 14:11:17.000000000","message":"this is fine to hardcode as true becaue its a fake driver","commit_id":"009974e739892dc3f45ee2f3c780e637e8251438"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ecd9dcefe8b4a7366c8d144d5e7e5f45762d3135","unresolved":true,"context_lines":[{"line_number":910,"context_line":"        self.capabilities.update({"},{"line_number":911,"context_line":"            \u0027supports_stateless_firmware\u0027: supports_stateless_firmware,"},{"line_number":912,"context_line":"        })"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"    def _register_all_undefined_instance_details(self) -\u003e None:"},{"line_number":915,"context_line":"        \"\"\"Register the default image properties of instances on this host"},{"line_number":916,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"749ebc0d_c14db760","line":913,"updated":"2024-08-19 14:11:17.000000000","message":"this should be added to the next patch.\n\nits incorrect to report this as true since we do not have the ablity in nova libvirt driver to fullfile a request for this yet.","commit_id":"009974e739892dc3f45ee2f3c780e637e8251438"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e51956a5dca2f8b918c2b26797d89a2899d145c9","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        self.capabilities.update({"},{"line_number":911,"context_line":"            \u0027supports_stateless_firmware\u0027: supports_stateless_firmware,"},{"line_number":912,"context_line":"        })"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"    def _register_all_undefined_instance_details(self) -\u003e None:"},{"line_number":915,"context_line":"        \"\"\"Register the default image properties of instances on this host"},{"line_number":916,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8a6eaffa_65b832c8","line":913,"in_reply_to":"749ebc0d_c14db760","updated":"2024-08-20 00:37:50.000000000","message":"Done","commit_id":"009974e739892dc3f45ee2f3c780e637e8251438"}]}