)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8d46f080abbc7b228a7e09f69afdecda25a74039","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"72a21247_95fc406d","updated":"2024-02-15 15:54:45.000000000","message":"Any feedback welcome here. It\u0027s not immediately clear to me yet whether we can rely on Libvirt to copy the config drive in all cases.\n\nThere is a quite a lot to unpick. See here for starters: https://bugs.launchpad.net/nova/+bug/1246201","commit_id":"1c2c008cf25b23fb3b4a6fbb049fb100280d0031"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9dd0764d37eb3e92cc65f204296136bf69ddbef3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ee6c12bf_9264ada1","updated":"2024-07-26 15:47:07.000000000","message":"recheck","commit_id":"b4b6e7f3e358d0ebb8d33997d9f9f29989092ccb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ba9e7f3a9f12d7f8ac56af763adfa0fd91218c23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a2a4fcb0_6a4b4d5a","updated":"2024-11-18 12:49:40.000000000","message":"Basically, all supported libvirt versions since Rocky are able cope without this workaround, so removing this makes a lot of sense.\n\nI am too out of touch to want to +W right now, but I wanted to add my support, as this looks good, hence +2.","commit_id":"5827c0124693e9a66d3d0f356ad88300cc3ec554"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c96f3567ef7cc2318ecd1eca8840c7a5f12aa279","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b5899d3d_958de47b","updated":"2024-11-26 15:45:29.000000000","message":"Make sense","commit_id":"5827c0124693e9a66d3d0f356ad88300cc3ec554"},{"author":{"_account_id":37442,"name":"Serhii Ivanov","email":"evasive.gyron@gmail.com","username":"s3rj1k"},"change_message_id":"b3b1b61b860b789cc7a0f35f3dbcb72341ad431b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8ed769f1_3a0f5ef2","updated":"2024-11-28 20:12:17.000000000","message":"Yay!","commit_id":"5827c0124693e9a66d3d0f356ad88300cc3ec554"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d594de3f407ba40278fc8b706d5db4571c61a47a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9f653dc3_81440f18","updated":"2024-11-13 16:26:01.000000000","message":"just rebased this via the ui to get new results.\ni actually thought we merged this already so im still ok with removing this workaround.","commit_id":"5827c0124693e9a66d3d0f356ad88300cc3ec554"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1e9eb16cbe8b817f8431dc027682f307420019c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"85fdbfbd_9451e5d3","updated":"2024-11-14 00:56:58.000000000","message":"recheck openstack.tests.functional.compute.v2.test_volume_attachment.TestServerVolumeAttachment failed","commit_id":"5827c0124693e9a66d3d0f356ad88300cc3ec554"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d133e3c5a80cc2f5e8e85928bf06d8164a7d7f3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c9c52886_2e7c9e56","updated":"2024-11-28 12:18:56.000000000","message":"recheck test_resize_volume_backed_server_confirm failed with an SSH timeout, but passed previously","commit_id":"5827c0124693e9a66d3d0f356ad88300cc3ec554"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8d46f080abbc7b228a7e09f69afdecda25a74039","unresolved":true,"context_lines":[{"line_number":10872,"context_line":"                CONF.config_drive_format \u003d\u003d \u0027vfat\u0027):"},{"line_number":10873,"context_line":"                pass"},{"line_number":10874,"context_line":"            else:"},{"line_number":10875,"context_line":"                raise exception.NoLiveMigrationForConfigDriveInLibVirt()"},{"line_number":10876,"context_line":""},{"line_number":10877,"context_line":"        if not is_shared_instance_path:"},{"line_number":10878,"context_line":"            instance_dir \u003d libvirt_utils.get_instance_path_at_destination("}],"source_content_type":"text/x-python","patch_set":1,"id":"349d4b59_e30737c6","line":10875,"updated":"2024-02-15 15:54:45.000000000","message":"If libvirt is now taking care of moving the config drive in the default iso format, we could remove line 10861-10876?","commit_id":"bee9e083cb53fb40c5bb89559b9e3b96c5fdbc76"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7081777ac613a4943f1125fe253ded7dd4bdf05f","unresolved":true,"context_lines":[{"line_number":10872,"context_line":"                CONF.config_drive_format \u003d\u003d \u0027vfat\u0027):"},{"line_number":10873,"context_line":"                pass"},{"line_number":10874,"context_line":"            else:"},{"line_number":10875,"context_line":"                raise exception.NoLiveMigrationForConfigDriveInLibVirt()"},{"line_number":10876,"context_line":""},{"line_number":10877,"context_line":"        if not is_shared_instance_path:"},{"line_number":10878,"context_line":"            instance_dir \u003d libvirt_utils.get_instance_path_at_destination("}],"source_content_type":"text/x-python","patch_set":1,"id":"4e8be181_7e7fb223","line":10875,"in_reply_to":"349d4b59_e30737c6","updated":"2024-02-15 18:15:51.000000000","message":"we do not want to add this section back we shoudl just delete the code your removing and not add anything back in its place","commit_id":"bee9e083cb53fb40c5bb89559b9e3b96c5fdbc76"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"33cf303dc905d2cd3cc1054edf30247a6dd16e76","unresolved":false,"context_lines":[{"line_number":10872,"context_line":"                CONF.config_drive_format \u003d\u003d \u0027vfat\u0027):"},{"line_number":10873,"context_line":"                pass"},{"line_number":10874,"context_line":"            else:"},{"line_number":10875,"context_line":"                raise exception.NoLiveMigrationForConfigDriveInLibVirt()"},{"line_number":10876,"context_line":""},{"line_number":10877,"context_line":"        if not is_shared_instance_path:"},{"line_number":10878,"context_line":"            instance_dir \u003d libvirt_utils.get_instance_path_at_destination("}],"source_content_type":"text/x-python","patch_set":1,"id":"a20487ca_78a55d33","line":10875,"in_reply_to":"4e8be181_7e7fb223","updated":"2024-02-22 10:35:52.000000000","message":"Done","commit_id":"bee9e083cb53fb40c5bb89559b9e3b96c5fdbc76"}]}