)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d911e2fe16f246713ad9db0d5bb2b34640c66c26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"92b23f61_bdd66725","updated":"2024-02-16 17:03:59.000000000","message":"I see very little value in dropping these sorts of things, personally. We regularly see reports from operators where a tool fails to upgrade one or more compute node and they don\u0027t realize it until they end up with problems on the new side. I also selfishly want some of these specific ones to stay because downstream maintenance of older branches have some crossover with these.\n\nSo I\u0027m -1, asking for us to please have a PTG discussion about the strategy here before we just drop these en masse.","commit_id":"ffa7fec122927c1eaa9856827a91c4fc1ba7420f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"13db7738b527e8ec2108d881f828676888cbd0bb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1a42d0ef_d48c76c9","in_reply_to":"1cc15c4e_2432db5f","updated":"2024-02-25 22:30:29.000000000","message":"i kind of feel like before we clean this up we need to cleanup the v5 compute api.\n\nwe have been in v6 now for several release and the v5 compat code should be cleaned up\n\nin general i think im oke with this type of clean up but not right before Feature freeze.\nmy inclination is to keep the compat code for any releas that is still Stable/*\nor more generally i think we want to have 2 slurp releasse before the clean up.\nso in D we can clean up Z in F we can drop anelope/bobcat. basically in the non slurp release we could drop compat code for anything over 2 slurps old.\n\nthat might be a bit too concervitive but thats kind fo where i think the blance would be.","commit_id":"ffa7fec122927c1eaa9856827a91c4fc1ba7420f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0b0f3f1f6bad7901e61599dbecde0dd181c56ccb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1cc15c4e_2432db5f","in_reply_to":"92b23f61_bdd66725","updated":"2024-02-16 17:32:08.000000000","message":"Leaving a few comments. will discuss details later.\n\n* nova/compute/api.py is already huge and there are numbers of TODO comments. I see benefit of removing the unused logic and TODOs, to simplify the code for better readability\n* Some of the checks in later releases even call external services(neutron) which has performance cost\n* I understand the concern with upgrade, but I don\u0027t think it\u0027s reasonable to feasible to support users to mix 2024.1 and victoria. Officially speaking only 2023.1 and 2023.2 are supported as upgrade source. We can extend it a bit (like yoga or zed, according to LTS versions in each distro) but we can\u0027t support all releases, really.\n* I may agree with some side effect for cherry pick, though denying it means that we should not make any changes really in master.\n\nThere can be a balance so I totally agree with discussing the strategy first. The series of patches may show what can be removed if we move these forward","commit_id":"ffa7fec122927c1eaa9856827a91c4fc1ba7420f"}],"nova/compute/api.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"259247aa90b708fe8d13b5aae3b71be6125c3d3b","unresolved":true,"context_lines":[{"line_number":854,"context_line":"        minimal_version \u003d objects.service.get_minimum_version_all_cells("},{"line_number":855,"context_line":"            nova_context.get_admin_context(), [\u0027nova-compute\u0027])"},{"line_number":856,"context_line":"        if minimal_version \u003c MIN_VER_NOVA_COMPUTE_MIXED_POLICY:"},{"line_number":857,"context_line":"            raise exception.MixedInstanceNotSupportByComputeService()"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"    @staticmethod"},{"line_number":860,"context_line":"    def _validate_flavor_image_numa_pci("}],"source_content_type":"text/x-python","patch_set":4,"id":"684c0453_1433cc40","side":"PARENT","line":857,"range":{"start_line":857,"start_character":28,"end_line":857,"end_character":67},"updated":"2024-02-16 16:15:29.000000000","message":"this exception is not used by the other logics so can be removed.","commit_id":"84a3e254e88e8cc2797b61c082d9a67f27402682"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"97c11b14421132974f2f26138b84e896142ad700","unresolved":false,"context_lines":[{"line_number":854,"context_line":"        minimal_version \u003d objects.service.get_minimum_version_all_cells("},{"line_number":855,"context_line":"            nova_context.get_admin_context(), [\u0027nova-compute\u0027])"},{"line_number":856,"context_line":"        if minimal_version \u003c MIN_VER_NOVA_COMPUTE_MIXED_POLICY:"},{"line_number":857,"context_line":"            raise exception.MixedInstanceNotSupportByComputeService()"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"    @staticmethod"},{"line_number":860,"context_line":"    def _validate_flavor_image_numa_pci("}],"source_content_type":"text/x-python","patch_set":4,"id":"cff32cfb_b7fb74c6","side":"PARENT","line":857,"range":{"start_line":857,"start_character":28,"end_line":857,"end_character":67},"in_reply_to":"684c0453_1433cc40","updated":"2024-02-16 16:15:50.000000000","message":"Done","commit_id":"84a3e254e88e8cc2797b61c082d9a67f27402682"}]}