)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9a6801725d58dea8efcf76548b84663853569c0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1e9d307e_4c8fb7d3","updated":"2024-02-23 21:27:37.000000000","message":"recheck https://review.opendev.org/c/openstack/nova/+/909859 has merged","commit_id":"0114d0de150873ba099f44fd0f94602d16e5384c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"48fcf5f1e1c0c7858aaa6ead3b4f527c2ec6e7e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"276efa65_3c843906","updated":"2024-06-06 06:16:55.000000000","message":"recheck Waiting for libvirt event about the detach of device vdb with device alias ua-6ff66b0d-c283-4d92-8fd4-7312863cc140 from instance 4927a694-fe14-42db-9613-40e6358f3066 is timed out.\n\nJun 05 04:53:15.015639 np0037664991 nova-compute[86092]: ERROR os_brick.initiator.connectors.iscsi Stdout: \u0027SENDTARGETS:\\nNo targets found.\\niSNS:\\nNo targets found.\\nSTATIC:\\nNo targets found.\\nFIRMWARE:\\nNo targets found.\\n\u0027","commit_id":"66900c9c91bf711f2a72431c3f954c9feff840f2"}],"nova/tests/functional/libvirt/test_ephemeral_encryption.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"36c22cb0bce7b9eadbe61b136724cb2f4dbc0dc5","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        # just allow admins to perform cross-cell resize."},{"line_number":399,"context_line":"        self.policy.set_rules("},{"line_number":400,"context_line":"            {servers_policies.CROSS_CELL_RESIZE: base_policies.RULE_ADMIN_API},"},{"line_number":401,"context_line":"            overwrite\u003dFalse)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def test_resize_server(self, is_resize\u003dTrue):"},{"line_number":404,"context_line":"        # Verify there are no secrets in the key manager."}],"source_content_type":"text/x-python","patch_set":4,"id":"040aceb9_d12de1b9","line":401,"updated":"2024-02-26 14:03:31.000000000","message":"really i tought that default to admin good to know","commit_id":"0114d0de150873ba099f44fd0f94602d16e5384c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"36c22cb0bce7b9eadbe61b136724cb2f4dbc0dc5","unresolved":true,"context_lines":[{"line_number":446,"context_line":"        # The secrets should still be on the source too, along with the disks."},{"line_number":447,"context_line":"        self.assertSecretsMatch(server, 3, src_driver, bdms\u003dbdms)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        # Revert the resize or migration."},{"line_number":450,"context_line":"        self._revert_resize(server)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        # Assert that it moved back."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3e1b94_b475d088","line":449,"updated":"2024-02-26 14:03:31.000000000","message":"same comment as eairer in the seriese\ni would generally like to see this as 3 tests\n\none to assert you can get to resize verify\none to assert you can revert\nand one to assert you can confrim.","commit_id":"0114d0de150873ba099f44fd0f94602d16e5384c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"922c73ad46f62c28fd866955b1ba6b86ea9694c1","unresolved":true,"context_lines":[{"line_number":446,"context_line":"        # The secrets should still be on the source too, along with the disks."},{"line_number":447,"context_line":"        self.assertSecretsMatch(server, 3, src_driver, bdms\u003dbdms)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        # Revert the resize or migration."},{"line_number":450,"context_line":"        self._revert_resize(server)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        # Assert that it moved back."}],"source_content_type":"text/x-python","patch_set":4,"id":"07bbd209_cca3bf41","line":449,"in_reply_to":"5a3e1b94_b475d088","updated":"2024-02-28 06:42:24.000000000","message":"That\u0027s fair.. maybe was trying to avoid some duplication. And maybe was also thinking there could be some value in asserting that actions done in sequence manage the secrets correctly i.e. don\u0027t leave residue. But maybe there would be no difference in doing them separate.","commit_id":"0114d0de150873ba099f44fd0f94602d16e5384c"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"36c22cb0bce7b9eadbe61b136724cb2f4dbc0dc5","unresolved":true,"context_lines":[{"line_number":1750,"context_line":"        # the BDMs and block_device_info in this case."},{"line_number":1751,"context_line":"        if block_device_info is None:"},{"line_number":1752,"context_line":"            bdm_list \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":1753,"context_line":"                context, instance.uuid)"},{"line_number":1754,"context_line":"            if bdm_list:"},{"line_number":1755,"context_line":"                block_device_info \u003d driver.get_block_device_info("},{"line_number":1756,"context_line":"                    instance, bdm_list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf0af534_337e2d00","line":1753,"updated":"2024-02-26 14:03:31.000000000","message":"doing a db accesses form the driver here is kind of unfortunate.\nit would be better if the compute manager had pass this in with a non none value\nis that something we can do?","commit_id":"0114d0de150873ba099f44fd0f94602d16e5384c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"922c73ad46f62c28fd866955b1ba6b86ea9694c1","unresolved":true,"context_lines":[{"line_number":1750,"context_line":"        # the BDMs and block_device_info in this case."},{"line_number":1751,"context_line":"        if block_device_info is None:"},{"line_number":1752,"context_line":"            bdm_list \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":1753,"context_line":"                context, instance.uuid)"},{"line_number":1754,"context_line":"            if bdm_list:"},{"line_number":1755,"context_line":"                block_device_info \u003d driver.get_block_device_info("},{"line_number":1756,"context_line":"                    instance, bdm_list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a498ba7_811adff9","line":1753,"in_reply_to":"bf0af534_337e2d00","updated":"2024-02-28 06:42:24.000000000","message":"I agree it\u0027s unfortunate ... but it\u0027s doing this on purpose saying that it\u0027s intentionally passing None to prevent cleanup() from trying to unplug VIFs or disconnect volumes:\n\nhttps://github.com/openstack/nova/blob/7fa1859576ac577da89cb817f93b1c54d3a937ce/nova/compute/manager.py#L5025\n\nAny suggestion?","commit_id":"0114d0de150873ba099f44fd0f94602d16e5384c"}]}