)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8a680ed20b8dbee22d7642d843b564cbc8c2c6e4","unresolved":true,"context_lines":[{"line_number":12753,"context_line":"        inst_uuid_from_migrations \u003d set([migration.instance_uuid for migration"},{"line_number":12754,"context_line":"                                         in migrations])"},{"line_number":12755,"context_line":"        inst_mdevs \u003d set(self.instance_claimed_mdevs.keys())"},{"line_number":12756,"context_line":"        stale_inst_claimed \u003d inst_mdevs - inst_uuid_from_migrations"},{"line_number":12757,"context_line":"        for inst_uuid in stale_inst_claimed:"},{"line_number":12758,"context_line":"            mdevs \u003d self.instance_claimed_mdevs.pop(inst_uuid, None)"},{"line_number":12759,"context_line":"            if mdevs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"42972392_620adb08","line":12756,"range":{"start_line":12756,"start_character":8,"end_line":12756,"end_character":27},"updated":"2024-02-22 15:37:04.000000000","message":"I don\u0027t think this is right. The migrations passed in here are \"in progress or error\" but you seem to be assuming they\u0027re all error. If this runs while a migration is happening, I think we\u0027ll nuke reservations we shouldn\u0027t. I think you just need to filter the list we get by only error, right? That said, we really would want to know about complete migrations too in order to actually clean up this list I think. But, what you have here is a lot better than it was, so ++.","commit_id":"45ed65de43e714a746e4677b92add862187411d8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8aec92587fc33c9fe82df7e46dab9b326f52e74c","unresolved":true,"context_lines":[{"line_number":12753,"context_line":"        inst_uuid_from_migrations \u003d set([migration.instance_uuid for migration"},{"line_number":12754,"context_line":"                                         in migrations])"},{"line_number":12755,"context_line":"        inst_mdevs \u003d set(self.instance_claimed_mdevs.keys())"},{"line_number":12756,"context_line":"        stale_inst_claimed \u003d inst_mdevs - inst_uuid_from_migrations"},{"line_number":12757,"context_line":"        for inst_uuid in stale_inst_claimed:"},{"line_number":12758,"context_line":"            mdevs \u003d self.instance_claimed_mdevs.pop(inst_uuid, None)"},{"line_number":12759,"context_line":"            if mdevs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"34e2c9dc_6dd5cf32","line":12756,"range":{"start_line":12756,"start_character":8,"end_line":12756,"end_character":27},"in_reply_to":"1cdb1a56_5b928ccb","updated":"2024-02-27 15:58:52.000000000","message":"(from our chat):\n\nOkay I think I had the math inverted in my head, but the issue is still sort of the same. What you want to do here is \"exclude in-progress migations\" from the cleanup. However, you\u0027re also excluding the error ones, because we got \"in progress or error\" from the query in compute manager. So maybe just filter the above list for things that have one of our error states which will accomplish the goal?","commit_id":"45ed65de43e714a746e4677b92add862187411d8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"283f25ddb7670aa737916f4a4d5d5d866a0c4ff2","unresolved":true,"context_lines":[{"line_number":12753,"context_line":"        inst_uuid_from_migrations \u003d set([migration.instance_uuid for migration"},{"line_number":12754,"context_line":"                                         in migrations])"},{"line_number":12755,"context_line":"        inst_mdevs \u003d set(self.instance_claimed_mdevs.keys())"},{"line_number":12756,"context_line":"        stale_inst_claimed \u003d inst_mdevs - inst_uuid_from_migrations"},{"line_number":12757,"context_line":"        for inst_uuid in stale_inst_claimed:"},{"line_number":12758,"context_line":"            mdevs \u003d self.instance_claimed_mdevs.pop(inst_uuid, None)"},{"line_number":12759,"context_line":"            if mdevs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb490834_792b10eb","line":12756,"range":{"start_line":12756,"start_character":8,"end_line":12756,"end_character":27},"in_reply_to":"1cdb1a56_5b928ccb","updated":"2024-02-27 15:58:52.000000000","message":"As discussed on Gmeet, I\u0027ll just check the status for the migrations and remove the ones that on error","commit_id":"45ed65de43e714a746e4677b92add862187411d8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"99d215d4e30c79297efc286a980e005a68ee3945","unresolved":true,"context_lines":[{"line_number":12753,"context_line":"        inst_uuid_from_migrations \u003d set([migration.instance_uuid for migration"},{"line_number":12754,"context_line":"                                         in migrations])"},{"line_number":12755,"context_line":"        inst_mdevs \u003d set(self.instance_claimed_mdevs.keys())"},{"line_number":12756,"context_line":"        stale_inst_claimed \u003d inst_mdevs - inst_uuid_from_migrations"},{"line_number":12757,"context_line":"        for inst_uuid in stale_inst_claimed:"},{"line_number":12758,"context_line":"            mdevs \u003d self.instance_claimed_mdevs.pop(inst_uuid, None)"},{"line_number":12759,"context_line":"            if mdevs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1cdb1a56_5b928ccb","line":12756,"range":{"start_line":12756,"start_character":8,"end_line":12756,"end_character":27},"in_reply_to":"42972392_620adb08","updated":"2024-02-27 15:31:59.000000000","message":"Not sure I understand your point. The calculation I\u0027m doing is : \n- which migrations are currently running or on error ? (migrations)\n- which instance UUIDs do we have for those migrations ? (inst_uuid_from_migrations)\n- now, get me all the instance UUIDs that we have in the dict (inst_mdevs)\n- then, calculate which instance UUIDs in the dict that are not in inst_uuid_from_migrations (stale_inst_claimed)\n\nso, this stale_inst_claimed set should only be the list of instance UUIDs that are not currently running on on error (so, generally done), so that\u0027s why I\u0027m deleting them below.","commit_id":"45ed65de43e714a746e4677b92add862187411d8"}]}