)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ab908c14cc8d85c679676817fc887e153f67cf94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcabc96b_02125aa4","updated":"2024-02-22 12:30:17.000000000","message":"by this we loose some test coverage from the heal allocation CLI. We need to unblock the gate, so I\u0027m +2 but we should think about to get back the coverage somehow","commit_id":"844eac60ebc627dfa3e99f6ccc4da1121ac653d5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"465193214c911ea1bb12d0c25dff19cead3ef3c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1479425c_bc40ee1f","updated":"2024-02-22 17:10:50.000000000","message":"let\u0027s wait what Zuul is saying now","commit_id":"17f97e857cac76e81ae336b6e4fec61425f5b29f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"333526be42ab5f2673146ef95f3ff06ef4355d31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fdf0e777_2e55d40c","in_reply_to":"1479425c_bc40ee1f","updated":"2024-02-22 17:16:08.000000000","message":"+1, standing by to approve once we get the CI result","commit_id":"17f97e857cac76e81ae336b6e4fec61425f5b29f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"52fb7417cb6e4a66f599729fb967187f5fe287ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"27198361_beda8c3b","updated":"2024-02-23 03:34:13.000000000","message":"I\u0027m going to fast approve this to unblock the gate. gibi and Sylvain were +2/+W on PS1 and there were a few more places where commands needed to be removed in order for nova-next to pass","commit_id":"2dff0f1c76c9ade41c23dce217621be012d653f3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bd5bc00c4fa80524361a45a058fb7265675580b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cb170764_b2c42cad","updated":"2024-02-22 23:00:53.000000000","message":"While this PS passed nova-next, it looks like nova-ceph-multistore is also failing at 100%, so we can\u0027t yet merge this.\n\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dnova-ceph-multistore\u0026project\u003dopenstack/nova","commit_id":"2dff0f1c76c9ade41c23dce217621be012d653f3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5426f34992994ddb8d2b3f7752ebbd65e34c697d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"af4dc063_84694000","updated":"2024-02-23 00:51:22.000000000","message":"recheck https://review.opendev.org/c/openstack/requirements/+/909923 might have fixed nova-ceph-multistore","commit_id":"2dff0f1c76c9ade41c23dce217621be012d653f3"}],"gate/post_test_hook.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b8cfa8849d74c1074cc62403e1d99649db66b897","unresolved":true,"context_lines":[{"line_number":144,"context_line":"# (non-allocation-y) stuff and then later assert that this stuff is still"},{"line_number":145,"context_line":"# there after the heal."},{"line_number":146,"context_line":"# Cf. https://review.opendev.org/#/c/637955/35/nova/cmd/manage.py@1896"},{"line_number":147,"context_line":"openstack port set port-normal-qos --binding-profile my_key\u003dmy_value"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"image_id\u003d$(openstack image list -f value -c ID | awk \u0027NR\u003d\u003d1{print $1}\u0027)"},{"line_number":150,"context_line":"flavor_id\u003d$(openstack flavor list -f value -c ID | awk \u0027NR\u003d\u003d1{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f700818_b7f34afe","side":"PARENT","line":147,"updated":"2024-02-22 12:57:46.000000000","message":"note a way to adress gibi\u0027s test coverage concern is to add a python script to this dir that will improt novas service token code and use our neutron clinet funcitons to just set this value as nova.\n\nthat not hard but not something i have time to do right now","commit_id":"3209f6551652cff7bef0b9d9719ab940dd05a0f8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"70c7c466c75141912d546953ba0f99014f22846b","unresolved":true,"context_lines":[{"line_number":161,"context_line":"fi"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# Make sure that the binding:profile.allocation key is updated"},{"line_number":164,"context_line":"rp_uuid\u003d$(get_binding_profile_value port-normal-qos \"allocation\")"},{"line_number":165,"context_line":"if [[ \"$rp_uuid\" \u003d\u003d \"\" ]]; then"},{"line_number":166,"context_line":"    echo \"No allocation found for the bandwidth aware port.\""},{"line_number":167,"context_line":"    exit 2"}],"source_content_type":"text/x-sh","patch_set":1,"id":"f250715d_f295724a","line":164,"updated":"2024-02-22 16:13:41.000000000","message":"This seems to not fail the job so I dunno what specific actions won\u0027t work without the service token.","commit_id":"844eac60ebc627dfa3e99f6ccc4da1121ac653d5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a389e52501ddf9ee0e2f088f0a9a15878b0602ff","unresolved":true,"context_lines":[{"line_number":161,"context_line":"fi"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# Make sure that the binding:profile.allocation key is updated"},{"line_number":164,"context_line":"rp_uuid\u003d$(get_binding_profile_value port-normal-qos \"allocation\")"},{"line_number":165,"context_line":"if [[ \"$rp_uuid\" \u003d\u003d \"\" ]]; then"},{"line_number":166,"context_line":"    echo \"No allocation found for the bandwidth aware port.\""},{"line_number":167,"context_line":"    exit 2"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5df9970b_956b0da3","line":164,"in_reply_to":"f250715d_f295724a","updated":"2024-02-22 17:02:52.000000000","message":"Modifying the binding profile now needs a service token with the service role.\nreading shoudl be fine as admin.","commit_id":"844eac60ebc627dfa3e99f6ccc4da1121ac653d5"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"70c7c466c75141912d546953ba0f99014f22846b","unresolved":true,"context_lines":[{"line_number":171,"context_line":"openstack resource provider allocation delete ${server_id}"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"echo \"Deleting allocation key from the binding:profile of the bandwidth aware port\""},{"line_number":174,"context_line":"openstack port unset --binding-profile allocation port-normal-qos"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"# Make sure the allocations are gone."},{"line_number":177,"context_line":"allocations\u003d$(openstack resource provider allocation show ${server_id} \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"61893926_372e2bcb","line":174,"updated":"2024-02-22 16:13:41.000000000","message":"This one is still failing.\n```\n+ echo \u0027Deleting allocation key from the binding:profile of the bandwidth aware port\u0027\nDeleting allocation key from the binding:profile of the bandwidth aware port\n+ openstack port unset --binding-profile allocation port-normal-qos\nForbiddenException: 403: Client Error for url: https://213.32.74.123:9696/networking/v2.0/ports/f5b273ab-1c98-44f6-9664-8c1a16d5abda, (rule:update_port and rule:update_port:binding:profile) is disallowed by policy\n```","commit_id":"844eac60ebc627dfa3e99f6ccc4da1121ac653d5"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"70c7c466c75141912d546953ba0f99014f22846b","unresolved":true,"context_lines":[{"line_number":182,"context_line":"fi"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"# Make sure that the binding:profile.allocation key is gone"},{"line_number":185,"context_line":"null_rp_uuid\u003d$(get_binding_profile_value port-normal-qos \"allocation\")"},{"line_number":186,"context_line":"if [[ \"$null_rp_uuid\" !\u003d \"\" ]]; then"},{"line_number":187,"context_line":"    echo \"Binding profile not updated for the bandwidth aware port.\""},{"line_number":188,"context_line":"    exit 2"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3ef25cf5_15015ff7","line":185,"updated":"2024-02-22 16:13:41.000000000","message":"Not sure if this one needs to be removed?","commit_id":"844eac60ebc627dfa3e99f6ccc4da1121ac653d5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a389e52501ddf9ee0e2f088f0a9a15878b0602ff","unresolved":true,"context_lines":[{"line_number":182,"context_line":"fi"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"# Make sure that the binding:profile.allocation key is gone"},{"line_number":185,"context_line":"null_rp_uuid\u003d$(get_binding_profile_value port-normal-qos \"allocation\")"},{"line_number":186,"context_line":"if [[ \"$null_rp_uuid\" !\u003d \"\" ]]; then"},{"line_number":187,"context_line":"    echo \"Binding profile not updated for the bandwidth aware port.\""},{"line_number":188,"context_line":"    exit 2"}],"source_content_type":"text/x-sh","patch_set":1,"id":"dd4cb93e_19c9b371","line":185,"in_reply_to":"3ef25cf5_15015ff7","updated":"2024-02-22 17:02:52.000000000","message":"its remvoed because im removing the delete so it will now still be set.","commit_id":"844eac60ebc627dfa3e99f6ccc4da1121ac653d5"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"70c7c466c75141912d546953ba0f99014f22846b","unresolved":true,"context_lines":[{"line_number":218,"context_line":"fi"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"# Make sure that the binding:profile.allocation key healed back"},{"line_number":221,"context_line":"healed_rp_uuid\u003d$(get_binding_profile_value port-normal-qos \"allocation\")"},{"line_number":222,"context_line":"if [[ \"$rp_uuid\" !\u003d \"$healed_rp_uuid\" ]]; then"},{"line_number":223,"context_line":"    echo \"The value of the allocation key of the bandwidth aware port does not match.\""},{"line_number":224,"context_line":"    echo \"expected: $rp_uuid; actual: $healed_rp_uuid.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"4c3b27a3_3ebf1fff","line":221,"updated":"2024-02-22 16:13:41.000000000","message":"Not sure if this one needs to be removed?","commit_id":"844eac60ebc627dfa3e99f6ccc4da1121ac653d5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a389e52501ddf9ee0e2f088f0a9a15878b0602ff","unresolved":true,"context_lines":[{"line_number":218,"context_line":"fi"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"# Make sure that the binding:profile.allocation key healed back"},{"line_number":221,"context_line":"healed_rp_uuid\u003d$(get_binding_profile_value port-normal-qos \"allocation\")"},{"line_number":222,"context_line":"if [[ \"$rp_uuid\" !\u003d \"$healed_rp_uuid\" ]]; then"},{"line_number":223,"context_line":"    echo \"The value of the allocation key of the bandwidth aware port does not match.\""},{"line_number":224,"context_line":"    echo \"expected: $rp_uuid; actual: $healed_rp_uuid.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"72be01af_cf42cf85","line":221,"in_reply_to":"4c3b27a3_3ebf1fff","updated":"2024-02-22 17:02:52.000000000","message":"this should pass as we did not mess with the port","commit_id":"844eac60ebc627dfa3e99f6ccc4da1121ac653d5"}]}
