)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6a253f814170c2b0be4e116e0c2e75cd7fda938d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5217250b_d99779ac","updated":"2024-02-29 02:13:42.000000000","message":"we have seen issues with using this in wsgi rest apis and we no it breaks non wsgi services so im not sure we should still be encuraging the use of heartbeat_in_pthread and im really not conviced it should be on by default.\n\nim currently incliend to recommend never using it with nova.","commit_id":"4cbb27854bba8655f1d8b32aeb9f41a9f1970b82"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"520561cd8796c73b4fc22c691d595e1bfb200155","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34ec311d_9e4b85ba","in_reply_to":"5217250b_d99779ac","updated":"2024-02-29 02:24:35.000000000","message":"for more context we are building a new installer for openstack at redhat and we are always setting it to false even when runing under apache mod_wsgi\n\nhttps://github.com/openstack-k8s-operators/nova-operator/blob/d0fc19939cd0356ae8237ef73aaa7fed5ab56154/templates/nova.conf#L62\n\n```\n{{ if eq .service_name \"nova-api\"}}\n# We cannot set this to true while is\n# https://review.opendev.org/c/openstack/oslo.log/+/852443 is not used in the\n# nova-api image otherwise logging from the heartbeat thread will cause hangs.\nheartbeat_in_pthread\u003dfalse\n```\nas noted in the comment this is because of # https://review.opendev.org/c/openstack/oslo.log/+/852443\n\nwe did not have that in antelope at the tiem so we had to turn off heathbeat_in_pthread. \n\ni am reluctant to turn that on again becuase we have never had any bugs affecting code by having heartbeat_in_pthread\u003dfalse, it was orginally added for a log message but not to fix any real issue impacting production. we have had multiple issue with heartbeat_in_pthread\u003dtrue so as it provides littel to no realworld benifit and is know to cause hard to diagnose realworld probelm due to bugs and eventlest compatibality i really dont think truning it on automatically is the right hting to do.","commit_id":"4cbb27854bba8655f1d8b32aeb9f41a9f1970b82"}]}